[GitHub] [incubator-pinot] haibow commented on a change in pull request #4838: Update schema API to reload table on schema change when applicable

[GitBox <gi...@apache.org>]

haibow commented on a change in pull request #4838: Update schema API to reload table on schema change when applicable
URL: https://github.com/apache/incubator-pinot/pull/4838#discussion_r349829501
 
 

 ##########
 File path: pinot-common/src/main/java/org/apache/pinot/common/config/TableNameBuilder.java
 ##########
 @@ -113,6 +114,26 @@ public static String extractRawTableName(@Nonnull String tableName) {
     return tableName;
   }
 
+  /**
+   * Get the table name after adding the given type suffix.
+   *
+   * @param tableNameOptType Table name with or without type suffix
+   * @param tableType Table type suffix
+   * @return Table name with type suffix
+   */
+  public static String getTableNameWithType(String tableNameOptType, @Nullable CommonConstants.Helix.TableType tableType) {
 
 Review comment:
   Thanks for the suggestion. I saw it in TableViews.java and moved it here. I was going to use it but later found other alternatives. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org