You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/03/09 19:49:00 UTC

[GitHub] [beam] riteshghorse commented on a change in pull request #17047: [BEAM-3304] documentation for PaneInfo in BPG

riteshghorse commented on a change in pull request #17047:
URL: https://github.com/apache/beam/pull/17047#discussion_r823022809



##########
File path: website/www/site/content/en/documentation/programming-guide.md
##########
@@ -2150,9 +2149,11 @@ class ProcessRecord(beam.DoFn):
 {{< /highlight >}}
 
 {{< highlight go >}}
-// PaneInfo and triggers are not yet implemented in the Go SDK.
-// See https://issues.apache.org/jira/browse/BEAM-3304 for info
-// on contributing triggers and panes.
+func MyDoFn(pn beam.PaneInfo, word string) string {
+  t := int(pn.timing)
+  isFirstPane, isLastPane := pn.IsFirst, pn.IsLast
+  ...
+}

Review comment:
       Done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org