You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2022/01/19 19:10:03 UTC
[kudu-CR] [docs] update on clock synchronization in 'known issues'
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18161
Change subject: [docs] update on clock synchronization in 'known issues'
......................................................................
[docs] update on clock synchronization in 'known issues'
Change-Id: Ic3ade268887380dc36e0314b04c1e624c12ac563
---
M docs/known_issues.adoc
1 file changed, 6 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/61/18161/1
--
To view, visit http://gerrit.cloudera.org:8080/18161
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic3ade268887380dc36e0314b04c1e624c12ac563
Gerrit-Change-Number: 18161
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [docs] update on clock synchronization in 'known issues'
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Zoltan Chovan, Attila Bukor, Kudu Jenkins, Andrew Wong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18161
to look at the new patch set (#2).
Change subject: [docs] update on clock synchronization in 'known issues'
......................................................................
[docs] update on clock synchronization in 'known issues'
Change-Id: Ic3ade268887380dc36e0314b04c1e624c12ac563
---
M docs/known_issues.adoc
1 file changed, 5 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/61/18161/2
--
To view, visit http://gerrit.cloudera.org:8080/18161
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic3ade268887380dc36e0314b04c1e624c12ac563
Gerrit-Change-Number: 18161
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] [docs] update on clock synchronization in 'known issues'
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18161 )
Change subject: [docs] update on clock synchronization in 'known issues'
......................................................................
[docs] update on clock synchronization in 'known issues'
Change-Id: Ic3ade268887380dc36e0314b04c1e624c12ac563
Reviewed-on: http://gerrit.cloudera.org:8080/18161
Tested-by: Kudu Jenkins
Reviewed-by: Andrew Wong <aw...@cloudera.com>
---
M docs/known_issues.adoc
1 file changed, 5 insertions(+), 2 deletions(-)
Approvals:
Kudu Jenkins: Verified
Andrew Wong: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/18161
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic3ade268887380dc36e0314b04c1e624c12ac563
Gerrit-Change-Number: 18161
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] [docs] update on clock synchronization in 'known issues'
Posted by "Zoltan Chovan (Code Review)" <ge...@cloudera.org>.
Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/18161 )
Change subject: [docs] update on clock synchronization in 'known issues'
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18161/1/docs/known_issues.adoc
File docs/known_issues.adoc:
http://gerrit.cloudera.org:8080/#/c/18161/1/docs/known_issues.adoc@132
PS1, Line 132: using NTP
nit: using 'an' NTP server
--
To view, visit http://gerrit.cloudera.org:8080/18161
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3ade268887380dc36e0314b04c1e624c12ac563
Gerrit-Change-Number: 18161
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Wed, 19 Jan 2022 19:22:58 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docs] update on clock synchronization in 'known issues'
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18161 )
Change subject: [docs] update on clock synchronization in 'known issues'
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/18161/1/docs/known_issues.adoc
File docs/known_issues.adoc:
http://gerrit.cloudera.org:8080/#/c/18161/1/docs/known_issues.adoc@131
PS1, Line 131: make the local clock on a node
: synchronized using NTP server such as `ntpd`
nit: how about "either synchronize the local clock using an NTP server such as `ntpd` or `chronyd`"
http://gerrit.cloudera.org:8080/#/c/18161/1/docs/known_issues.adoc@133
PS1, Line 133: or use the built-in NTP client for Kudu masters and
: tablet servers.
Would it make sense to mention the --time_source flag? Also, should we suggest "auto"?
--
To view, visit http://gerrit.cloudera.org:8080/18161
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3ade268887380dc36e0314b04c1e624c12ac563
Gerrit-Change-Number: 18161
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Wed, 19 Jan 2022 20:36:03 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docs] update on clock synchronization in 'known issues'
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18161 )
Change subject: [docs] update on clock synchronization in 'known issues'
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/18161/1/docs/known_issues.adoc
File docs/known_issues.adoc:
http://gerrit.cloudera.org:8080/#/c/18161/1/docs/known_issues.adoc@131
PS1, Line 131: make the local clock on a node
: synchronized using NTP server such as `ntpd`
> nit: how about "either synchronize the local clock using an NTP server such
Done
http://gerrit.cloudera.org:8080/#/c/18161/1/docs/known_issues.adoc@132
PS1, Line 132: using NTP
> nit: using 'an' NTP server
Done
--
To view, visit http://gerrit.cloudera.org:8080/18161
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3ade268887380dc36e0314b04c1e624c12ac563
Gerrit-Change-Number: 18161
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Wed, 19 Jan 2022 20:57:04 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docs] update on clock synchronization in 'known issues'
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18161 )
Change subject: [docs] update on clock synchronization in 'known issues'
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18161/1/docs/known_issues.adoc
File docs/known_issues.adoc:
http://gerrit.cloudera.org:8080/#/c/18161/1/docs/known_issues.adoc@133
PS1, Line 133: or use the built-in NTP client for Kudu masters and
: tablet servers.
> Would it make sense to mention the --time_source flag? Also, should we sugg
Yes, it would, but not in the 'known issues' document since that would be too much details. I'm planning to post a separate update on the docs providing details on the internal built-in client and the time source overall.
--
To view, visit http://gerrit.cloudera.org:8080/18161
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3ade268887380dc36e0314b04c1e624c12ac563
Gerrit-Change-Number: 18161
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Wed, 19 Jan 2022 20:56:37 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docs] update on clock synchronization in 'known issues'
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18161 )
Change subject: [docs] update on clock synchronization in 'known issues'
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18161
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3ade268887380dc36e0314b04c1e624c12ac563
Gerrit-Change-Number: 18161
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Wed, 19 Jan 2022 21:24:15 +0000
Gerrit-HasComments: No