[jira] Commented: (OFBIZ-1170) FreeMarkerWorker class has a bug in its caching logic

["David E. Jones (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-1170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12514930 ] 

David E. Jones commented on OFBIZ-1170:
---------------------------------------

My feedback on this: in addition to fixing the bug mentioned there is quite a bit of refactoring done here. That's totally fine, but it does make it hard to review.

The best next step forward because of this is for a number of people to apply the patch and run it locally for a little while and hopefully also find a few scenarios within the scope of their concern to exercise this.

To all interested: please help and review this and comment back here.

> FreeMarkerWorker class has a bug in its caching logic
> -----------------------------------------------------
>
>                 Key: OFBIZ-1170
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1170
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk, Release Branch 4.0
>            Reporter: Adrian Crum
>            Priority: Minor
>         Attachments: FreeMarkerWorker.patch, FreeMarkerWorker.patch, FreeMarkerWorker.patch
>
>
> The FreeMarkerWorker class creates an instance of the Template class, initializes it with the current user's locale, then stores it in a cache. Other users will see the template rendered in the first user's locale, regardless of their locale setting.
> This can be demonstrated on the Hot Wax demo site in the WorkEffort calendar. Some elements in the screen are rendered in another locale, regardless of your current locale setting.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.