You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zookeeper.apache.org by GitBox <gi...@apache.org> on 2019/03/29 04:59:30 UTC

[GitHub] [zookeeper] jhuan31 edited a comment on issue #853: ZOOKEEPER-3316: Remove unused code in SyncRequestProcessor

jhuan31 edited a comment on issue #853: ZOOKEEPER-3316: Remove unused code in SyncRequestProcessor
URL: https://github.com/apache/zookeeper/pull/853#issuecomment-477867662
 
 
   @lvfangmin @BELUGABEHR @phunt @eolivelli 
   It's so strange... I can't find in newPatchFindbugsWarnings.xml (I remember it was Findbugs complaining, not Spotbugs) from history build artifacts that has both "redundant null check" and "unreachable code". They only have "redundant null check", which is also fixed in @BELUGABEHR's PR. So we probably don't need this PR. I'm sorry about the confusion caused--though I'm still confused coz I don't know this code good enough to come up with "unreachable code" on my own.  I must have seen this "unreachable code" somewhere.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services