You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hawq.apache.org by xinzweb <gi...@git.apache.org> on 2016/01/15 00:43:18 UTC
[GitHub] incubator-hawq pull request: Fix 'hawq' issue for OSX after Python...
GitHub user xinzweb opened a pull request:
https://github.com/apache/incubator-hawq/pull/269
Fix 'hawq' issue for OSX after Python is removed.
Fix following environment only for OSX:
Remove ext/python/bin from PATH to avoid using the Python version from HAWQ.
Remove the library path lib/python/pygresql from PYTHONPATH.
Remove ext/python/lib from DYLD_LIBRARY_PATH.
@hornn @radarwave
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/xinzweb/incubator-hawq apache_hawq_fix_python
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/269.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #269
----
commit 1104d611034c580b18e8cf35f94e926d2d13c681
Author: Xin Zhang <xz...@pivotal.io>
Date: 2016-01-07T19:07:41Z
Fix 'hawq' issue for OSX after Python is removed.
Fix following environment only for OSX:
Remove ext/python/bin from PATH to avoid using the Python version from HAWQ.
Remove the library path lib/python/pygresql from PYTHONPATH.
Remove ext/python/lib from DYLD_LIBRARY_PATH.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: Fix 'hawq' issue for OSX after Python...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-hawq/pull/269
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: Fix 'hawq' issue for OSX after Python...
Posted by xinzweb <gi...@git.apache.org>.
Github user xinzweb commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/269#discussion_r49811471
--- Diff: tools/bin/generate-greenplum-path.sh ---
@@ -56,26 +56,26 @@ if [ -h \${GPHOME}/../hawq ]; then
fi
EOF
-# OSX does not need JAVA_HOME
+# OSX does NOT have DYLD_LIBRARY_PATH, add it
if [ "${PLAT}" = "Darwin" ] ; then
-cat << EOF
-PATH=\$GPHOME/bin:\$GPHOME/ext/python/bin:\$PATH
-DYLD_LIBRARY_PATH=\$GPHOME/lib:\$GPHOME/ext/python/lib:\$DYLD_LIBRARY_PATH
+ cat << EOF
--- End diff --
Good catch, fixed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: Fix 'hawq' issue for OSX after Python...
Posted by hornn <gi...@git.apache.org>.
Github user hornn commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/269#discussion_r49806221
--- Diff: tools/bin/generate-greenplum-path.sh ---
@@ -56,26 +56,26 @@ if [ -h \${GPHOME}/../hawq ]; then
fi
EOF
-# OSX does not need JAVA_HOME
+# OSX does NOT have DYLD_LIBRARY_PATH, add it
if [ "${PLAT}" = "Darwin" ] ; then
-cat << EOF
-PATH=\$GPHOME/bin:\$GPHOME/ext/python/bin:\$PATH
-DYLD_LIBRARY_PATH=\$GPHOME/lib:\$GPHOME/ext/python/lib:\$DYLD_LIBRARY_PATH
+ cat << EOF
--- End diff --
remove spaces, it's confusing because the other lines in the if block don't have them.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: Fix 'hawq' issue for OSX after Python...
Posted by hornn <gi...@git.apache.org>.
Github user hornn commented on the pull request:
https://github.com/apache/incubator-hawq/pull/269#issuecomment-171827068
Looks ok, but it's not working on my MAC. Let me know if you want me to push it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---