[GitHub] [dubbo-go-hessian2] willson-chen commented on a change in pull request #212: Feature java8 time

[GitBox <gi...@apache.org>]

willson-chen commented on a change in pull request #212:
URL: https://github.com/apache/dubbo-go-hessian2/pull/212#discussion_r461641558



##########
File path: test_hessian/src/main/java/test/TestJava8Time.java
##########
@@ -0,0 +1,73 @@
+package test;

Review comment:
       Agree

##########
File path: java8_time/year.go
##########
@@ -0,0 +1,29 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package java8_time
+
+type Year struct {
+	Year int32 `hessian:"year"`
+}
+
+func (Year) JavaClassName() string {
+	return "com.alibaba.com.caucho.hessian.io.java8.YearHandle"

Review comment:
       Hi @wongoo, sorry, we can not fully understand these questions.
   
   > 1. is it only support the https://github.com/apache/dubbo-hessian-lite?
   
   Yes, we implemented these code by following the dubbo-hessian-lite.
   
   > 2. is there some dubbo users use some other hessian libraries? Yes, as I know.
   
   Could you please offer the libraries names?
   
   > 3. should we support class name java.time.Year at the same time?
   
   When shall we use `java.time.Year` instead of `com.alibaba.com.caucho.hessian.io.java8.YearHandle`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org