You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2020/07/22 13:34:49 UTC
[GitHub] [maven-filtering] elharo opened a new pull request #14: declare dependencies
elharo opened a new pull request #14:
URL: https://github.com/apache/maven-filtering/pull/14
@dennisl
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-filtering] dennisl commented on pull request #14: declare dependencies
Posted by GitBox <gi...@apache.org>.
dennisl commented on pull request #14:
URL: https://github.com/apache/maven-filtering/pull/14#issuecomment-766864034
I agree with @elharo
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-filtering] elharo merged pull request #14: declare dependencies
Posted by GitBox <gi...@apache.org>.
elharo merged pull request #14:
URL: https://github.com/apache/maven-filtering/pull/14
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-filtering] slachiewicz commented on pull request #14: declare dependencies
Posted by GitBox <gi...@apache.org>.
slachiewicz commented on pull request #14:
URL: https://github.com/apache/maven-filtering/pull/14#issuecomment-766872291
With each minimum Maven upgrade, someone needs to review all deps and update the version of aether to match with that will be delivered by Maven installation. No older, no newer.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-filtering] dennisl commented on pull request #14: declare dependencies
Posted by GitBox <gi...@apache.org>.
dennisl commented on pull request #14:
URL: https://github.com/apache/maven-filtering/pull/14#issuecomment-766864034
I agree with @elharo
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-filtering] slachiewicz commented on pull request #14: declare dependencies
Posted by GitBox <gi...@apache.org>.
slachiewicz commented on pull request #14:
URL: https://github.com/apache/maven-filtering/pull/14#issuecomment-766874181
real case: https://github.com/GoogleCloudPlatform/cloud-opensource-java/issues/1091
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-filtering] elharo commented on pull request #14: declare dependencies
Posted by GitBox <gi...@apache.org>.
elharo commented on pull request #14:
URL: https://github.com/apache/maven-filtering/pull/14#issuecomment-766457052
If one specifically imports classes from these dependencies, then they should be declared. Relaying on transitive dependencies is brittle. 5 months later I don't recall exactly which classes are imported from where but mvn dependency:analyze will find anything that's not needed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-filtering] slachiewicz commented on pull request #14: declare dependencies
Posted by GitBox <gi...@apache.org>.
slachiewicz commented on pull request #14:
URL: https://github.com/apache/maven-filtering/pull/14#issuecomment-766429749
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-filtering] slachiewicz commented on pull request #14: declare dependencies
Posted by GitBox <gi...@apache.org>.
slachiewicz commented on pull request #14:
URL: https://github.com/apache/maven-filtering/pull/14#issuecomment-766429749
Any reason why we need to declare these dependencies? org.eclipse.sisu.plexus is a transitive dependency from maven plugin API
and with each update to minimum maven.version property someone needs to adjust also this one instead of giving Maven chance to do its job.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-filtering] slachiewicz commented on pull request #14: declare dependencies
Posted by GitBox <gi...@apache.org>.
slachiewicz commented on pull request #14:
URL: https://github.com/apache/maven-filtering/pull/14#issuecomment-766868911
thx @dennisl - would you be able to sync the maven version to 3.1.1 as try to confirm that this proposed approach works?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-filtering] elharo commented on pull request #14: declare dependencies
Posted by GitBox <gi...@apache.org>.
elharo commented on pull request #14:
URL: https://github.com/apache/maven-filtering/pull/14#issuecomment-766457052
If one specifically imports classes from these dependencies, then they should be declared. Relaying on transitive dependencies is brittle. 5 months later I don't recall exactly which classes are imported from where but mvn dependency:analyze will find anything that's not needed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-filtering] slachiewicz commented on pull request #14: declare dependencies
Posted by GitBox <gi...@apache.org>.
slachiewicz commented on pull request #14:
URL: https://github.com/apache/maven-filtering/pull/14#issuecomment-766870955
```
[INFO] --- maven-dependency-plugin:3.1.1:analyze (default-cli) @ maven-filtering ---
[WARNING] Used undeclared dependencies found:
[WARNING] org.hamcrest:hamcrest:jar:2.2:test
[WARNING] org.eclipse.aether:aether-api:jar:0.9.0.M2:compile
[WARNING] Unused declared dependencies found:
[WARNING] org.hamcrest:hamcrest-core:jar:2.2:test
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org