You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Mark Miller (JIRA)" <ji...@apache.org> on 2009/08/21 17:20:14 UTC
[jira] Created: (LUCENE-1838) BoostingNearQuery must implement
clone - now it clones to a NearSpanQuery - cloning is required for Span
container classes
BoostingNearQuery must implement clone - now it clones to a NearSpanQuery - cloning is required for Span container classes
--------------------------------------------------------------------------------------------------------------------------
Key: LUCENE-1838
URL: https://issues.apache.org/jira/browse/LUCENE-1838
Project: Lucene - Java
Issue Type: Bug
Reporter: Mark Miller
Assignee: Mark Miller
Fix For: 2.9
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1838) BoostingNearQuery must implement
clone - now it clones to a NearSpanQuery - cloning is required for Span
container classes
Posted by "Michael Busch (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12746064#action_12746064 ]
Michael Busch commented on LUCENE-1838:
---------------------------------------
I just updated to current trunk and TestBoostingNearQuery is failing for me now:
{noformat}
junit.framework.AssertionFailedError: expected:<spanNear([field:twenty, field:two], 0, true)> but was:<spanNear([field:twenty, field:two], 0, true)>
at junit.framework.Assert.fail(Assert.java:47)
at junit.framework.Assert.failNotEquals(Assert.java:280)
at junit.framework.Assert.assertEquals(Assert.java:64)
at junit.framework.Assert.assertEquals(Assert.java:71)
at org.apache.lucene.search.QueryUtils.checkEqual(QueryUtils.java:68)
at org.apache.lucene.search.QueryUtils.checkHashEquals(QueryUtils.java:50)
at org.apache.lucene.search.QueryUtils.check(QueryUtils.java:44)
at org.apache.lucene.search.payloads.TestBoostingNearQuery.test(TestBoostingNearQuery.java:124)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:585)
at junit.framework.TestCase.runTest(TestCase.java:164)
at org.apache.lucene.util.LuceneTestCase.runTest(LuceneTestCase.java:201)
at junit.framework.TestCase.runBare(TestCase.java:130)
at junit.framework.TestResult$1.protect(TestResult.java:106)
at junit.framework.TestResult.runProtected(TestResult.java:124)
at junit.framework.TestResult.run(TestResult.java:109)
at junit.framework.TestCase.run(TestCase.java:120)
at junit.framework.TestSuite.runTest(TestSuite.java:230)
at junit.framework.TestSuite.run(TestSuite.java:225)
at org.eclipse.jdt.internal.junit.runner.junit3.JUnit3TestReference.run(JUnit3TestReference.java:130)
at org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:460)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:673)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:386)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:196)
{noformat}
> BoostingNearQuery must implement clone - now it clones to a NearSpanQuery - cloning is required for Span container classes
> --------------------------------------------------------------------------------------------------------------------------
>
> Key: LUCENE-1838
> URL: https://issues.apache.org/jira/browse/LUCENE-1838
> Project: Lucene - Java
> Issue Type: Bug
> Reporter: Mark Miller
> Assignee: Mark Miller
> Fix For: 2.9
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-1838) BoostingNearQuery must implement
clone - now it clones to a NearSpanQuery - cloning is required for Span
container classes
Posted by "Mark Miller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mark Miller updated LUCENE-1838:
--------------------------------
Attachment: LUCENE-1838.patch
> BoostingNearQuery must implement clone - now it clones to a NearSpanQuery - cloning is required for Span container classes
> --------------------------------------------------------------------------------------------------------------------------
>
> Key: LUCENE-1838
> URL: https://issues.apache.org/jira/browse/LUCENE-1838
> Project: Lucene - Java
> Issue Type: Bug
> Reporter: Mark Miller
> Assignee: Mark Miller
> Fix For: 2.9
>
> Attachments: LUCENE-1838.patch, LUCENE-1838.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Resolved: (LUCENE-1838) BoostingNearQuery must implement
clone - now it clones to a NearSpanQuery - cloning is required for Span
container classes
Posted by "Mark Miller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mark Miller resolved LUCENE-1838.
---------------------------------
Resolution: Fixed
r806885
> BoostingNearQuery must implement clone - now it clones to a NearSpanQuery - cloning is required for Span container classes
> --------------------------------------------------------------------------------------------------------------------------
>
> Key: LUCENE-1838
> URL: https://issues.apache.org/jira/browse/LUCENE-1838
> Project: Lucene - Java
> Issue Type: Bug
> Reporter: Mark Miller
> Assignee: Mark Miller
> Fix For: 2.9
>
> Attachments: LUCENE-1838.patch, LUCENE-1838.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1838) BoostingNearQuery must implement
clone - now it clones to a NearSpanQuery - cloning is required for Span
container classes
Posted by "Mark Miller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12746082#action_12746082 ]
Mark Miller commented on LUCENE-1838:
-------------------------------------
hmmm - tests passed here so I must have screwed something up ... I'll fix it.
> BoostingNearQuery must implement clone - now it clones to a NearSpanQuery - cloning is required for Span container classes
> --------------------------------------------------------------------------------------------------------------------------
>
> Key: LUCENE-1838
> URL: https://issues.apache.org/jira/browse/LUCENE-1838
> Project: Lucene - Java
> Issue Type: Bug
> Reporter: Mark Miller
> Assignee: Mark Miller
> Fix For: 2.9
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1838) BoostingNearQuery must implement
clone - now it clones to a NearSpanQuery - cloning is required for Span
container classes
Posted by "Mark Miller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12746012#action_12746012 ]
Mark Miller commented on LUCENE-1838:
-------------------------------------
Technically, SpanQuery should have an abstract clone so that SpanQuerys are required to implement cloneable.
> BoostingNearQuery must implement clone - now it clones to a NearSpanQuery - cloning is required for Span container classes
> --------------------------------------------------------------------------------------------------------------------------
>
> Key: LUCENE-1838
> URL: https://issues.apache.org/jira/browse/LUCENE-1838
> Project: Lucene - Java
> Issue Type: Bug
> Reporter: Mark Miller
> Assignee: Mark Miller
> Fix For: 2.9
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1838) BoostingNearQuery must implement
clone - now it clones to a NearSpanQuery - cloning is required for Span
container classes
Posted by "Mark Miller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12746029#action_12746029 ]
Mark Miller commented on LUCENE-1838:
-------------------------------------
I'm also going to add an optional (default to true) q1.class == q1.class test to the QueryUtils hashCode/equals/clone check.
> BoostingNearQuery must implement clone - now it clones to a NearSpanQuery - cloning is required for Span container classes
> --------------------------------------------------------------------------------------------------------------------------
>
> Key: LUCENE-1838
> URL: https://issues.apache.org/jira/browse/LUCENE-1838
> Project: Lucene - Java
> Issue Type: Bug
> Reporter: Mark Miller
> Assignee: Mark Miller
> Fix For: 2.9
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Issue Comment Edited: (LUCENE-1838) BoostingNearQuery must
implement clone - now it clones to a NearSpanQuery - cloning is required
for Span container classes
Posted by "Mark Miller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12746029#action_12746029 ]
Mark Miller edited comment on LUCENE-1838 at 8/21/09 8:55 AM:
--------------------------------------------------------------
I'm also going to add an optional (default to true) q1.class == q2.class test to the QueryUtils hashCode/equals/clone check.
was (Author: markrmiller@gmail.com):
I'm also going to add an optional (default to true) q1.class == q1.class test to the QueryUtils hashCode/equals/clone check.
> BoostingNearQuery must implement clone - now it clones to a NearSpanQuery - cloning is required for Span container classes
> --------------------------------------------------------------------------------------------------------------------------
>
> Key: LUCENE-1838
> URL: https://issues.apache.org/jira/browse/LUCENE-1838
> Project: Lucene - Java
> Issue Type: Bug
> Reporter: Mark Miller
> Assignee: Mark Miller
> Fix For: 2.9
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1838) BoostingNearQuery must implement
clone - now it clones to a NearSpanQuery - cloning is required for Span
container classes
Posted by "Mark Miller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12746057#action_12746057 ]
Mark Miller commented on LUCENE-1838:
-------------------------------------
It looks like its very easy to get into trouble with Querys and cloning. BooleanQuery, DisjunctionQuery have quite a reliance on it - as do the SpanQueries (all in rewrite). Improperly cloning can sometimes have extra special effects with MultiSearcher : LUCENE-1599
> BoostingNearQuery must implement clone - now it clones to a NearSpanQuery - cloning is required for Span container classes
> --------------------------------------------------------------------------------------------------------------------------
>
> Key: LUCENE-1838
> URL: https://issues.apache.org/jira/browse/LUCENE-1838
> Project: Lucene - Java
> Issue Type: Bug
> Reporter: Mark Miller
> Assignee: Mark Miller
> Fix For: 2.9
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org