You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/09/16 11:45:45 UTC
[GitHub] [camel-quarkus] zhfeng opened a new pull request #3107: [WIP] Fix #2590 to test together with quarkus-amazon-s3
zhfeng opened a new pull request #3107:
URL: https://github.com/apache/camel-quarkus/pull/3107
1. it needs to add ```quarkus.s3.sync-client.type=apache``` in application.properties because we are using ```software.amazon.awssdk:apache-client```. And the ```software.amazon.awssdk:url-connection-client``` is the default one in Quarkus.
2. it needs to inject ```S3Client``` instance explicitly in test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger commented on pull request #3107: [WIP] Fix #2590 to test together with quarkus-amazon-s3
Posted by GitBox <gi...@apache.org>.
aldettinger commented on pull request #3107:
URL: https://github.com/apache/camel-quarkus/pull/3107#issuecomment-921896022
@zhfeng I see the point, 2 tests might not be needed. I think the bottom line is to test an application using both quarkus-amazon-s3 and camel-quarkus-aws2-s3. A single itest project showing both configurations working ala infinispan might be ok.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger commented on pull request #3107: [WIP] Fix #2590 to test together with quarkus-amazon-s3
Posted by GitBox <gi...@apache.org>.
aldettinger commented on pull request #3107:
URL: https://github.com/apache/camel-quarkus/pull/3107#issuecomment-929364703
I think there is good ideas from #3133 that this PR could align on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger commented on pull request #3107: [WIP] Fix #2590 to test together with quarkus-amazon-s3
Posted by GitBox <gi...@apache.org>.
aldettinger commented on pull request #3107:
URL: https://github.com/apache/camel-quarkus/pull/3107#issuecomment-923771612
@jamesnetherton @ppalaga Does the autowiring approach make sense if documented like in this PR ?
If yes, then I would aligned with the documentation proposed in https://github.com/apache/camel-quarkus/pull/3116
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger commented on pull request #3107: [WIP] Fix #2590 to test together with quarkus-amazon-s3
Posted by GitBox <gi...@apache.org>.
aldettinger commented on pull request #3107:
URL: https://github.com/apache/camel-quarkus/pull/3107#issuecomment-921579360
> If it is just for testing the dependency should be with scope test
Yes, and maybe the dependency should be on itests only, not extension.
And Maybe there is need to have 2 dedicated itest projects ? like:
1. The existing one testing only camel-quarkus-aws2-s3
2. Another one testing camel-quarkus-aws2-s3 used in the same project with quarkus-amazon-s3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on pull request #3107: [WIP] Fix #2590 to test together with quarkus-amazon-s3
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on pull request #3107:
URL: https://github.com/apache/camel-quarkus/pull/3107#issuecomment-930823855
Superseeded by #3135.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger commented on pull request #3107: [WIP] Fix #2590 to test together with quarkus-amazon-s3
Posted by GitBox <gi...@apache.org>.
aldettinger commented on pull request #3107:
URL: https://github.com/apache/camel-quarkus/pull/3107#issuecomment-929364703
I think there is good ideas from #3133 that this PR could align on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on pull request #3107: [WIP] Fix #2590 to test together with quarkus-amazon-s3
Posted by GitBox <gi...@apache.org>.
ppalaga commented on pull request #3107:
URL: https://github.com/apache/camel-quarkus/pull/3107#issuecomment-924716872
I looked at #3116 and I expressed my thoughts there https://github.com/apache/camel-quarkus/pull/3116#pullrequestreview-760579842
So far our extension does not depend on the Quarkus one, I think we need two test apps: one depending only on our extension and one depending on both ours and Quarkus extensions. The second one can perhaps be a light weight test leveraging `@org.junit.jupiter.api.extension.RegisterExtension`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on pull request #3107: [WIP] Fix #2590 to test together with quarkus-amazon-s3
Posted by GitBox <gi...@apache.org>.
ppalaga commented on pull request #3107:
URL: https://github.com/apache/camel-quarkus/pull/3107#issuecomment-921240625
> To me the extension should not depend on quarkus Amazon S3. We constantly have trouble with quarkus extension on Camel-k. So where it is possible we should avoid using pure quarkus extensions
Yep, -1 for now. We are discussing with Quarkus team how their extensions could change to allow us to configure the clients via Camel configuration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zhfeng commented on pull request #3107: [WIP] Fix #2590 to test together with quarkus-amazon-s3
Posted by GitBox <gi...@apache.org>.
zhfeng commented on pull request #3107:
URL: https://github.com/apache/camel-quarkus/pull/3107#issuecomment-921376098
Thanks all for reviewing and this PR is just for a test purpose to see if the quarkus amazon S3 client is working with the camel. And @ppalaga is there any Quarkus issue for discussing this problem ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] oscerd commented on pull request #3107: [WIP] Fix #2590 to test together with quarkus-amazon-s3
Posted by GitBox <gi...@apache.org>.
oscerd commented on pull request #3107:
URL: https://github.com/apache/camel-quarkus/pull/3107#issuecomment-921457230
If it is just for testing the dependency should be with scope test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zhfeng commented on pull request #3107: [WIP] Fix #2590 to test together with quarkus-amazon-s3
Posted by GitBox <gi...@apache.org>.
zhfeng commented on pull request #3107:
URL: https://github.com/apache/camel-quarkus/pull/3107#issuecomment-929733936
OK, I will create a new PR to relpace this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zhfeng commented on pull request #3107: [WIP] Fix #2590 to test together with quarkus-amazon-s3
Posted by GitBox <gi...@apache.org>.
zhfeng commented on pull request #3107:
URL: https://github.com/apache/camel-quarkus/pull/3107#issuecomment-921728742
@aldettinger Is it similar with the camel infinspan itest ?
https://github.com/apache/camel-quarkus/blob/b856df58078471e027c7d8e7dbc586ba8d37b87f/integration-tests/infinispan/src/test/java/org/apache/camel/quarkus/component/infinispan/InfinispanServerTestResource.java#L58-L74
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger commented on pull request #3107: [WIP] Fix #2590 to test together with quarkus-amazon-s3
Posted by GitBox <gi...@apache.org>.
aldettinger commented on pull request #3107:
URL: https://github.com/apache/camel-quarkus/pull/3107#issuecomment-921111885
So, more than testing that camel-quarkus-aws2-s3 could be used next to quarkus-amazon-s3, this PR is making camel-quarkus-aws2-s3 depends upon quarkus-amazon-s3 ?
In this way, will camel-quarkus-aws2-s3 users need to manually inject a S3Client and define relevant properties on their own ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger edited a comment on pull request #3107: [WIP] Fix #2590 to test together with quarkus-amazon-s3
Posted by GitBox <gi...@apache.org>.
aldettinger edited a comment on pull request #3107:
URL: https://github.com/apache/camel-quarkus/pull/3107#issuecomment-923771612
@jamesnetherton @ppalaga Does the autowiring approach make sense if the documentation is aligned with PR https://github.com/apache/camel-quarkus/pull/3116 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton closed pull request #3107: [WIP] Fix #2590 to test together with quarkus-amazon-s3
Posted by GitBox <gi...@apache.org>.
jamesnetherton closed pull request #3107:
URL: https://github.com/apache/camel-quarkus/pull/3107
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zhfeng commented on pull request #3107: [WIP] Fix #2590 to test together with quarkus-amazon-s3
Posted by GitBox <gi...@apache.org>.
zhfeng commented on pull request #3107:
URL: https://github.com/apache/camel-quarkus/pull/3107#issuecomment-929733936
OK, I will create a new PR to relpace this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org