[jira] [Commented] (OPENNLP-1036) Use Object values in TrainingParameters instead of String

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OPENNLP-1036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15976218#comment-15976218 ] 

ASF GitHub Bot commented on OPENNLP-1036:
-----------------------------------------

GitHub user kojisekig opened a pull request:

    https://github.com/apache/opennlp/pull/176

    OPENNLP-1036: Use Object values in TrainingParameters instead of String

    Thank you for contributing to Apache OpenNLP.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [ ] Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [ ] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [ ] Have you ensured that the full suite of tests is executed via mvn clean install at the root opennlp folder?
    - [ ] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file in opennlp folder?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found in opennlp folder?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kojisekig/opennlp use-obj-values_TrainingParameters

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/opennlp/pull/176.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #176
    
----
commit 905aa9878ce09883fe4d56c21032ac6dadf7cdcc
Author: koji <ko...@apache.org>
Date:   2017-04-20T07:14:30Z

    OPENNLP-1036: Use Object values in TrainingParameters instead of String

----


> Use Object values in TrainingParameters instead of String
> ---------------------------------------------------------
>
>                 Key: OPENNLP-1036
>                 URL: https://issues.apache.org/jira/browse/OPENNLP-1036
>             Project: OpenNLP
>          Issue Type: Improvement
>          Components: Chunker, Doccat, Lemmatizer, Name Finder, POS Tagger, Sentence Detector, Tokenizer
>            Reporter: Koji Sekiguchi
>            Priority: Minor
>
> When I worked on OPENNLP-1032, I realized that TrainingParameters manages parameters as Map<String,String>. So, users have to set their int parameters like this:
> {code}
> trainParam.put("name", "100");
> {code}
> but it should look like this:
> {code}
> trainParam.put("name", 100);
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)