You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by Kenny Smith <ja...@journalscape.com> on 2003/01/27 03:32:23 UTC
[PATCH] imap2 proposal - refactored to current structure
Hi all,
I hope I've done this right, please let me know if I didn't so I can do it
properly next time.
I've updated each of the files in the proposals/imap2/java directory that
references classes that have been moved and I updated the proposal
James.java to the current James.java, but re-added the imap specific bits.
Attached is a zip file created from inside the jakarta-james directory and
it contains .diff files which contain "diff -u" output. They are located in
the same places as each of the java files they correspond to.
I haven't been able to test if these work because I don't know how to
configure config.xml to use the imap proposal (I'll be sending a seperate
message about this). They definate compile though and at the very least
that's an improvement over what is in CVS. :)
Kenny Smith
JournalScape.com
RE: [PATCH] imap2 proposal - refactored to current structure
Posted by Kenny Smith <ke...@journalscape.com>.
> I've applied your patches - thanks heaps! Saved me chasing down
> all of those changes in main tree.
Yay! :)
> For future reference, could you please create patches using:
> cvs diff -u run from the root of the cvs tree, with no filename
> specified. This creates a single diff file which is easier for
> me to apply. If you've only made changes to the proposal, or
> only want to send a patch for that directory, you could run the
> above command from within the proposals directory.
oohhhh... that sounds a _lot_ easier than what I did. :) Will do!
> I noticed that the source files in the "test" directory haven't
> been patched, and won't compile. Maybe you want to fix those
> while you're at it? Use the ant build file "build-test.xml" and
> the "compile" target to test it out. Once that's done, you
> should be able to run all of the unit tests, using the
> "unit-tests" target.
You bet. I've finished all my other projects currently so my lunch time at
work this week will go toward that. :)
Kenny Smith
JournalScape.com
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [PATCH] imap2 proposal - refactored to current structure
Posted by Darrell DeBoer <da...@apache.org>.
Hi Kenny.
I've applied your patches - thanks heaps! Saved me chasing down all of those
changes in main tree.
For future reference, could you please create patches using:
cvs diff -u
run from the root of the cvs tree, with no filename specified. This creates a
single diff file which is easier for me to apply. If you've only made changes
to the proposal, or only want to send a patch for that directory, you could
run the above command from within the proposals directory.
I noticed that the source files in the "test" directory haven't been patched,
and won't compile. Maybe you want to fix those while you're at it? Use the
ant build file "build-test.xml" and the "compile" target to test it out. Once
that's done, you should be able to run all of the unit tests, using the
"unit-tests" target.
Thanks again.
--
ciao,
Daz
On Mon, 27 Jan 2003 12:32, Kenny Smith wrote:
> Hi all,
>
> I hope I've done this right, please let me know if I didn't so I can do it
> properly next time.
>
> I've updated each of the files in the proposals/imap2/java directory that
> references classes that have been moved and I updated the proposal
> James.java to the current James.java, but re-added the imap specific bits.
>
> Attached is a zip file created from inside the jakarta-james directory and
> it contains .diff files which contain "diff -u" output. They are located in
> the same places as each of the java files they correspond to.
>
> I haven't been able to test if these work because I don't know how to
> configure config.xml to use the imap proposal (I'll be sending a seperate
> message about this). They definate compile though and at the very least
> that's an improvement over what is in CVS. :)
>
> Kenny Smith
> JournalScape.com
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
RE: [PATCH] imap2 proposal - refactored to current structure
Posted by "Noel J. Bergman" <no...@devtech.com>.
> No one, afaik, is waiting for the code, but I figured it would be good to
> bring the proposal in CVS up to date with the main source tree.
No worries. Darrell knows the imap2 code well, and already took care of the
merger. :-) He even finished some of the other things that I figured you'd
encounter before the updates were really completed, and updated the wiki a
bit.
Thanks Darrell! :-)
--- Noel
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
RE: [PATCH] imap2 proposal - refactored to current structure
Posted by Kenny Smith <ke...@journalscape.com>.
Hi Noel,
> Is it OK with you if we put off this merger until you finish up,
> and get it running? Is anyone waiting for this code?
No one, afaik, is waiting for the code, but I figured it would be good to
bring the proposal in CVS up to date with the main source tree. I had a
couple of different reasons, but probably the most important one to me is
the ability to revert. If I start working on the source tree and realize
that I've just totally screwed it up, then I can ditch my code and check out
of CVS again.
> > I haven't been able to test if these work because I don't know how to
> > configure config.xml to use the imap proposal
>
> Look at proposals/imap2/conf/* for the configuration files.
> You'll want to, again, update them by taking the current files from HEAD
> and updating the IMAP bits. Then you should be able to run some basic
> tests, tweak any other bits that need tweaking, and we can merge this back
> into the CVS.
Ah, excellent. Sorry I missed that. Will do!
> And would you please take a moment to update the IMAP2 build
> instructions at
> http://nagoya.apache.org/wiki/apachewiki.cgi?JamesIMAP when you
> can, please?
> :-)
I can, but I don't know what instructions need to be updated. I used the
instructions posted there to do my builds and apart from the minor
refactoring it worked just fine. :)
Kenny Smith
JournalScape.com
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
RE: [PATCH] imap2 proposal - refactored to current structure
Posted by "Noel J. Bergman" <no...@devtech.com>.
Kenny,
Is it OK with you if we put off this merger until you finish up, and get it
running? Is anyone waiting for this code?
> I haven't been able to test if these work because I don't know how to
> configure config.xml to use the imap proposal
Look at proposals/imap2/conf/* for the configuration files. You'll want to,
again, update them by taking the current files from HEAD and updating the
IMAP bits. Then you should be able to run some basic tests, tweak any other
bits that need tweaking, and we can merge this back into the CVS.
And would you please take a moment to update the IMAP2 build instructions at
http://nagoya.apache.org/wiki/apachewiki.cgi?JamesIMAP when you can, please?
:-)
Work for you?
--- Noel
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>