You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@phoenix.apache.org by vi...@apache.org on 2019/09/17 00:10:00 UTC
svn commit: r1867033 - in /phoenix/site: publish/contributing.html
publish/language/datatypes.html publish/language/functions.html
publish/language/index.html source/src/site/markdown/contributing.md
Author: vincentpoon
Date: Tue Sep 17 00:10:00 2019
New Revision: 1867033
URL: http://svn.apache.org/viewvc?rev=1867033&view=rev
Log:
PHOENIX-5430 Update Generate a patch session on contributing page (Christine Feng)
Modified:
phoenix/site/publish/contributing.html
phoenix/site/publish/language/datatypes.html
phoenix/site/publish/language/functions.html
phoenix/site/publish/language/index.html
phoenix/site/source/src/site/markdown/contributing.md
Modified: phoenix/site/publish/contributing.html
URL: http://svn.apache.org/viewvc/phoenix/site/publish/contributing.html?rev=1867033&r1=1867032&r2=1867033&view=diff
==============================================================================
--- phoenix/site/publish/contributing.html (original)
+++ phoenix/site/publish/contributing.html Tue Sep 17 00:10:00 2019
@@ -1,7 +1,7 @@
<!DOCTYPE html>
<!--
- Generated by Apache Maven Doxia at 2019-07-10
+ Generated by Apache Maven Doxia at 2019-09-16
Rendered using Reflow Maven Skin 1.1.0 (http://andriusvelykis.github.io/reflow-maven-skin)
-->
<html xml:lang="en" lang="en">
@@ -193,7 +193,7 @@
</div>
<div class="section">
<h3 id="Generate_a_patch">Generate a patch</h3>
- <p>There are two general approaches that can be used for creating and submitting a patch: GitHub pull requests, or manually creating a patch with Git. Both of these are explained below. Please make sure that the patch applies cleanly on all the active branches including master: 5.x-HBase-2.0, 4.x-HBase-1.4, 4.x-HBase-1.3, and 4.x-HBase-1.2</p>
+ <p>There are two general approaches that can be used for creating and submitting a patch: GitHub pull requests, or manually creating a patch with Git. Both of these are explained below. Please make sure that the patch applies cleanly on all the active branches including master: 5.x-HBase-2.0, 4.x-HBase-1.5, 4.x-HBase-1.4, and 4.x-HBase-1.3.</p>
<p>Regardless of which approach is taken, please make sure to follow the Phoenix code conventions (more information below). Whenever possible, unit tests or integration tests should be included with patches.</p>
<p>Please make sure that the patch contains only one commit and click on the âSubmit patchâ button to automatically trigger the tests on the patch.</p>
<p>The commit message should reference the jira ticket issue (which has the format <tt>PHOENIX-{NUMBER}:{JIRA-TITLE}</tt>).</p>
Modified: phoenix/site/publish/language/datatypes.html
URL: http://svn.apache.org/viewvc/phoenix/site/publish/language/datatypes.html?rev=1867033&r1=1867032&r2=1867033&view=diff
==============================================================================
--- phoenix/site/publish/language/datatypes.html (original)
+++ phoenix/site/publish/language/datatypes.html Tue Sep 17 00:10:00 2019
@@ -1,7 +1,7 @@
<!DOCTYPE html>
<!--
- Generated by Apache Maven Doxia at 2019-08-26
+ Generated by Apache Maven Doxia at 2019-09-16
Rendered using Reflow Maven Skin 1.1.0 (http://andriusvelykis.github.io/reflow-maven-skin)
-->
<html xml:lang="en" lang="en">
Modified: phoenix/site/publish/language/functions.html
URL: http://svn.apache.org/viewvc/phoenix/site/publish/language/functions.html?rev=1867033&r1=1867032&r2=1867033&view=diff
==============================================================================
--- phoenix/site/publish/language/functions.html (original)
+++ phoenix/site/publish/language/functions.html Tue Sep 17 00:10:00 2019
@@ -1,7 +1,7 @@
<!DOCTYPE html>
<!--
- Generated by Apache Maven Doxia at 2019-08-26
+ Generated by Apache Maven Doxia at 2019-09-16
Rendered using Reflow Maven Skin 1.1.0 (http://andriusvelykis.github.io/reflow-maven-skin)
-->
<html xml:lang="en" lang="en">
Modified: phoenix/site/publish/language/index.html
URL: http://svn.apache.org/viewvc/phoenix/site/publish/language/index.html?rev=1867033&r1=1867032&r2=1867033&view=diff
==============================================================================
--- phoenix/site/publish/language/index.html (original)
+++ phoenix/site/publish/language/index.html Tue Sep 17 00:10:00 2019
@@ -1,7 +1,7 @@
<!DOCTYPE html>
<!--
- Generated by Apache Maven Doxia at 2019-08-26
+ Generated by Apache Maven Doxia at 2019-09-16
Rendered using Reflow Maven Skin 1.1.0 (http://andriusvelykis.github.io/reflow-maven-skin)
-->
<html xml:lang="en" lang="en">
Modified: phoenix/site/source/src/site/markdown/contributing.md
URL: http://svn.apache.org/viewvc/phoenix/site/source/src/site/markdown/contributing.md?rev=1867033&r1=1867032&r2=1867033&view=diff
==============================================================================
--- phoenix/site/source/src/site/markdown/contributing.md (original)
+++ phoenix/site/source/src/site/markdown/contributing.md Tue Sep 17 00:10:00 2019
@@ -30,7 +30,7 @@ To setup your development, see [these](d
### Generate a patch
-There are two general approaches that can be used for creating and submitting a patch: GitHub pull requests, or manually creating a patch with Git. Both of these are explained below. Please make sure that the patch applies cleanly on all the active branches including master: 5.x-HBase-2.0, 4.x-HBase-1.4, 4.x-HBase-1.3, and 4.x-HBase-1.2
+There are two general approaches that can be used for creating and submitting a patch: GitHub pull requests, or manually creating a patch with Git. Both of these are explained below. Please make sure that the patch applies cleanly on all the active branches including master: 5.x-HBase-2.0, 4.x-HBase-1.5, 4.x-HBase-1.4, and 4.x-HBase-1.3.
Regardless of which approach is taken, please make sure to follow the Phoenix code conventions (more information below). Whenever possible, unit tests or integration tests should be included with patches.