You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/08/10 13:07:12 UTC
[GitHub] [hudi] nsivabalan opened a new pull request #3441: [DO-NOT-MERGE] Flipping some of the default values(1)
nsivabalan opened a new pull request #3441:
URL: https://github.com/apache/hudi/pull/3441
## *Tips*
- *Thank you very much for contributing to Apache Hudi.*
- *Please review https://hudi.apache.org/contributing.html before opening a pull request.*
## What is the purpose of the pull request
*(For example: This pull request adds quick-start document.)*
## Brief change log
*(for example:)*
- *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added HoodieClientWriteTest to verify the change.*
- *Manually verified the change by running a job locally.*
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xuzifu666 commented on a change in pull request #3441: [DO-NOT-MERGE] Flipping some of the default values(1)
Posted by GitBox <gi...@apache.org>.
xuzifu666 commented on a change in pull request #3441:
URL: https://github.com/apache/hudi/pull/3441#discussion_r686127507
##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieIndexConfig.java
##########
@@ -121,8 +121,8 @@
public static final ConfigProperty<String> BLOOM_INDEX_FILTER_TYPE = ConfigProperty
.key("hoodie.bloom.index.filter.type")
- .defaultValue(BloomFilterTypeCode.SIMPLE.name())
- .withDocumentation("Filter type used. Default is BloomFilterTypeCode.SIMPLE. "
+ .defaultValue(BloomFilterTypeCode.DYNAMIC_V0.name())
Review comment:
plz
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xuzifu666 commented on a change in pull request #3441: [DO-NOT-MERGE] Flipping some of the default values(1)
Posted by GitBox <gi...@apache.org>.
xuzifu666 commented on a change in pull request #3441:
URL: https://github.com/apache/hudi/pull/3441#discussion_r686127635
##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieIndexConfig.java
##########
@@ -121,8 +121,8 @@
public static final ConfigProperty<String> BLOOM_INDEX_FILTER_TYPE = ConfigProperty
.key("hoodie.bloom.index.filter.type")
- .defaultValue(BloomFilterTypeCode.SIMPLE.name())
- .withDocumentation("Filter type used. Default is BloomFilterTypeCode.SIMPLE. "
+ .defaultValue(BloomFilterTypeCode.DYNAMIC_V0.name())
Review comment:
the config name should be
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan closed pull request #3441: [DO-NOT-MERGE] Flipping some of the default values(1)
Posted by GitBox <gi...@apache.org>.
nsivabalan closed pull request #3441:
URL: https://github.com/apache/hudi/pull/3441
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3441: [DO-NOT-MERGE] Flipping some of the default values(1)
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3441:
URL: https://github.com/apache/hudi/pull/3441#issuecomment-896014007
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e22256a6d51642eac680c656f6238c64cc0c3031",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1616",
"triggerID" : "e22256a6d51642eac680c656f6238c64cc0c3031",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e22256a6d51642eac680c656f6238c64cc0c3031 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1616)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #3441: [DO-NOT-MERGE] Flipping some of the default values(1)
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3441:
URL: https://github.com/apache/hudi/pull/3441#issuecomment-896014007
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e22256a6d51642eac680c656f6238c64cc0c3031",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e22256a6d51642eac680c656f6238c64cc0c3031",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e22256a6d51642eac680c656f6238c64cc0c3031 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3441: [DO-NOT-MERGE] Flipping some of the default values(1)
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3441:
URL: https://github.com/apache/hudi/pull/3441#issuecomment-896014007
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e22256a6d51642eac680c656f6238c64cc0c3031",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1616",
"triggerID" : "e22256a6d51642eac680c656f6238c64cc0c3031",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e22256a6d51642eac680c656f6238c64cc0c3031 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1616)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org