[jira] [Commented] (TS-2651) atscppapi: race conditions in destruction of async providers

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TS-2651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13975245#comment-13975245 ] 

ASF subversion and git services commented on TS-2651:
-----------------------------------------------------

Commit c5c92b9491f3172e5f600502df65b1a99a2e535e in trafficserver's branch refs/heads/lua_config from [~zwoop]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=c5c92b9 ]

Merge remote-tracking branch 'origin/master' into lua_config

* origin/master: (363 commits)
  TS-2564 Revert field token ordering.
  [TS-2664] atscppapi: Removing initializable value code
  [TS-2664] Removing initializable value code
  [TS-2664] Removing initializable value files
  TS-2660: rename StateMachineAction_t values with a consistent prefix
  [TS-2662] Re-enable KEEP_ALIVE_POST_OUT by default.
  [TS-2662] Re-enable KEEP_ALIVE_POST_OUT by default. This closes #66
  Fix harmless Ethread::schedule_in parameter mismatch
  TS-2661: Remove unused HttpSM::decide_cached_url method.
  Remaporder
  TS-2658: additional SSL certificate logging
  Cleanup the configure.ac in some sort of order... Minor.
  Update CHANGES with TS-2431
  TS-2431: Migrate Taobao SPDY plugin to ATS core
  TS-2431: Preparation of SPDY protocol
  TS-2431: Add autoconf options for SPDY
  [TS-2651] atscppapi: race conditions in destruction of async providers. This closes #64
  [TS-2651] atscppapi: race conditions in destruction of async providers
  [TS-2651] atscppapi: race conditions in destruction of async providers
  [TS-2651] atscppapi: race conditions in destruction of async providers
  ...

Conflicts:
	iocore/net/SSLUtils.cc
	proxy/Makefile.am


> atscppapi: race conditions in destruction of async providers
> ------------------------------------------------------------
>
>                 Key: TS-2651
>                 URL: https://issues.apache.org/jira/browse/TS-2651
>             Project: Traffic Server
>          Issue Type: Bug
>            Reporter: Manjesh Nilange
>            Assignee: Brian Geffon
>             Fix For: 5.0.0
>
>
> There are two corner cases that I can think of -
> 1) Developer delete()ing AsyncHttpFetch before fetch is complete. 
> In the .h documentation, we say that the fetch object will delete itself, so the implication is that developer need not delete it. However, we don't make sure that developer can't. Because if they do it (by mistake) before the fetch is complete, the fetch object's state is deleted, and then when the fetch actually completes, there will be chaos. 
> 2) Developer delete()ing AsyncTimer exactly at the time a timing event happens. 
> AsyncTimer requires the developer to delete the timer explicitly (with a periodic timer, we can't do self-destruction). If developer's delete happens at the same time as a event on the continuation, then we will have problems as the destructor tries to destroy the continuation that is being invoked in another thread. 



--
This message was sent by Atlassian JIRA
(v6.2#6252)