You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/10/07 19:19:49 UTC

[GitHub] [pulsar] DaveDuggins opened a new pull request, #17963: [Doc][Improve] Add images to /assets

DaveDuggins opened a new pull request, #17963:
URL: https://github.com/apache/pulsar/pull/17963

   
   This PR fixes issue #17960.
   
   ### Motivation
   
   Builds automatically failed because images used in concepts-messaging.md were not found.
   
   ### Modifications
   
   Add images to /assets for concepts-messaging.md
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [x] `doc` <!-- Your PR contains doc changes -->
   - [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
   - [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
   - [ ] `doc-complete` <!-- Docs have been already added -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Huanli-Meng commented on pull request #17963: [Doc][Improve] Add images to /assets

Posted by GitBox <gi...@apache.org>.
Huanli-Meng commented on PR #17963:
URL: https://github.com/apache/pulsar/pull/17963#issuecomment-1272307117

   @DaveDuggins do you want to reference these images in the Messaging doc? If yes, you need to update the related image links in the Messaging MD file. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] tisonkun commented on pull request #17963: [Doc][Improve] Add images to /assets

Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #17963:
URL: https://github.com/apache/pulsar/pull/17963#issuecomment-1274062329

   @DaveDuggins Since the SVG files is present, I'm going to take over this PR to fix the site build issue - this patch still have some name mismatches issue. I'll add you as the coauthor for the superseding patch. See also #17991.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] momo-jun closed pull request #17963: [Doc][Improve] Add images to /assets

Posted by GitBox <gi...@apache.org>.
momo-jun closed pull request #17963: [Doc][Improve] Add images to /assets
URL: https://github.com/apache/pulsar/pull/17963


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] momo-jun commented on pull request #17963: [Doc][Improve] Add images to /assets

Posted by GitBox <gi...@apache.org>.
momo-jun commented on PR #17963:
URL: https://github.com/apache/pulsar/pull/17963#issuecomment-1272694599

   @DaveDuggins I have the same comment with Tison. Can you pls respond and clarify the intention further before we can move it forward?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Anonymitaet commented on pull request #17963: [Doc][Improve] Add images to /assets

Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on PR #17963:
URL: https://github.com/apache/pulsar/pull/17963#issuecomment-1272713330

   @DaveDuggins before submitting images, make sure:
   - Test your changes locally, make sure all images are shown correctly, and attach the screenshots of local previews in the PR description
   - Verify all the images are used in docs 
   
   Thank you!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org