You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by "kumaab (via GitHub)" <gi...@apache.org> on 2026/06/27 01:18:39 UTC

[PR] ATLAS-5332: Update apache-atlas PyPI client to require Python 3.13+ [atlas]

kumaab opened a new pull request, #686:
URL: https://github.com/apache/atlas/pull/686

   ## What changes were proposed in this pull request?
   
   Require **Python 3.13+** for the `apache-atlas` PyPI client (v**0.0.16**). Adds unit tests, CI, and packaging fixes. Library code is already 3.13-compatible.
   
   **Breaking:** Python ≤ 3.12 users must stay on `0.0.15`.
   
   ## What changed
   
   - `python_requires='>=3.13'`, `requests>=2.34.2`, SPDX license metadata
   - `setup.py` reads deps from `requirements.txt`; add `MANIFEST.in` for reliable wheel builds
   - 11 unit tests + `mvn -pl intg test` hook + GitHub Actions workflow (Python 3.13)
   - README updates; RAT/gitignore excludes for `.tox/`, `.mypy_cache/`, etc.
   
   ## How was this patch tested?
   
   - [x] Unit tests, flake8, mypy, `tox`, `make build check`
   - [x] `mvn -pl intg test`
   - [x] Live read-only smoke (typedef, discovery)
   - [ ] PyPI publish 0.0.16 (post-merge)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@atlas.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] ATLAS-5332: Update apache-atlas PyPI client to require Python 3.13+ [atlas]

Posted by "sarathsubramanian (via GitHub)" <gi...@apache.org>.
sarathsubramanian commented on code in PR #686:
URL: https://github.com/apache/atlas/pull/686#discussion_r3568281665


##########
intg/pom.xml:
##########
@@ -154,6 +154,31 @@
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-compiler-plugin</artifactId>
             </plugin>
+            <plugin>
+                <groupId>org.codehaus.mojo</groupId>
+                <artifactId>exec-maven-plugin</artifactId>
+                <version>3.1.0</version>
+                <executions>
+                    <execution>
+                        <id>python-test</id>

Review Comment:
   we are introducing python-tests to be run in addition to the java test suites during maven build. This could potentially fail for certain users who don't have python installed or have the right python version that atlas expects. 
   should we gate this behind a maven profile -Ppython-tests turning it OFF by default and run only for useers who opt to test python test cases.



##########
intg/pom.xml:
##########
@@ -154,6 +154,31 @@
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-compiler-plugin</artifactId>
             </plugin>
+            <plugin>
+                <groupId>org.codehaus.mojo</groupId>
+                <artifactId>exec-maven-plugin</artifactId>
+                <version>3.1.0</version>
+                <executions>
+                    <execution>
+                        <id>python-test</id>
+                        <goals>
+                            <goal>exec</goal>
+                        </goals>
+                        <phase>test</phase>
+                        <configuration>
+                            <skip>${skipTests}</skip>
+                            <executable>python3</executable>

Review Comment:
   python3 may not work on windows. please review



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@atlas.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org