[GitHub] zeppelin issue #1334: [ZEPPELIN-682] New interpreter for Apache Beam (incuba...

[bzz <gi...@git.apache.org>]

Github user bzz commented on the issue:

    https://github.com/apache/zeppelin/pull/1334
  
    Thank you for contributing @mfelgamal ! Apache Beam interpreter is a valuable contribution many people are looking for.
    
    There are few things that need to be done before we can merge it though:
     - this branch need to be rebased on top of the latest master (`git rebase master`) and conflicts must be resolved
     - establish the authorship of this work: this PR includes commits by you and @FouadMA  
     - make sure that every file in this PR, as any other file in ASF project, contain Apache2.0 license header
     - make sure that every file is formatted according to [project's code conventions](https://github.com/apache/zeppelin/blob/master/CONTRIBUTING.md#code-convention): pom.xml, .jave, etc. 
        From the quick glance at the Java code:
       * please make sure you follow the conventions that are used in Zeppelin projects: brackets, sl4j logging. Best way is to look at other interpreters code
       * classes should have comments explaining their purpose and extra empty lines as well as `@author` tags need to be removed
    - `zeppelin-distribution/src/bin_license` must be updated to *include ALL dependencies, AND their transitive dependencies* that were added in this PR. You can see all of them in `mvn dependency:tree`.
    
    Please, feel free to ping me after those issues are addressed and will be happy to look more into it and help you getting this merged!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---