You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/04/12 17:15:09 UTC

[GitHub] [superset] zuzana-vej opened a new issue #14085: [Annotation] Annotations don't show up unless full time interval is included in chart

zuzana-vej opened a new issue #14085:
URL: https://github.com/apache/superset/issues/14085


   #### Description
   If you use a Superset Annotation, using the Interval type, the annotation doesn't show up unless you include the full time interval in the chart. This means that annotations that impact a long time interval often won't show up. 
   
   #### How to reproduce the bug & Screenshots
   1. Create an annotation layer which impacts longer period - all data prior 03/09/2021. One of the events basically impacts all data prior to 3/9/2021. So user created the annotation in for 3/1/2020 (date of the first partition) to 3/9/2021. 
   
    2. When user applied this annotation layer to this chart, they expected to see two annotation events for the two events they created (screenshot from annotation layer not included). Instead, only the later annotation is on the chart. 
   ![Screen Shot 2021-04-12 at 10 10 44 AM](https://user-images.githubusercontent.com/61221714/114434071-70c05b00-9b77-11eb-8631-3cd06ff11aa2.png)
   ![Screen Shot 2021-04-12 at 10 11 16 AM](https://user-images.githubusercontent.com/61221714/114434073-728a1e80-9b77-11eb-8da4-63c62c0e0733.png)
   
   3. When user expands the time range of the chart to go all the way back to 3/1/2020 (which was the first day of the first annotation), then they see both annotation layers on their chart.
   ![Screen Shot 2021-04-12 at 10 11 07 AM](https://user-images.githubusercontent.com/61221714/114434084-74ec7880-9b77-11eb-8c7e-bb6790ab223c.png)
   ![Screen Shot 2021-04-12 at 10 11 10 AM](https://user-images.githubusercontent.com/61221714/114434095-77e76900-9b77-11eb-94fd-ced75a1a1683.png)
   
   #### Expected Behavior
   The annotation layer should show up even if the start date of the annotation is not in range of the displayed chart. 
   
   ### Environment
   
   master
   
   ### Checklist
   
   Make sure to follow these steps before submitting your issue - thank you!
   
   - [ ] I have checked the superset logs for python stacktraces and included it here as text if there are any.
   - [x] I have reproduced the issue with at least the latest released version of superset.
   - [x] I have checked the issue tracker for the same issue and I haven't found one similar.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] zuzana-vej closed issue #14085: [Annotation] Annotations don't show up unless full time interval is included in chart

Posted by GitBox <gi...@apache.org>.
zuzana-vej closed issue #14085:
URL: https://github.com/apache/superset/issues/14085


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] junlincc commented on issue #14085: [Annotation] Annotations don't show up unless full time interval is included in chart

Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #14085:
URL: https://github.com/apache/superset/issues/14085#issuecomment-832876905


   I believe @villebro fixed this one. Please confirm. 🙏


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] zuzana-vej commented on issue #14085: [Annotation] Annotations don't show up unless full time interval is included in chart

Posted by GitBox <gi...@apache.org>.
zuzana-vej commented on issue #14085:
URL: https://github.com/apache/superset/issues/14085#issuecomment-832918779


   Yay It looks resolved to me thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org