You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/06/12 20:05:22 UTC

[GitHub] [kafka] splett2 commented on pull request #12194: MINOR: Include listener name in SocketServer acceptor and processor log context

splett2 commented on PR #12194:
URL: https://github.com/apache/kafka/pull/12194#issuecomment-1153279565

   Thank you for the reviews.
   
   @mimaison 
   technically we don't, but the reason I chose to preserve that part of the log context is because it is inherited by `NioSelector` created by the Processor. If we enable DEBUG logging for the `Selector` class, we'd want to be able to distinguish between SocketServer `Selector` log statements and replica fetcher `Selector` log statements. It didn't seem worth the effort to disentangle the Processor log context from the Selector log context, so it seemed reasonable to just keep the SocketServer, listenerType, etc. prefixing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org