You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cxf.apache.org by GitBox <gi...@apache.org> on 2018/04/19 14:02:32 UTC

[GitHub] WhiteCat22 commented on a change in pull request #407: [CXF-7716] Reduce StringBuilders and other performance changes.

WhiteCat22 commented on a change in pull request #407: [CXF-7716] Reduce StringBuilders and other performance changes.
URL: https://github.com/apache/cxf/pull/407#discussion_r182756615
 
 

 ##########
 File path: rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/utils/ResourceUtils.java
 ##########
 @@ -816,12 +816,23 @@ private static UserOperation getOperationFromElement(Element e) {
                                                       Message m,
                                                       boolean perRequest,
                                                       Map<Class<?>, Object> contextValues) {
-        if (m == null) {
-            m = new MessageImpl();
-        }
         Class<?>[] params = c.getParameterTypes();
         Annotation[][] anns = c.getParameterAnnotations();
         Type[] genericTypes = c.getGenericParameterTypes();
+        return createConstructorArguments(c, m, perRequest, contextValues, params, anns, genericTypes);
+    }
+
+    public static Object[] createConstructorArguments(Constructor<?> c,
 
 Review comment:
   Yes, the idea is that we get them once in the PerRequestResourceProvider constructor, vs getting them via reflection every request.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services