You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by "moremind (via GitHub)" <gi...@apache.org> on 2023/10/17 06:50:18 UTC

[PR] [type:fix] fix integrated test http [shenyu]

moremind opened a new pull request, #5232:
URL: https://github.com/apache/shenyu/pull/5232

   <!-- Describe your PR here; e.g. Fixes #issueNo -->
   
   <!--
   Thank you for proposing a pull request. This template will guide you through the essential steps necessary for a pull request.
   -->
   Make sure that:
   
   - [ ] You have read the [contribution guidelines](https://shenyu.apache.org/community/contributor-guide).
   - [ ] You submit test cases (unit or integration tests) that back your changes.
   - [ ] Your local test passed `./mvnw clean install -Dmaven.javadoc.skip=true`.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [type:fix] fix integrated test http [shenyu]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #5232:
URL: https://github.com/apache/shenyu/pull/5232#issuecomment-1765812595

   ## [Codecov](https://app.codecov.io/gh/apache/shenyu/pull/5232?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   > Merging [#5232](https://app.codecov.io/gh/apache/shenyu/pull/5232?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (6d14bff) into [master](https://app.codecov.io/gh/apache/shenyu/commit/fcb671f6b1f38381972cb980580b8655a250de8c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (fcb671f) will **increase** coverage by `0.00%`.
   > The diff coverage is `n/a`.
   
   > :exclamation: Current head 6d14bff differs from pull request most recent head 6b76dce. Consider uploading reports for the commit 6b76dce to get more accurate results
   
   ```diff
   @@            Coverage Diff            @@
   ##             master    #5232   +/-   ##
   =========================================
     Coverage     61.70%   61.70%           
     Complexity     8597     8597           
   =========================================
     Files          1249     1249           
     Lines         37955    37954    -1     
     Branches       3602     3602           
   =========================================
     Hits          23419    23419           
   - Misses        12480    12483    +3     
   + Partials       2056     2052    -4     
   ```
   
   
   [see 8 files with indirect coverage changes](https://app.codecov.io/gh/apache/shenyu/pull/5232/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [type:fix] fix integrated test http [shenyu]

Posted by "dragon-zhang (via GitHub)" <gi...@apache.org>.
dragon-zhang commented on PR #5232:
URL: https://github.com/apache/shenyu/pull/5232#issuecomment-1766072188

   maybe move the dep to `shenyu-integrated-test-common`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [type:fix] fix integrated test http [shenyu]

Posted by "dragon-zhang (via GitHub)" <gi...@apache.org>.
dragon-zhang merged PR #5232:
URL: https://github.com/apache/shenyu/pull/5232


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org