[jira] [Commented] (HBASE-17434) New Synchronization Scheme for Compaction Pipeline

["Ted Yu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-17434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15805338#comment-15805338 ] 

Ted Yu commented on HBASE-17434:
--------------------------------

The file downloaded from review board is HBASE-17379-V01.patch
So this issue is related to HBASE-17379.

Have you considered my review comment ?

The read only copy seems to try to fix the issue reported in HBASE-17379 but I don't see getScanners() being modified.
I suggest continuing discussion on HBASE-17379 where there is more context.

> New Synchronization Scheme for Compaction Pipeline
> --------------------------------------------------
>
>                 Key: HBASE-17434
>                 URL: https://issues.apache.org/jira/browse/HBASE-17434
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Eshcar Hillel
>         Attachments: HBASE-17434-V01.patch
>
>
> A new copyOnWrite synchronization scheme is introduced for the compaction pipeline.
> The new scheme is better since it removes the lock from getSegments() which is invoked in every get and scan operation, and it reduces the number of LinkedList objects that are created at runtime, thus can reduce GC (not by much, but still...).
> In addition, it fixes the method getTailSize() in compaction pipeline. This method creates a MemstoreSize object which comprises the data size and the overhead size of the segment and needs to be atomic.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)