You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@mesos.apache.org by "Yifan Gu (JIRA)" <ji...@apache.org> on 2014/06/18 03:53:05 UTC

[jira] [Updated] (MESOS-1484) Make the checker code into modules

     [ https://issues.apache.org/jira/browse/MESOS-1484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Yifan Gu updated MESOS-1484:
----------------------------

    Description: 
Currently, we can see a lot of similar codes checking the validation of frameworkId, slaveId, executorId and so on, in the beginning of the message handlers (say launchTasks, killTask). I think maybe we could put those codes into separate modules with well defined interfaces. 

I think this can help us to improve the readability of the code.

Any ideas or discussion on this is highly welcome! Thank you!

  was:
Currently, we can see a lot of similar codes checking the validation of frameworkId, slaveId, executorId and so on, in the beginning of the message handlers (say launchTasks, killTask). I think maybe we could put those codes into separate modules with well defined interfaces. 
I think this can help us to improve the readability of the code, reduce the size of the source, and more importantly, make it easier for folks to add new features (avoiding copy-pasting, which is error prone).

Any ideas or discussion on this is highly welcome! Thank you!


> Make the checker code into modules
> ----------------------------------
>
>                 Key: MESOS-1484
>                 URL: https://issues.apache.org/jira/browse/MESOS-1484
>             Project: Mesos
>          Issue Type: Improvement
>            Reporter: Yifan Gu
>            Priority: Minor
>
> Currently, we can see a lot of similar codes checking the validation of frameworkId, slaveId, executorId and so on, in the beginning of the message handlers (say launchTasks, killTask). I think maybe we could put those codes into separate modules with well defined interfaces. 
> I think this can help us to improve the readability of the code.
> Any ideas or discussion on this is highly welcome! Thank you!



--
This message was sent by Atlassian JIRA
(v6.2#6252)