You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Jarek Cecho <ja...@apache.org> on 2013/10/07 21:11:12 UTC
Review Request 14521: SQOOP-1212 Do not print usage on wrong command line
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14521/
-----------------------------------------------------------
Review request for Sqoop.
Bugs: SQOOP-1212
https://issues.apache.org/jira/browse/SQOOP-1212
Repository: sqoop-trunk
Description
-------
I've removed the code responsible for printing out the usage on incorrect command line. This might be seen as backward incompatible change to some extent, however I believe that no external process should be depending on a usage printed out when incorrect command line is entered and therefore that this change should be fine. Please do not hesitate and let me know if there are any concerns about that!
Diffs
-----
src/java/org/apache/sqoop/Sqoop.java 2addd62146029f862803fb0483da1b158bdd7a6e
Diff: https://reviews.apache.org/r/14521/diff/
Testing
-------
1) Incomplete command line
[root@bousa-trunk ~]# sqoop import --table x
13/10/07 12:09:23 INFO sqoop.Sqoop: Running Sqoop version: 1.4.5-SNAPSHOT
Error: Required argument --connect is missing.
Try --help for usage instructions.
[root@bousa-trunk ~]#
2) Unknown command line argument
[root@bousa-trunk ~]# sqoop import --table x --xxx
13/10/07 12:09:36 INFO sqoop.Sqoop: Running Sqoop version: 1.4.5-SNAPSHOT
13/10/07 12:09:36 ERROR tool.BaseSqoopTool: Error parsing arguments for import:
13/10/07 12:09:36 ERROR tool.BaseSqoopTool: Unrecognized argument: --xxx
Try --help for usage instructions.
Thanks,
Jarek Cecho
Re: Review Request 14521: SQOOP-1212 Do not print usage on wrong command line
Posted by Gwen Shapira <gs...@cloudera.com>.
> On July 5, 2014, 2:34 p.m., Gwen Shapira wrote:
> > Ship It!
Printing the super long usage doc every time made Sqoop seem much harder to use than it actually is.
- Gwen
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14521/#review47348
-----------------------------------------------------------
On Oct. 7, 2013, 7:11 p.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14521/
> -----------------------------------------------------------
>
> (Updated Oct. 7, 2013, 7:11 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1212
> https://issues.apache.org/jira/browse/SQOOP-1212
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> I've removed the code responsible for printing out the usage on incorrect command line. This might be seen as backward incompatible change to some extent, however I believe that no external process should be depending on a usage printed out when incorrect command line is entered and therefore that this change should be fine. Please do not hesitate and let me know if there are any concerns about that!
>
>
> Diffs
> -----
>
> src/java/org/apache/sqoop/Sqoop.java 2addd62146029f862803fb0483da1b158bdd7a6e
>
> Diff: https://reviews.apache.org/r/14521/diff/
>
>
> Testing
> -------
>
> 1) Incomplete command line
> [root@bousa-trunk ~]# sqoop import --table x
> 13/10/07 12:09:23 INFO sqoop.Sqoop: Running Sqoop version: 1.4.5-SNAPSHOT
> Error: Required argument --connect is missing.
> Try --help for usage instructions.
> [root@bousa-trunk ~]#
>
> 2) Unknown command line argument
> [root@bousa-trunk ~]# sqoop import --table x --xxx
> 13/10/07 12:09:36 INFO sqoop.Sqoop: Running Sqoop version: 1.4.5-SNAPSHOT
> 13/10/07 12:09:36 ERROR tool.BaseSqoopTool: Error parsing arguments for import:
> 13/10/07 12:09:36 ERROR tool.BaseSqoopTool: Unrecognized argument: --xxx
>
> Try --help for usage instructions.
>
>
> Thanks,
>
> Jarek Cecho
>
>
Re: Review Request 14521: SQOOP-1212 Do not print usage on wrong command line
Posted by Gwen Shapira <gs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14521/#review47348
-----------------------------------------------------------
Ship it!
Ship It!
- Gwen Shapira
On Oct. 7, 2013, 7:11 p.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14521/
> -----------------------------------------------------------
>
> (Updated Oct. 7, 2013, 7:11 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1212
> https://issues.apache.org/jira/browse/SQOOP-1212
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> I've removed the code responsible for printing out the usage on incorrect command line. This might be seen as backward incompatible change to some extent, however I believe that no external process should be depending on a usage printed out when incorrect command line is entered and therefore that this change should be fine. Please do not hesitate and let me know if there are any concerns about that!
>
>
> Diffs
> -----
>
> src/java/org/apache/sqoop/Sqoop.java 2addd62146029f862803fb0483da1b158bdd7a6e
>
> Diff: https://reviews.apache.org/r/14521/diff/
>
>
> Testing
> -------
>
> 1) Incomplete command line
> [root@bousa-trunk ~]# sqoop import --table x
> 13/10/07 12:09:23 INFO sqoop.Sqoop: Running Sqoop version: 1.4.5-SNAPSHOT
> Error: Required argument --connect is missing.
> Try --help for usage instructions.
> [root@bousa-trunk ~]#
>
> 2) Unknown command line argument
> [root@bousa-trunk ~]# sqoop import --table x --xxx
> 13/10/07 12:09:36 INFO sqoop.Sqoop: Running Sqoop version: 1.4.5-SNAPSHOT
> 13/10/07 12:09:36 ERROR tool.BaseSqoopTool: Error parsing arguments for import:
> 13/10/07 12:09:36 ERROR tool.BaseSqoopTool: Unrecognized argument: --xxx
>
> Try --help for usage instructions.
>
>
> Thanks,
>
> Jarek Cecho
>
>
Re: Review Request 14521: SQOOP-1212 Do not print usage on wrong command line
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14521/#review33455
-----------------------------------------------------------
Ship it!
Perfect. Never did like unnecessary usage info!
- Abraham Elmahrek
On Oct. 7, 2013, 7:11 p.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14521/
> -----------------------------------------------------------
>
> (Updated Oct. 7, 2013, 7:11 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1212
> https://issues.apache.org/jira/browse/SQOOP-1212
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> I've removed the code responsible for printing out the usage on incorrect command line. This might be seen as backward incompatible change to some extent, however I believe that no external process should be depending on a usage printed out when incorrect command line is entered and therefore that this change should be fine. Please do not hesitate and let me know if there are any concerns about that!
>
>
> Diffs
> -----
>
> src/java/org/apache/sqoop/Sqoop.java 2addd62146029f862803fb0483da1b158bdd7a6e
>
> Diff: https://reviews.apache.org/r/14521/diff/
>
>
> Testing
> -------
>
> 1) Incomplete command line
> [root@bousa-trunk ~]# sqoop import --table x
> 13/10/07 12:09:23 INFO sqoop.Sqoop: Running Sqoop version: 1.4.5-SNAPSHOT
> Error: Required argument --connect is missing.
> Try --help for usage instructions.
> [root@bousa-trunk ~]#
>
> 2) Unknown command line argument
> [root@bousa-trunk ~]# sqoop import --table x --xxx
> 13/10/07 12:09:36 INFO sqoop.Sqoop: Running Sqoop version: 1.4.5-SNAPSHOT
> 13/10/07 12:09:36 ERROR tool.BaseSqoopTool: Error parsing arguments for import:
> 13/10/07 12:09:36 ERROR tool.BaseSqoopTool: Unrecognized argument: --xxx
>
> Try --help for usage instructions.
>
>
> Thanks,
>
> Jarek Cecho
>
>