[jira] [Commented] (AMBARI-17041) Support password type for custom properties

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AMBARI-17041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15355001#comment-15355001 ] 

Hadoop QA commented on AMBARI-17041:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12814276/AMBARI-17041-trunk.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in ambari-server ambari-web:

                  org.apache.ambari.server.controller.internal.JMXHostProviderTest
                  org.apache.ambari.server.state.ConfigHelperTest
                  org.apache.ambari.server.controller.AmbariManagementControllerTest

                                      The test build failed in ambari-web 

Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/7582//testReport/
Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/7582//console

This message is automatically generated.

> Support password type for custom properties
> -------------------------------------------
>
>                 Key: AMBARI-17041
>                 URL: https://issues.apache.org/jira/browse/AMBARI-17041
>             Project: Ambari
>          Issue Type: New Feature
>          Components: ambari-server
>    Affects Versions: 2.2.2
>            Reporter: Tuong Truong
>            Assignee: Keta Patel
>         Attachments: AMBARI-17041-trunk.patch, add_property_pop_up.tiff, cluster_config_with_password_type_in_config_attributes_column.tiff, custom_properties_after_save.tiff, custom_property_password_type.tiff, custom_property_regular_type.tiff, schema_of_clusterconfig_table.tiff
>
>
> Currently, services can define properties in the XML configuration files that is flagged as type password:
>   <property>
>         <name>my.special.password</name>
>         <value></value>
>         <property-type>PASSWORD</property-type>
>         <description>Password to be masked</description>
>     </property> 
> and it will be masked properly in the UI as well as blueprint.
> Custom property should also support this option so that password can be added as custom property and treat accordingly.
> ==========================================
> Proposed Design for the fix:
> ==========================================
> At present only the key-value information of the service properties is stored in the DB ("clusterconfig" table in the "config_data" column). 
> The "config_attributes" column stores only certain attributes like "final" indicating the list of properties set with the Final flag = true. 
> The information about the property-type (i.e PASSWORD, USER, GROUP, ADDITIONAL_USER_PROPERTY, VALUE_FROM_PROPERTY_FILE, NOT_MANAGED_HDFS_PATH, etc) is extracted from the corresponding service's property file (e.g. hive-site.xml, core-site.xml, webhcat-env.xml, etc). These files contain information of the existing properties only. Custom Properties added by ambari user have no provision to store their additional attributes. 
> Since, for this Jira we are concerned with only <property-type> attribute for Custom Properties, we could add an additional field called "Property Type" in the "Add Property" pop-up which shows up on clicking "Add Property ..." in the Custom property section for a service. For now, only 2 options are shown in the drop-down list: NONE and PASSWORD .
> A few test properties are created using the new "Add Property" pop-up. 
> Attachments: 
> "add_property_pop_up.tiff"
> "custom_property_password_type.tiff"
> "custom_property_regular_type.tiff"
> "custom_properties_after_save.tiff"
> The <property-type> information for these Custom properties is stored in the DB in "clusterconfig" table, "config_attributes" column.
> The schema for "clusterconfig" table can be seen in the attachment:
> "schema_of_clusterconfig_table.tiff"
> The content of the "config_attributes" column with the <property-type> information from the new Custom properties can be seen in the attachment:
> "cluster_config_with_password_type_in_config_attributes_column.tiff"
> Note: The fix so far is performed only for new Custom properties. The <property-type> information for existing properties is extracted from the corresponding property xml files for the service.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)