You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Jonathan Hurley <jh...@hortonworks.com> on 2017/08/29 14:42:24 UTC
Review Request 61968: PATCH and MAINT Orchestrations Should Only
Invoke stack-select On Specific Packages
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61968/
-----------------------------------------------------------
Review request for Ambari, Dmitro Lisnichenko and Nate Cole.
Bugs: AMBARI-21842
https://issues.apache.org/jira/browse/AMBARI-21842
Repository: ambari
Description
-------
During a {{PATCH}} or {{MAINT}} upgrade, the agents are invoking {{stack_select}} as if it was a {{STANDARD}} upgrade.
Diffs
-----
ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py a83fd63875
ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/datanode.py 79c32e4ad0
ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/hdfs_client.py 95d160303b
ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/journalnode.py 9c5a124b70
ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/namenode.py 17d810710a
ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/nfsgateway.py 770df593a5
ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/snamenode.py 30eee07ad7
ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/OOZIE/package/scripts/oozie_client.py 9bbca9ffed
ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/OOZIE/package/scripts/oozie_server.py b3a8643562
ambari-server/src/test/python/TestStackSelect.py PRE-CREATION
Diff: https://reviews.apache.org/r/61968/diff/1/
Testing
-------
----------------------------------------------------------------------
Total run:1181
Total errors:0
Total failures:0
OK
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 52.669 s
[INFO] Finished at: 2017-08-29T10:41:46-04:00
[INFO] Final Memory: 21M/619M
[INFO] ------------------------------------------------------------------------
Thanks,
Jonathan Hurley
Re: Review Request 61968: PATCH and MAINT Orchestrations Should Only
Invoke stack-select On Specific Packages
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61968/#review184059
-----------------------------------------------------------
Ship it!
Ship It!
- Dmitro Lisnichenko
On Aug. 29, 2017, 5:42 p.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61968/
> -----------------------------------------------------------
>
> (Updated Aug. 29, 2017, 5:42 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko and Nate Cole.
>
>
> Bugs: AMBARI-21842
> https://issues.apache.org/jira/browse/AMBARI-21842
>
>
> Repository: ambari
>
>
> Description
> -------
>
> During a {{PATCH}} or {{MAINT}} upgrade, the agents are invoking {{stack_select}} as if it was a {{STANDARD}} upgrade.
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py a83fd63875
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/datanode.py 79c32e4ad0
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/hdfs_client.py 95d160303b
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/journalnode.py 9c5a124b70
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/namenode.py 17d810710a
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/nfsgateway.py 770df593a5
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/snamenode.py 30eee07ad7
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/OOZIE/package/scripts/oozie_client.py 9bbca9ffed
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/OOZIE/package/scripts/oozie_server.py b3a8643562
> ambari-server/src/test/python/TestStackSelect.py PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/61968/diff/1/
>
>
> Testing
> -------
>
> ----------------------------------------------------------------------
> Total run:1181
> Total errors:0
> Total failures:0
> OK
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 52.669 s
> [INFO] Finished at: 2017-08-29T10:41:46-04:00
> [INFO] Final Memory: 21M/619M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Jonathan Hurley
>
>
Re: Review Request 61968: PATCH and MAINT Orchestrations Should Only
Invoke stack-select On Specific Packages
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61968/#review184055
-----------------------------------------------------------
ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py
Lines 203-206 (original), 208-226 (patched)
<https://reviews.apache.org/r/61968/#comment260058>
This is the most important change in this commit. Basically, instead of assuming a STANDARD orchestration, we extract it from teh upgrade_summary.
- Jonathan Hurley
On Aug. 29, 2017, 10:42 a.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61968/
> -----------------------------------------------------------
>
> (Updated Aug. 29, 2017, 10:42 a.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko and Nate Cole.
>
>
> Bugs: AMBARI-21842
> https://issues.apache.org/jira/browse/AMBARI-21842
>
>
> Repository: ambari
>
>
> Description
> -------
>
> During a {{PATCH}} or {{MAINT}} upgrade, the agents are invoking {{stack_select}} as if it was a {{STANDARD}} upgrade.
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py a83fd63875
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/datanode.py 79c32e4ad0
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/hdfs_client.py 95d160303b
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/journalnode.py 9c5a124b70
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/namenode.py 17d810710a
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/nfsgateway.py 770df593a5
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/snamenode.py 30eee07ad7
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/OOZIE/package/scripts/oozie_client.py 9bbca9ffed
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/OOZIE/package/scripts/oozie_server.py b3a8643562
> ambari-server/src/test/python/TestStackSelect.py PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/61968/diff/1/
>
>
> Testing
> -------
>
> ----------------------------------------------------------------------
> Total run:1181
> Total errors:0
> Total failures:0
> OK
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 52.669 s
> [INFO] Finished at: 2017-08-29T10:41:46-04:00
> [INFO] Final Memory: 21M/619M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Jonathan Hurley
>
>
Re: Review Request 61968: PATCH and MAINT Orchestrations Should Only
Invoke stack-select On Specific Packages
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61968/#review184061
-----------------------------------------------------------
Ship it!
Ship It!
- Nate Cole
On Aug. 29, 2017, 10:42 a.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61968/
> -----------------------------------------------------------
>
> (Updated Aug. 29, 2017, 10:42 a.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko and Nate Cole.
>
>
> Bugs: AMBARI-21842
> https://issues.apache.org/jira/browse/AMBARI-21842
>
>
> Repository: ambari
>
>
> Description
> -------
>
> During a {{PATCH}} or {{MAINT}} upgrade, the agents are invoking {{stack_select}} as if it was a {{STANDARD}} upgrade.
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py a83fd63875
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/datanode.py 79c32e4ad0
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/hdfs_client.py 95d160303b
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/journalnode.py 9c5a124b70
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/namenode.py 17d810710a
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/nfsgateway.py 770df593a5
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/snamenode.py 30eee07ad7
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/OOZIE/package/scripts/oozie_client.py 9bbca9ffed
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/OOZIE/package/scripts/oozie_server.py b3a8643562
> ambari-server/src/test/python/TestStackSelect.py PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/61968/diff/1/
>
>
> Testing
> -------
>
> ----------------------------------------------------------------------
> Total run:1181
> Total errors:0
> Total failures:0
> OK
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 52.669 s
> [INFO] Finished at: 2017-08-29T10:41:46-04:00
> [INFO] Final Memory: 21M/619M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Jonathan Hurley
>
>