You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@logging.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2021/12/25 19:21:00 UTC

[jira] [Commented] (LOG4J2-3289) log4j-to-slf4j should not re-format the result of Message.getFormattedMessage

    [ https://issues.apache.org/jira/browse/LOG4J2-3289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465244#comment-17465244 ] 

ASF subversion and git services commented on LOG4J2-3289:
---------------------------------------------------------

Commit 487588b7c34bc0b540e769d98c42d018fa1bc1b8 in logging-log4j2's branch refs/heads/release-2.x from Carter Kozak
[ https://gitbox.apache.org/repos/asf?p=logging-log4j2.git;h=487588b ]

LOG4J2-3289: Fix log4j-to-slf4j re-interpolation of formatted message data


> log4j-to-slf4j should not re-format the result of Message.getFormattedMessage
> -----------------------------------------------------------------------------
>
>                 Key: LOG4J2-3289
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-3289
>             Project: Log4j 2
>          Issue Type: Bug
>          Components: SLF4J Bridge
>    Affects Versions: 2.17.0
>            Reporter: Carter Kozak
>            Priority: Major
>             Fix For: 2.17.1
>
>
> Both the formatted message result (for the configured MessageFactory) and the parameter array are passed to slf4j, such that slf4j attempts to format the already formatted result:
> [https://github.com/apache/logging-log4j2/blob/20f9a97dbe5928c3b5077bcdd2a22ac92e941655/log4j-to-slf4j/src/main/java/org/apache/logging/slf4j/SLF4JLogger.java#L226-L256]
> Caught a similar issue while reviewing this change, but realized it also applies to the slf4j bridge: [https://github.com/apache/logging-log4j2/pull/653#discussion_r775083351]



--
This message was sent by Atlassian Jira
(v8.20.1#820001)