You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "wombatu-kun (via GitHub)" <gi...@apache.org> on 2024/03/30 14:48:42 UTC
[PR] [HUDI-6884] hudi-cli should generate correct HoodieTimeGeneratorConfig [hudi]
wombatu-kun opened a new pull request, #10941:
URL: https://github.com/apache/hudi/pull/10941
### Change Logs
Currently, we build HoodieTimeGeneratorConfig with default configuration, instead we should respect props users set.
### Impact
none
### Risk level (write none, low medium or high below)
none
### Documentation Update
none
- _The config description must be updated if new configs are added or the default value of the configs are changed_
- _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make
changes to the website._
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-6884] hudi-cli should generate correct HoodieTimeGeneratorConfig [hudi]
Posted by "wombatu-kun (via GitHub)" <gi...@apache.org>.
wombatu-kun commented on code in PR #10941:
URL: https://github.com/apache/hudi/pull/10941#discussion_r1545519468
##########
hudi-cli/src/main/java/org/apache/hudi/cli/commands/TableCommand.java:
##########
@@ -85,13 +87,25 @@ public String connect(
@ShellOption(value = {"--maxWaitIntervalMs"}, defaultValue = "300000",
help = "Max wait time for eventual consistency") final Integer maxConsistencyIntervalMs,
@ShellOption(value = {"--maxCheckIntervalMs"}, defaultValue = "7",
- help = "Max checks for eventual consistency") final Integer maxConsistencyChecks)
+ help = "Max checks for eventual consistency") final Integer maxConsistencyChecks,
+ @ShellOption(value = {"--timeGeneratorType"}, defaultValue = "WAIT_TO_ADJUST_SKEW",
+ help = "Time generator type, which is used to generate globally monotonically increasing timestamp") final String timeGeneratorType,
+ @ShellOption(value = {"--maxExpectedClockSkewMs"}, defaultValue = "200",
Review Comment:
Yes, you are right
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-6884] hudi-cli should generate correct HoodieTimeGeneratorConfig [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #10941:
URL: https://github.com/apache/hudi/pull/10941#issuecomment-2028097235
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "be7805c337c63009b62bb5c4af1306526b0003ce",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "be7805c337c63009b62bb5c4af1306526b0003ce",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* be7805c337c63009b62bb5c4af1306526b0003ce UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-6884] hudi-cli should generate correct HoodieTimeGeneratorConfig [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #10941:
URL: https://github.com/apache/hudi/pull/10941#issuecomment-2028151179
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "be7805c337c63009b62bb5c4af1306526b0003ce",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23059",
"triggerID" : "be7805c337c63009b62bb5c4af1306526b0003ce",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* be7805c337c63009b62bb5c4af1306526b0003ce Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23059)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-6884] hudi-cli should generate correct HoodieTimeGeneratorConfig [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #10941:
URL: https://github.com/apache/hudi/pull/10941#issuecomment-2028259127
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "be7805c337c63009b62bb5c4af1306526b0003ce",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23059",
"triggerID" : "be7805c337c63009b62bb5c4af1306526b0003ce",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* be7805c337c63009b62bb5c4af1306526b0003ce Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23059)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-6884] hudi-cli should generate correct HoodieTimeGeneratorConfig [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #10941:
URL: https://github.com/apache/hudi/pull/10941#discussion_r1545518905
##########
hudi-cli/src/main/java/org/apache/hudi/cli/commands/TableCommand.java:
##########
@@ -85,13 +87,25 @@ public String connect(
@ShellOption(value = {"--maxWaitIntervalMs"}, defaultValue = "300000",
help = "Max wait time for eventual consistency") final Integer maxConsistencyIntervalMs,
@ShellOption(value = {"--maxCheckIntervalMs"}, defaultValue = "7",
- help = "Max checks for eventual consistency") final Integer maxConsistencyChecks)
+ help = "Max checks for eventual consistency") final Integer maxConsistencyChecks,
+ @ShellOption(value = {"--timeGeneratorType"}, defaultValue = "WAIT_TO_ADJUST_SKEW",
+ help = "Time generator type, which is used to generate globally monotonically increasing timestamp") final String timeGeneratorType,
+ @ShellOption(value = {"--maxExpectedClockSkewMs"}, defaultValue = "200",
Review Comment:
So the 3 new added options are all optional right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-6884] hudi-cli should generate correct HoodieTimeGeneratorConfig [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 merged PR #10941:
URL: https://github.com/apache/hudi/pull/10941
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org