[GitHub] [openwhisk] chetanmeh commented on a change in pull request #4782: A docker image for the standalone openwhisk

[GitBox <gi...@apache.org>]

chetanmeh commented on a change in pull request #4782: A docker image for the standalone openwhisk
URL: https://github.com/apache/openwhisk/pull/4782#discussion_r365498537
 
 

 ##########
 File path: core/standalone/Dockerfile
 ##########
 @@ -0,0 +1,33 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+FROM scala
+ARG OPENWHISK_JAR
+ENV DOCKER_VERSION=18.06.3-ce
+ENV WSK_VERSION=1.0.0
+ADD init /
+ADD stop /bin/stop
+RUN chmod +x /bin/stop ;\
 
 Review comment:
   Just to confirm - For docker-in-docker case is the version of Docker packaged within container needs to be same as one on the host?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services