You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by jeking3 <gi...@git.apache.org> on 2015/06/24 19:50:28 UTC
[GitHub] thrift pull request: THRIFT-3053: Added perl SSL Socket support, s...
GitHub user jeking3 opened a pull request:
https://github.com/apache/thrift/pull/527
THRIFT-3053: Added perl SSL Socket support, split SSLSocket and SSLSe…
…rverSocket out from their base classes, fixed THRIFT-3191 generated perl compiler exception handling code, added perl to make cross, fixed THRIFT-3189 allowing perl to listen on a specific interface through construction arguments. Did not add support in the perl client SSLSocket to verify server certificate authenticity at this time.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jeking3/thrift bugfix/THRIFT-perl-ssl-support-and-make-cross
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/527.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #527
----
commit 1cef2be4a59c931faf28944098ad6f007e700d16
Author: Jim King <ji...@simplivity.com>
Date: 2015-06-24T17:47:24Z
THRIFT-3053: Added perl SSL Socket support, split SSLSocket and SSLServerSocket out from their base classes, fixed THRIFT-3191 generated perl compiler exception handling code, added perl to make cross, fixed THRIFT-3189 allowing perl to listen on a specific interface through construction arguments. Did not add support in the perl client SSLSocket to verify server certificate authenticity at this time.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-3053: Added perl SSL Socket support, s...
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on the pull request:
https://github.com/apache/thrift/pull/527#issuecomment-119681042
I need some help understanding why this is failing in the Travis CI environment when it passes locally. The "-ssl" tests that involve Perl are all failing. The non-ssl ones involving perl that are failing like nodejs are not ones I've run locally so they may need a suppression which I can add.
I still don't like that I cannot see the results of each "make cross" test in Travis CI... can we fix that?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-3053: Added perl SSL Socket support, s...
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on the pull request:
https://github.com/apache/thrift/pull/527#issuecomment-209758791
SUCCESS: Integrated in Thrift #1629 so I am closing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-3053: Added perl SSL Socket support, s...
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 closed the pull request at:
https://github.com/apache/thrift/pull/527
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-3053: Added perl SSL Socket support, s...
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on the pull request:
https://github.com/apache/thrift/pull/527#issuecomment-115372068
The "make cross" omitted perl from the cross check, likely because of:
checking for perl... /usr/bin/perl
checking for perl module Bit::Vector... no
checking for perl module Class::Accessor... no
Sadly, the travis build succeeded even though it should have failed because perl wasn't tested. I updated the perl deps and the perl doc (README.md) and we'll see if it gets things right this time around. If not, I'll look into why those are failing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---