You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Benjamin Reed (JIRA)" <ji...@apache.org> on 2009/06/05 23:14:07 UTC
[jira] Created: (ZOOKEEPER-436) Bookies should auto register to
ZooKeeper
Bookies should auto register to ZooKeeper
-----------------------------------------
Key: ZOOKEEPER-436
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-436
Project: Zookeeper
Issue Type: Improvement
Reporter: Benjamin Reed
currently bookies have to be manually added to ZooKeeper to be used in a BookKeeper service. we should be able to just start up a bookkie, point it at ZooKeeper, and have it get auto integrated in.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-436) Bookies should auto register to
ZooKeeper
Posted by "Flavio Paiva Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Flavio Paiva Junqueira updated ZOOKEEPER-436:
---------------------------------------------
Fix Version/s: 3.3.0
Status: Patch Available (was: Open)
> Bookies should auto register to ZooKeeper
> -----------------------------------------
>
> Key: ZOOKEEPER-436
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-436
> Project: Zookeeper
> Issue Type: Improvement
> Components: contrib-bookkeeper
> Reporter: Benjamin Reed
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-436.patch, ZOOKEEPER-436.patch
>
>
> currently bookies have to be manually added to ZooKeeper to be used in a BookKeeper service. we should be able to just start up a bookkie, point it at ZooKeeper, and have it get auto integrated in.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-436) Bookies should auto register to
ZooKeeper
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12846154#action_12846154 ]
Hadoop QA commented on ZOOKEEPER-436:
-------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12438969/ZOOKEEPER-436.patch
against trunk revision 923984.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/27/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/27/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/27/console
This message is automatically generated.
> Bookies should auto register to ZooKeeper
> -----------------------------------------
>
> Key: ZOOKEEPER-436
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-436
> Project: Zookeeper
> Issue Type: Improvement
> Components: contrib-bookkeeper
> Reporter: Benjamin Reed
> Attachments: ZOOKEEPER-436.patch
>
>
> currently bookies have to be manually added to ZooKeeper to be used in a BookKeeper service. we should be able to just start up a bookkie, point it at ZooKeeper, and have it get auto integrated in.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-436) Bookies should auto register to
ZooKeeper
Posted by "Flavio Paiva Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Flavio Paiva Junqueira updated ZOOKEEPER-436:
---------------------------------------------
Attachment: ZOOKEEPER-436.patch
Removing double initialization of bookies.
> Bookies should auto register to ZooKeeper
> -----------------------------------------
>
> Key: ZOOKEEPER-436
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-436
> Project: Zookeeper
> Issue Type: Improvement
> Components: contrib-bookkeeper
> Reporter: Benjamin Reed
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-436.patch, ZOOKEEPER-436.patch, ZOOKEEPER-436.patch
>
>
> currently bookies have to be manually added to ZooKeeper to be used in a BookKeeper service. we should be able to just start up a bookkie, point it at ZooKeeper, and have it get auto integrated in.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-436) Bookies should auto register to
ZooKeeper
Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Reed updated ZOOKEEPER-436:
------------------------------------
Status: Open (was: Patch Available)
> Bookies should auto register to ZooKeeper
> -----------------------------------------
>
> Key: ZOOKEEPER-436
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-436
> Project: Zookeeper
> Issue Type: Improvement
> Components: contrib-bookkeeper
> Reporter: Benjamin Reed
> Attachments: ZOOKEEPER-436.patch
>
>
> currently bookies have to be manually added to ZooKeeper to be used in a BookKeeper service. we should be able to just start up a bookkie, point it at ZooKeeper, and have it get auto integrated in.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-436) Bookies should auto register to
ZooKeeper
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12847011#action_12847011 ]
Mahadev konar commented on ZOOKEEPER-436:
-----------------------------------------
I still see tests fails.
{code}
estsuite: org.apache.bookkeeper.test.BookieClientTest
Tests run: 2, Failures: 1, Errors: 0, Time elapsed: 0.664 sec
------------- Standard Output ---------------
2010-03-18 17:25:11,571 - WARN - [main:Bookie@212] - No ZK servers passed to Bookie constructor so BookKeeper clients won't know about this server!
2010-03-18 17:25:11,603 - INFO - [main:LedgerCache@71] - openFileLimit is 900
2010-03-18 17:25:11,605 - INFO - [main:LedgerCache@77] - maxMemory = 517013504
2010-03-18 17:25:11,606 - INFO - [main:LedgerCache@81] - pageLimit is 21037
2010-03-18 17:25:11,609 - ERROR - [main:Bookie$LastLogMark@372] - Problems reading from /tmp/bookie9716test/lastMark (this is okay if it is the first time starting this bookie
2010-03-18 17:25:11,864 - INFO - [New I/O client worker #1-1:PerChannelBookieClient$1@122] - Successfully connected to bookie: /127.0.0.1:13645
2010-03-18 17:25:11,893 - INFO - [New I/O client worker #1-1:PerChannelBookieClient@373] - Disconnected from bookie: /127.0.0.1:13645
2010-03-18 17:25:11,895 - ERROR - [pool-4-thread-1:PerChannelBookieClient$5@316] - Could not write request for adding entry: 1 ledger-id: 1 bookie: /127.0.0.1:13645
2010-03-18 17:25:11,896 - ERROR - [pool-4-thread-1:PerChannelBookieClient$5@321] - Invoked callback method: 1
2010-03-18 17:25:12,071 - FATAL - [Thread-0:Bookie@432] - Bookie thread exiting
java.lang.InterruptedException
at java.util.concurrent.locks.AbstractQueuedSynchronizer.acquireInterruptibly(AbstractQueuedSynchronizer.java:1100)
at java.util.concurrent.locks.ReentrantLock.lockInterruptibly(ReentrantLock.java:312)
at java.util.concurrent.LinkedBlockingQueue.take(LinkedBlockingQueue.java:354)
at org.apache.bookkeeper.bookie.Bookie.run(Bookie.java:398)
2010-03-18 17:25:12,087 - WARN - [main:Bookie@212] - No ZK servers passed to Bookie constructor so BookKeeper clients won't know about this server!
2010-03-18 17:25:12,088 - ERROR - [main:Bookie$LastLogMark@372] - Problems reading from /tmp/bookie9717test/lastMark (this is okay if it is the first time starting this bookie
2010-03-18 17:25:12,093 - INFO - [New I/O client worker #2-1:PerChannelBookieClient$1@122] - Successfully connected to bookie: /127.0.0.1:13645
2010-03-18 17:25:12,097 - INFO - [New I/O client worker #2-1:PerChannelBookieClient@373] - Disconnected from bookie: /127.0.0.1:13645
2010-03-18 17:25:12,097 - FATAL - [Thread-2:Bookie@432] - Bookie thread exiting
java.lang.InterruptedException
at java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.reportInterruptAfterWait(AbstractQueuedSynchronizer.java:1863)
at java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.await(AbstractQueuedSynchronizer.java:1898)
at java.util.concurrent.LinkedBlockingQueue.take(LinkedBlockingQueue.java:358)
at org.apache.bookkeeper.bookie.Bookie.run(Bookie.java:398)
------------- ---------------- ---------------
Testcase: testWriteGaps took 0.526 sec
FAILED
expected:<0> but was:<-13>
junit.framework.AssertionFailedError: expected:<0> but was:<-13>
at org.apache.bookkeeper.test.BookieClientTest.testWriteGaps(BookieClientTest.java:132)
Testcase: testNoLedger took 0.107 sec
{code}
> Bookies should auto register to ZooKeeper
> -----------------------------------------
>
> Key: ZOOKEEPER-436
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-436
> Project: Zookeeper
> Issue Type: Improvement
> Components: contrib-bookkeeper
> Reporter: Benjamin Reed
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-436.patch, ZOOKEEPER-436.patch
>
>
> currently bookies have to be manually added to ZooKeeper to be used in a BookKeeper service. we should be able to just start up a bookkie, point it at ZooKeeper, and have it get auto integrated in.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-436) Bookies should auto register to
ZooKeeper
Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12846171#action_12846171 ]
Benjamin Reed commented on ZOOKEEPER-436:
-----------------------------------------
excellent work erwin! you need to modify BaseTestCase in the BookKeeper tests and remove the creating of the znodes under /ledgers/available in setUp(). that will allow the tests to exercise your code.
> Bookies should auto register to ZooKeeper
> -----------------------------------------
>
> Key: ZOOKEEPER-436
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-436
> Project: Zookeeper
> Issue Type: Improvement
> Components: contrib-bookkeeper
> Reporter: Benjamin Reed
> Attachments: ZOOKEEPER-436.patch
>
>
> currently bookies have to be manually added to ZooKeeper to be used in a BookKeeper service. we should be able to just start up a bookkie, point it at ZooKeeper, and have it get auto integrated in.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-436) Bookies should auto register to
ZooKeeper
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-436:
-----------------------------------
Status: Patch Available (was: Open)
> Bookies should auto register to ZooKeeper
> -----------------------------------------
>
> Key: ZOOKEEPER-436
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-436
> Project: Zookeeper
> Issue Type: Improvement
> Components: contrib-bookkeeper
> Reporter: Benjamin Reed
> Assignee: Erwin Tam
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-436.patch, ZOOKEEPER-436.patch, ZOOKEEPER-436.patch
>
>
> currently bookies have to be manually added to ZooKeeper to be used in a BookKeeper service. we should be able to just start up a bookkie, point it at ZooKeeper, and have it get auto integrated in.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-436) Bookies should auto register to
ZooKeeper
Posted by "Erwin Tam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12847007#action_12847007 ]
Erwin Tam commented on ZOOKEEPER-436:
-------------------------------------
Oops, I knew i'd miss something from porting over the changes made earlier. Yeah, doing the formatting changes does make doing a quick glance at svn diff hard. Had this change on the original version but missed it when porting changes over manually. Thanks for catching it!
> Bookies should auto register to ZooKeeper
> -----------------------------------------
>
> Key: ZOOKEEPER-436
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-436
> Project: Zookeeper
> Issue Type: Improvement
> Components: contrib-bookkeeper
> Reporter: Benjamin Reed
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-436.patch, ZOOKEEPER-436.patch
>
>
> currently bookies have to be manually added to ZooKeeper to be used in a BookKeeper service. we should be able to just start up a bookkie, point it at ZooKeeper, and have it get auto integrated in.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-436) Bookies should auto register to
ZooKeeper
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated ZOOKEEPER-436:
------------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
This has been committed in 3.3. Ben forgot to close it. thanks erwin and flavio!
> Bookies should auto register to ZooKeeper
> -----------------------------------------
>
> Key: ZOOKEEPER-436
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-436
> Project: Zookeeper
> Issue Type: Improvement
> Components: contrib-bookkeeper
> Reporter: Benjamin Reed
> Assignee: Erwin Tam
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-436.patch, ZOOKEEPER-436.patch, ZOOKEEPER-436.patch
>
>
> currently bookies have to be manually added to ZooKeeper to be used in a BookKeeper service. we should be able to just start up a bookkie, point it at ZooKeeper, and have it get auto integrated in.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-436) Bookies should auto register to
ZooKeeper
Posted by "Flavio Paiva Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Flavio Paiva Junqueira updated ZOOKEEPER-436:
---------------------------------------------
Status: Open (was: Patch Available)
Thanks for the patch, Erwin! The patch you've uploaded does not apply, though. Could you please re-generate the patch having the zookeeper project folder as the root? The current patch apparently has the bookkeeper folder as the root instead.
> Bookies should auto register to ZooKeeper
> -----------------------------------------
>
> Key: ZOOKEEPER-436
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-436
> Project: Zookeeper
> Issue Type: Improvement
> Components: contrib-bookkeeper
> Reporter: Benjamin Reed
> Attachments: ZOOKEEPER-436.patch
>
>
> currently bookies have to be manually added to ZooKeeper to be used in a BookKeeper service. we should be able to just start up a bookkie, point it at ZooKeeper, and have it get auto integrated in.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-436) Bookies should auto register to
ZooKeeper
Posted by "Erwin Tam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Erwin Tam updated ZOOKEEPER-436:
--------------------------------
Status: Patch Available (was: Open)
> Bookies should auto register to ZooKeeper
> -----------------------------------------
>
> Key: ZOOKEEPER-436
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-436
> Project: Zookeeper
> Issue Type: Improvement
> Components: contrib-bookkeeper
> Reporter: Benjamin Reed
> Attachments: ZOOKEEPER-436.patch
>
>
> currently bookies have to be manually added to ZooKeeper to be used in a BookKeeper service. we should be able to just start up a bookkie, point it at ZooKeeper, and have it get auto integrated in.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-436) Bookies should auto register to
ZooKeeper
Posted by "Flavio Paiva Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12846853#action_12846853 ]
Flavio Paiva Junqueira commented on ZOOKEEPER-436:
--------------------------------------------------
+1 for me. It would be good if someone else could check the patch and commit it, though, since I've been the last one to update the patch.
> Bookies should auto register to ZooKeeper
> -----------------------------------------
>
> Key: ZOOKEEPER-436
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-436
> Project: Zookeeper
> Issue Type: Improvement
> Components: contrib-bookkeeper
> Reporter: Benjamin Reed
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-436.patch, ZOOKEEPER-436.patch
>
>
> currently bookies have to be manually added to ZooKeeper to be used in a BookKeeper service. we should be able to just start up a bookkie, point it at ZooKeeper, and have it get auto integrated in.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-436) Bookies should auto register to
ZooKeeper
Posted by "Erwin Tam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Erwin Tam updated ZOOKEEPER-436:
--------------------------------
Attachment: ZOOKEEPER-436.patch
Regenerating the patch from the ZooKeeper trunk instead of BookKeeper.
> Bookies should auto register to ZooKeeper
> -----------------------------------------
>
> Key: ZOOKEEPER-436
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-436
> Project: Zookeeper
> Issue Type: Improvement
> Components: contrib-bookkeeper
> Reporter: Benjamin Reed
> Attachments: ZOOKEEPER-436.patch
>
>
> currently bookies have to be manually added to ZooKeeper to be used in a BookKeeper service. we should be able to just start up a bookkie, point it at ZooKeeper, and have it get auto integrated in.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-436) Bookies should auto register to
ZooKeeper
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12846123#action_12846123 ]
Hadoop QA commented on ZOOKEEPER-436:
-------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12438961/ZOOKEEPER-436.patch
against trunk revision 922759.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
-1 patch. The patch command could not apply the patch.
Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/25/console
This message is automatically generated.
> Bookies should auto register to ZooKeeper
> -----------------------------------------
>
> Key: ZOOKEEPER-436
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-436
> Project: Zookeeper
> Issue Type: Improvement
> Components: contrib-bookkeeper
> Reporter: Benjamin Reed
> Attachments: ZOOKEEPER-436.patch
>
>
> currently bookies have to be manually added to ZooKeeper to be used in a BookKeeper service. we should be able to just start up a bookkie, point it at ZooKeeper, and have it get auto integrated in.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-436) Bookies should auto register to
ZooKeeper
Posted by "Erwin Tam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Erwin Tam updated ZOOKEEPER-436:
--------------------------------
Status: Patch Available (was: Open)
Changes so the BookieServer's main method to create Bookie's will take in an additional parameter for the String of ZooKeeper servers (comma separated string of hostname:port). This is passed to the Bookie constructor which will invoke the ZK related client instantiation and creation of the ephemeral nodes for the Bookie Server being created.
> Bookies should auto register to ZooKeeper
> -----------------------------------------
>
> Key: ZOOKEEPER-436
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-436
> Project: Zookeeper
> Issue Type: Improvement
> Components: contrib-bookkeeper
> Reporter: Benjamin Reed
> Attachments: ZOOKEEPER-436.patch
>
>
> currently bookies have to be manually added to ZooKeeper to be used in a BookKeeper service. we should be able to just start up a bookkie, point it at ZooKeeper, and have it get auto integrated in.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-436) Bookies should auto register to
ZooKeeper
Posted by "Flavio Paiva Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12846355#action_12846355 ]
Flavio Paiva Junqueira commented on ZOOKEEPER-436:
--------------------------------------------------
Thanks for the new patch, Erwin. A couple of quick comments:
# There are several formatting changes in the patch unrelated to the issue, which is distracting;
# Although the patch applies, it does not compile. I get the following compilation error, which is not difficult to fix:
{noformat}
[javac] zookeeper-apache-436/src/contrib/bookkeeper/src/java/org/apache/bookkeeper/util/LocalBookKeeper.java:136: cannot find symbol
[javac] symbol : constructor BookieServer(int,java.io.File,java.io.File[])
[javac] location: class org.apache.bookkeeper.proto.BookieServer
[javac] bs[i] = new BookieServer(initialPort + i, tmpDirs[i], new File[]{tmpDirs[i]});
{noformat}
> Bookies should auto register to ZooKeeper
> -----------------------------------------
>
> Key: ZOOKEEPER-436
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-436
> Project: Zookeeper
> Issue Type: Improvement
> Components: contrib-bookkeeper
> Reporter: Benjamin Reed
> Attachments: ZOOKEEPER-436.patch
>
>
> currently bookies have to be manually added to ZooKeeper to be used in a BookKeeper service. we should be able to just start up a bookkie, point it at ZooKeeper, and have it get auto integrated in.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-436) Bookies should auto register to
ZooKeeper
Posted by "Flavio Paiva Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Flavio Paiva Junqueira updated ZOOKEEPER-436:
---------------------------------------------
Component/s: contrib-bookkeeper
> Bookies should auto register to ZooKeeper
> -----------------------------------------
>
> Key: ZOOKEEPER-436
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-436
> Project: Zookeeper
> Issue Type: Improvement
> Components: contrib-bookkeeper
> Reporter: Benjamin Reed
>
> currently bookies have to be manually added to ZooKeeper to be used in a BookKeeper service. we should be able to just start up a bookkie, point it at ZooKeeper, and have it get auto integrated in.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-436) Bookies should auto register to
ZooKeeper
Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Reed updated ZOOKEEPER-436:
------------------------------------
Hadoop Flags: [Reviewed]
+1 great work
> Bookies should auto register to ZooKeeper
> -----------------------------------------
>
> Key: ZOOKEEPER-436
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-436
> Project: Zookeeper
> Issue Type: Improvement
> Components: contrib-bookkeeper
> Reporter: Benjamin Reed
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-436.patch, ZOOKEEPER-436.patch
>
>
> currently bookies have to be manually added to ZooKeeper to be used in a BookKeeper service. we should be able to just start up a bookkie, point it at ZooKeeper, and have it get auto integrated in.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-436) Bookies should auto register to
ZooKeeper
Posted by "Flavio Paiva Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Flavio Paiva Junqueira updated ZOOKEEPER-436:
---------------------------------------------
Status: Open (was: Patch Available)
> Bookies should auto register to ZooKeeper
> -----------------------------------------
>
> Key: ZOOKEEPER-436
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-436
> Project: Zookeeper
> Issue Type: Improvement
> Components: contrib-bookkeeper
> Reporter: Benjamin Reed
> Attachments: ZOOKEEPER-436.patch
>
>
> currently bookies have to be manually added to ZooKeeper to be used in a BookKeeper service. we should be able to just start up a bookkie, point it at ZooKeeper, and have it get auto integrated in.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-436) Bookies should auto register to
ZooKeeper
Posted by "Flavio Paiva Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Flavio Paiva Junqueira updated ZOOKEEPER-436:
---------------------------------------------
Attachment: ZOOKEEPER-436.patch
I updated Erwin's patch in the following way:
# The patch committed yesterday for ZOOKEEPER-709 generated a conflict, so I fixed it;
# One of the tests was failing for me because we were not closing the zookeeper client object when shutting down a bookie. In general it shouldn't be a problem because the ephemeral znode goes away once the session expires, but in the case of testBookieRecovery, we shut down a bookie and re-start it right away, so there isn't enough time for expiration. Consequently, I have added a line to close the zk client object if zk is not null (it can be null if no server is passes as a parameter).
> Bookies should auto register to ZooKeeper
> -----------------------------------------
>
> Key: ZOOKEEPER-436
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-436
> Project: Zookeeper
> Issue Type: Improvement
> Components: contrib-bookkeeper
> Reporter: Benjamin Reed
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-436.patch, ZOOKEEPER-436.patch
>
>
> currently bookies have to be manually added to ZooKeeper to be used in a BookKeeper service. we should be able to just start up a bookkie, point it at ZooKeeper, and have it get auto integrated in.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-436) Bookies should auto register to
ZooKeeper
Posted by "Erwin Tam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Erwin Tam updated ZOOKEEPER-436:
--------------------------------
Status: Patch Available (was: Open)
> Bookies should auto register to ZooKeeper
> -----------------------------------------
>
> Key: ZOOKEEPER-436
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-436
> Project: Zookeeper
> Issue Type: Improvement
> Components: contrib-bookkeeper
> Reporter: Benjamin Reed
> Attachments: ZOOKEEPER-436.patch
>
>
> currently bookies have to be manually added to ZooKeeper to be used in a BookKeeper service. we should be able to just start up a bookkie, point it at ZooKeeper, and have it get auto integrated in.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-436) Bookies should auto register to
ZooKeeper
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-436:
-----------------------------------
Status: Open (was: Patch Available)
> Bookies should auto register to ZooKeeper
> -----------------------------------------
>
> Key: ZOOKEEPER-436
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-436
> Project: Zookeeper
> Issue Type: Improvement
> Components: contrib-bookkeeper
> Reporter: Benjamin Reed
> Assignee: Erwin Tam
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-436.patch, ZOOKEEPER-436.patch, ZOOKEEPER-436.patch
>
>
> currently bookies have to be manually added to ZooKeeper to be used in a BookKeeper service. we should be able to just start up a bookkie, point it at ZooKeeper, and have it get auto integrated in.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-436) Bookies should auto register to
ZooKeeper
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12847814#action_12847814 ]
Hudson commented on ZOOKEEPER-436:
----------------------------------
Integrated in ZooKeeper-trunk #763 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/763/])
> Bookies should auto register to ZooKeeper
> -----------------------------------------
>
> Key: ZOOKEEPER-436
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-436
> Project: Zookeeper
> Issue Type: Improvement
> Components: contrib-bookkeeper
> Reporter: Benjamin Reed
> Assignee: Erwin Tam
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-436.patch, ZOOKEEPER-436.patch, ZOOKEEPER-436.patch
>
>
> currently bookies have to be manually added to ZooKeeper to be used in a BookKeeper service. we should be able to just start up a bookkie, point it at ZooKeeper, and have it get auto integrated in.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-436) Bookies should auto register to
ZooKeeper
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12847054#action_12847054 ]
Hadoop QA commented on ZOOKEEPER-436:
-------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12439196/ZOOKEEPER-436.patch
against trunk revision 924655.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 12 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/142/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/142/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/142/console
This message is automatically generated.
> Bookies should auto register to ZooKeeper
> -----------------------------------------
>
> Key: ZOOKEEPER-436
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-436
> Project: Zookeeper
> Issue Type: Improvement
> Components: contrib-bookkeeper
> Reporter: Benjamin Reed
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-436.patch, ZOOKEEPER-436.patch, ZOOKEEPER-436.patch
>
>
> currently bookies have to be manually added to ZooKeeper to be used in a BookKeeper service. we should be able to just start up a bookkie, point it at ZooKeeper, and have it get auto integrated in.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-436) Bookies should auto register to
ZooKeeper
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12847245#action_12847245 ]
Hadoop QA commented on ZOOKEEPER-436:
-------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12439196/ZOOKEEPER-436.patch
against trunk revision 924942.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 12 new or modified tests.
-1 patch. The patch command could not apply the patch.
Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/32/console
This message is automatically generated.
> Bookies should auto register to ZooKeeper
> -----------------------------------------
>
> Key: ZOOKEEPER-436
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-436
> Project: Zookeeper
> Issue Type: Improvement
> Components: contrib-bookkeeper
> Reporter: Benjamin Reed
> Assignee: Erwin Tam
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-436.patch, ZOOKEEPER-436.patch, ZOOKEEPER-436.patch
>
>
> currently bookies have to be manually added to ZooKeeper to be used in a BookKeeper service. we should be able to just start up a bookkie, point it at ZooKeeper, and have it get auto integrated in.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-436) Bookies should auto register to
ZooKeeper
Posted by "Flavio Paiva Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Flavio Paiva Junqueira updated ZOOKEEPER-436:
---------------------------------------------
Status: Open (was: Patch Available)
> Bookies should auto register to ZooKeeper
> -----------------------------------------
>
> Key: ZOOKEEPER-436
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-436
> Project: Zookeeper
> Issue Type: Improvement
> Components: contrib-bookkeeper
> Reporter: Benjamin Reed
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-436.patch, ZOOKEEPER-436.patch, ZOOKEEPER-436.patch
>
>
> currently bookies have to be manually added to ZooKeeper to be used in a BookKeeper service. we should be able to just start up a bookkie, point it at ZooKeeper, and have it get auto integrated in.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-436) Bookies should auto register to
ZooKeeper
Posted by "Erwin Tam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Erwin Tam updated ZOOKEEPER-436:
--------------------------------
Attachment: (was: ZOOKEEPER-436.patch)
> Bookies should auto register to ZooKeeper
> -----------------------------------------
>
> Key: ZOOKEEPER-436
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-436
> Project: Zookeeper
> Issue Type: Improvement
> Components: contrib-bookkeeper
> Reporter: Benjamin Reed
>
> currently bookies have to be manually added to ZooKeeper to be used in a BookKeeper service. we should be able to just start up a bookkie, point it at ZooKeeper, and have it get auto integrated in.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-436) Bookies should auto register to
ZooKeeper
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12846834#action_12846834 ]
Hadoop QA commented on ZOOKEEPER-436:
-------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12439141/ZOOKEEPER-436.patch
against trunk revision 924655.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 12 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/141/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/141/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/141/console
This message is automatically generated.
> Bookies should auto register to ZooKeeper
> -----------------------------------------
>
> Key: ZOOKEEPER-436
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-436
> Project: Zookeeper
> Issue Type: Improvement
> Components: contrib-bookkeeper
> Reporter: Benjamin Reed
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-436.patch, ZOOKEEPER-436.patch
>
>
> currently bookies have to be manually added to ZooKeeper to be used in a BookKeeper service. we should be able to just start up a bookkie, point it at ZooKeeper, and have it get auto integrated in.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (ZOOKEEPER-436) Bookies should auto register to
ZooKeeper
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar reassigned ZOOKEEPER-436:
---------------------------------------
Assignee: Erwin Tam
> Bookies should auto register to ZooKeeper
> -----------------------------------------
>
> Key: ZOOKEEPER-436
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-436
> Project: Zookeeper
> Issue Type: Improvement
> Components: contrib-bookkeeper
> Reporter: Benjamin Reed
> Assignee: Erwin Tam
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-436.patch, ZOOKEEPER-436.patch, ZOOKEEPER-436.patch
>
>
> currently bookies have to be manually added to ZooKeeper to be used in a BookKeeper service. we should be able to just start up a bookkie, point it at ZooKeeper, and have it get auto integrated in.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-436) Bookies should auto register to
ZooKeeper
Posted by "Erwin Tam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Erwin Tam updated ZOOKEEPER-436:
--------------------------------
Attachment: (was: ZOOKEEPER-436.patch)
> Bookies should auto register to ZooKeeper
> -----------------------------------------
>
> Key: ZOOKEEPER-436
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-436
> Project: Zookeeper
> Issue Type: Improvement
> Components: contrib-bookkeeper
> Reporter: Benjamin Reed
> Attachments: ZOOKEEPER-436.patch
>
>
> currently bookies have to be manually added to ZooKeeper to be used in a BookKeeper service. we should be able to just start up a bookkie, point it at ZooKeeper, and have it get auto integrated in.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-436) Bookies should auto register to
ZooKeeper
Posted by "Erwin Tam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Erwin Tam updated ZOOKEEPER-436:
--------------------------------
Attachment: ZOOKEEPER-436.patch
SVN Diff of two files modified for this Jira:
BookieServer.java and Bookie.java
> Bookies should auto register to ZooKeeper
> -----------------------------------------
>
> Key: ZOOKEEPER-436
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-436
> Project: Zookeeper
> Issue Type: Improvement
> Components: contrib-bookkeeper
> Reporter: Benjamin Reed
> Attachments: ZOOKEEPER-436.patch
>
>
> currently bookies have to be manually added to ZooKeeper to be used in a BookKeeper service. we should be able to just start up a bookkie, point it at ZooKeeper, and have it get auto integrated in.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-436) Bookies should auto register to
ZooKeeper
Posted by "Erwin Tam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Erwin Tam updated ZOOKEEPER-436:
--------------------------------
Attachment: ZOOKEEPER-436.patch
Updated patch making the changes to fix the unit tests. Also made the changes without making the formatting changes done before.
> Bookies should auto register to ZooKeeper
> -----------------------------------------
>
> Key: ZOOKEEPER-436
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-436
> Project: Zookeeper
> Issue Type: Improvement
> Components: contrib-bookkeeper
> Reporter: Benjamin Reed
> Attachments: ZOOKEEPER-436.patch
>
>
> currently bookies have to be manually added to ZooKeeper to be used in a BookKeeper service. we should be able to just start up a bookkie, point it at ZooKeeper, and have it get auto integrated in.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-436) Bookies should auto register to
ZooKeeper
Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Reed updated ZOOKEEPER-436:
------------------------------------
Status: Patch Available (was: Open)
> Bookies should auto register to ZooKeeper
> -----------------------------------------
>
> Key: ZOOKEEPER-436
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-436
> Project: Zookeeper
> Issue Type: Improvement
> Components: contrib-bookkeeper
> Reporter: Benjamin Reed
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-436.patch, ZOOKEEPER-436.patch, ZOOKEEPER-436.patch
>
>
> currently bookies have to be manually added to ZooKeeper to be used in a BookKeeper service. we should be able to just start up a bookkie, point it at ZooKeeper, and have it get auto integrated in.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.