[GitHub] [spark] cfmcgrady commented on a change in pull request #32841: [SPARK-35673][SQL] Fix user-defined hint and unrecognized hint in subquery.

[GitBox <gi...@apache.org>]

cfmcgrady commented on a change in pull request #32841:
URL: https://github.com/apache/spark/pull/32841#discussion_r648812700



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/hints.scala
##########
@@ -30,7 +30,8 @@ import org.apache.spark.sql.catalyst.trees.TreePattern.{TreePattern, UNRESOLVED_
 case class UnresolvedHint(name: String, parameters: Seq[Any], child: LogicalPlan)
   extends UnaryNode {
 
-  override lazy val resolved: Boolean = false
+  override lazy val resolved: Boolean = child.resolved

Review comment:
       It's ok for me to add this check. 
   And note that in the build-in analyzer, all of `UnresolvedHint` will be removed by batch `Remove Unresolved Hints`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org