You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/03/02 02:45:56 UTC

[GitHub] [incubator-shardingsphere] KomachiSion opened a new pull request #4551: Format naming in sharding-scaling-mysql module

KomachiSion opened a new pull request #4551: Format naming in sharding-scaling-mysql module
URL: https://github.com/apache/incubator-shardingsphere/pull/4551
 
 
   For #4510 .
   
   Changes proposed in this pull request:
   - Format class naming.
   - Replace lombon.Data annotation with Setter and Getter
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls commented on issue #4551: Format naming in sharding-scaling-mysql module

Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #4551: Format naming in sharding-scaling-mysql module
URL: https://github.com/apache/incubator-shardingsphere/pull/4551#issuecomment-593198913
 
 
   ## Pull Request Test Coverage Report for [Build 9929](https://coveralls.io/builds/29062429)
   
   * **29** of **30**   **(96.67%)**  changed or added relevant lines in **7** files are covered.
   * No unchanged relevant lines lost coverage.
   * Overall coverage increased (+**0.03%**) to **59.995%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [sharding-scaling/sharding-scaling-mysql/src/main/java/org/apache/shardingsphere/shardingscaling/mysql/BinlogPosition.java](https://coveralls.io/builds/29062429/source?filename=sharding-scaling%2Fsharding-scaling-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fmysql%2FBinlogPosition.java#L30) | 0 | 1 | 0.0%
   <!-- | **Total:** | **29** | **30** | **96.67%** | -->
   
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/29062429/badge)](https://coveralls.io/builds/29062429) |
   | :-- | --: |
   | Change from base [Build 9871](https://coveralls.io/builds/29043279): |  0.03% |
   | Covered Lines: | 12560 |
   | Relevant Lines: | 20935 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4551: Format naming in sharding-scaling-mysql module

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4551: Format naming in sharding-scaling-mysql module
URL: https://github.com/apache/incubator-shardingsphere/pull/4551#issuecomment-593198913
 
 
   ## Pull Request Test Coverage Report for [Build 36](https://coveralls.io/builds/29062432)
   
   * **29** of **30**   **(96.67%)**  changed or added relevant lines in **7** files are covered.
   * **2** unchanged lines in **1** file lost coverage.
   * Overall coverage increased (+**0.04%**) to **60.005%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [sharding-scaling/sharding-scaling-mysql/src/main/java/org/apache/shardingsphere/shardingscaling/mysql/BinlogPosition.java](https://coveralls.io/builds/29062432/source?filename=sharding-scaling%2Fsharding-scaling-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fmysql%2FBinlogPosition.java#L30) | 0 | 1 | 0.0%
   <!-- | **Total:** | **29** | **30** | **96.67%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java](https://coveralls.io/builds/29062432/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Futil%2FIpUtils.java#L72) | 2 | 80.0% |
   <!-- | **Total:** | **2** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/29062432/badge)](https://coveralls.io/builds/29062432) |
   | :-- | --: |
   | Change from base [Build 9871](https://coveralls.io/builds/29043279): |  0.04% |
   | Covered Lines: | 12562 |
   | Relevant Lines: | 20935 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] tristaZero merged pull request #4551: Format naming in sharding-scaling-mysql module

Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #4551: Format naming in sharding-scaling-mysql module
URL: https://github.com/apache/incubator-shardingsphere/pull/4551
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services