[GitHub] [spark] ulysses-you commented on a change in pull request #33899: [SPARK-36652][SQL] AQE dynamic join selection should not apply to non-equi join

[GitBox <gi...@apache.org>]

ulysses-you commented on a change in pull request #33899:
URL: https://github.com/apache/spark/pull/33899#discussion_r701192056



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala
##########
@@ -169,7 +169,8 @@ abstract class SparkStrategies extends QueryPlanner[SparkPlan] {
     }
 
     private def checkHintNonEquiJoin(hint: JoinHint): Unit = {
-      if (hintToShuffleHashJoin(hint) || hintToSortMergeJoin(hint)) {
+      if (hintToShuffleHashJoin(hint) || hintToPreferShuffleHashJoin(hint) ||
+        hintToSortMergeJoin(hint)) {

Review comment:
       `PreferShuffleHashJoin` is an internal hint so user cann't use it, we don't need do this check




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org