You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by jaydoane <gi...@git.apache.org> on 2016/01/21 06:01:39 UTC

[GitHub] couchdb-config pull request: Don't start lager during setup for ea...

Github user jaydoane commented on the pull request:

    https://github.com/apache/couchdb-config/pull/7#issuecomment-173451479
  
    Interestingly, I'm no longer able to reproduce the `[error] Undefined` errors, although I *am* seeing a lot more logging than before for some reason.
    
    @kxepal, are you still getting those errors with this simplified patch? Or even why the logging has returned in test output?
    
    ```
    (18.2.1)jay@mbp:~/proj/couchdb$ make eunit apps=config skip_deps+=couch_log,couch_epi
    ==> couch_epi (compile)
    ==> config (compile)
    ==> b64url (compile)
    ==> cassim (compile)
    ==> meck (compile)
    ==> couch_log (compile)
    ==> lager (compile)
    ==> couch_log_lager (compile)
    ==> chttpd (compile)
    ==> couch (compile)
    ==> couch_index (compile)
    ==> couch_mrview (compile)
    ==> couch_replicator (compile)
    ==> couch_plugins (compile)
    ==> couch_event (compile)
    ==> couch_stats (compile)
    ==> couch_peruser (compile)
    ==> ddoc_cache (compile)
    ==> ets_lru (compile)
    ==> fabric (compile)
    ==> bear (compile)
    ==> folsom (compile)
    ==> global_changes (compile)
    ==> goldrush (compile)
    ==> ibrowse (compile)
    ==> ioq (compile)
    ==> jiffy (compile)
    ==> khash (compile)
    ==> mango (compile)
    ==> mem3 (compile)
    ==> mochiweb (compile)
    ==> oauth (compile)
    ==> rexi (compile)
    ==> snappy (compile)
    ==> setup (compile)
    ==> rel (compile)
    ==> couchdb (compile)
    ==> couchdb (setup_eunit)
    ==> config (eunit)
    ======================== EUnit ========================
    module 'config_writer'
    module 'config_util'
    module 'config_sup'
    module 'config_listener'
    module 'config_app'
    module 'config'
      config: to_integer_test...ok
      config: to_float_test...ok
      module 'config_tests'
        CouchDB config tests
          Config get tests
            config_tests:220: should_load_all_configs...ok
            config_tests:223: should_locate_daemons_section...ok
            config_tests:226: should_locate_mrview_handler...ok
            config_tests:230: should_return_undefined_atom_on_missed_section...ok
            config_tests:234: should_return_undefined_atom_on_missed_option...ok
            config_tests:238: should_return_custom_default_value_on_missed_option...ok
            config_tests:242: should_only_return_default_on_missed_option...ok
            config_tests:246: should_fail_to_get_binary_value...ok
            config_tests:253: should_return_any_supported_default (for type(undefined))...ok
            config_tests:253: should_return_any_supported_default (for type("list"))...ok
            config_tests:253: should_return_any_supported_default (for type(true))...ok
            config_tests:253: should_return_any_supported_default (for type(false))...ok
            config_tests:253: should_return_any_supported_default (for type(0.1))...ok
            config_tests:253: should_return_any_supported_default (for type(1))...ok
            [done in 0.427 s]
          Config set tests
            config_tests:257: should_update_option...[notice] config: [log] level set to severe for reason nil
    [0.012 s] ok
    [notice] config_listener(couch_log_config_listener) stopped with reason: shutdown
    
            config_tests:264: should_create_new_section...[0.001 s] ok
            config_tests:272: should_fail_to_set_binary_value...ok
            [done in 0.079 s]
          Config deletion tests
            [notice] config: [log] level deleted for reason nil
    config_tests:276: should_return_undefined_atom_after_option_deletion...ok
    [notice] config_listener(couch_log_config_listener) stopped with reason: shutdown
    
            config_tests:283: should_be_ok_on_deleting_unknown_options...ok
            [done in 0.046 s]
          Configs overide tests
            config_tests:286: should_ensure_in_defaults...ok
    [notice] config_listener(couch_log_config_listener) stopped with reason: shutdown
    
            config_tests:296: should_override_options...ok
    [notice] config_listener(couch_log_config_listener) stopped with reason: shutdown
    
            config_tests:304: should_create_new_sections_on_override...ok
    [notice] config_listener(couch_log_config_listener) stopped with reason: shutdown
    
            config_tests:312: should_win_last_in_chain...ok
    [notice] config_listener(couch_log_config_listener) stopped with reason: shutdown
    
            [done in 0.081 s]
          Config persistent changes
    [notice] config: [httpd] port set to 8080 for reason nil
            config_tests:315: should_write_changes...[notice] config: [httpd] bind_address deleted for reason "8080"
    [0.001 s] ok
    [notice] config_listener(couch_log_config_listener) stopped with reason: shutdown
    
            config_tests:329: should_ensure_that_default_wasnt_modified...ok
    [notice] config_listener(couch_log_config_listener) stopped with reason: shutdown
    
            config_tests:337: should_ensure_that_written_to_last_config_in_chain...ok
    [notice] config_listener(couch_log_config_listener) stopped with reason: shutdown
    
            [done in 0.056 s]
          Test config with no files
            config_tests:345: should_ensure_that_no_ini_files_loaded...ok
    [notice] config_listener(couch_log_config_listener) stopped with reason: shutdown
    
    [notice] config: [httpd] port set to 80 for reason nil
            config_tests:348: should_create_non_persistent_option...ok
    [notice] config_listener(couch_log_config_listener) stopped with reason: shutdown
    
    [notice] config: [httpd] bind_address set to 127.0.0.1 for reason nil
            config_tests:355: should_create_persistent_option...ok
    [notice] config_listener(couch_log_config_listener) stopped with reason: shutdown
    
            [done in 0.038 s]
          Test config_listener behaviour
            config_tests:362: should_handle_value_change...ok
            config_tests:367: should_pass_correct_state_to_handle_config_change...ok
            config_tests:374: should_pass_correct_state_to_handle_config_terminate...ok
            config_tests:391: should_pass_subscriber_pid_to_handle_config_terminate...ok
            config_tests:400: should_not_call_handle_config_after_related_process_death...ok
            config_tests:409: should_remove_handler_when_requested...ok
            [done in 2.140 s]
          [done in 2.868 s]
        [done in 2.868 s]
      [done in 2.893 s]
    =======================================================
      All 37 tests passed.
    ==> rel (eunit)
    ==> couchdb (eunit)
    WARN:  'suites' command does not apply to directory /Users/jay/proj/couchdb/src/config
    WARN:  'suites' command does not apply to directory /Users/jay/proj/couchdb/rel
    WARN:  'suites' command does not apply to directory /Users/jay/proj/couchdb
    WARN:  'tests' command does not apply to directory /Users/jay/proj/couchdb/src/config
    WARN:  'tests' command does not apply to directory /Users/jay/proj/couchdb/rel
    WARN:  'tests' command does not apply to directory /Users/jay/proj/couchdb
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---