You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by "craigcondit (via GitHub)" <gi...@apache.org> on 2023/01/26 22:01:31 UTC
[GitHub] [yunikorn-k8shim] craigcondit opened a new pull request, #517: [YUNIKORN-1547] Use Pending instead of QuotaApproved status for ready to schedule
craigcondit opened a new pull request, #517:
URL: https://github.com/apache/yunikorn-k8shim/pull/517
### What is this PR for?
The plugin mode currently uses a custom pod status of QuotaApproved, which can cause some issues with third-party tooling. Instead, we should use Pending.
### What type of PR is it?
* [x] - Bug Fix
* [ ] - Improvement
* [ ] - Feature
* [ ] - Documentation
* [ ] - Hot Fix
* [ ] - Refactoring
### Todos
* [ ] - Task
### What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-1547
### How should this be tested?
E2e tests continue to run.
### Screenshots (if appropriate)
### Questions:
* [ ] - The licenses files need update.
* [ ] - There is breaking changes for older versions.
* [ ] - It needs documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] craigcondit closed pull request #517: [YUNIKORN-1547] Use Pending instead of QuotaApproved status for ready to schedule
Posted by "craigcondit (via GitHub)" <gi...@apache.org>.
craigcondit closed pull request #517: [YUNIKORN-1547] Use Pending instead of QuotaApproved status for ready to schedule
URL: https://github.com/apache/yunikorn-k8shim/pull/517
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] codecov[bot] commented on pull request #517: [YUNIKORN-1547] Use Pending instead of QuotaApproved status for ready to schedule
Posted by codecov.
codecov[bot] commented on PR #517:
URL: https://github.com/apache/yunikorn-k8shim/pull/517#issuecomment-1405740527
# [Codecov](https://codecov.io/gh/apache/yunikorn-k8shim/pull/517?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#517](https://codecov.io/gh/apache/yunikorn-k8shim/pull/517?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4679cf7) into [master](https://codecov.io/gh/apache/yunikorn-k8shim/commit/a241478937ecfaa77783596025546bb0142bd73b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a241478) will **not change** coverage.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #517 +/- ##
=======================================
Coverage 69.41% 69.41%
=======================================
Files 45 45
Lines 7714 7714
=======================================
Hits 5355 5355
Misses 2162 2162
Partials 197 197
```
| [Impacted Files](https://codecov.io/gh/apache/yunikorn-k8shim/pull/517?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/cache/task.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/517?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NhY2hlL3Rhc2suZ28=) | `67.80% <0.00%> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org