You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Rush Manbert (JIRA)" <ji...@apache.org> on 2009/04/14 00:18:14 UTC

[jira] Created: (THRIFT-457) test/cpp makefiles do not honor --prefix configuration setting

test/cpp makefiles do not honor --prefix configuration setting
--------------------------------------------------------------

                 Key: THRIFT-457
                 URL: https://issues.apache.org/jira/browse/THRIFT-457
             Project: Thrift
          Issue Type: Bug
          Components: Test Suite
    Affects Versions: 0.1
         Environment: All
            Reporter: Rush Manbert


The test/cpp/Stress-test.mk and test/cpp/Thrift-test.mk makefiles do not use the include or library paths defined by the --prefix configuration parameter. This makes the test program builds fail because header files and libraries (once you fix the header paths) cannot be found.

I cannot provide a patch because I don't know how to make this change, other than by editing the makefiles in my source tree. I'm sure there's some automake way to fix this.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (THRIFT-457) test/cpp makefiles do not honor --prefix configuration setting

Posted by "Rush Manbert (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12698579#action_12698579 ] 

Rush Manbert commented on THRIFT-457:
-------------------------------------

Which source tree? Boost? You don't know where it is. And you don't know where my libevent.a is located either.

Perhaps these should be created by automake?

> test/cpp makefiles do not honor --prefix configuration setting
> --------------------------------------------------------------
>
>                 Key: THRIFT-457
>                 URL: https://issues.apache.org/jira/browse/THRIFT-457
>             Project: Thrift
>          Issue Type: Bug
>          Components: Test Suite
>    Affects Versions: 0.1
>         Environment: All
>            Reporter: Rush Manbert
>
> The test/cpp/Stress-test.mk and test/cpp/Thrift-test.mk makefiles do not use the include or library paths defined by the --prefix configuration parameter. This makes the test program builds fail because header files and libraries (once you fix the header paths) cannot be found.
> I cannot provide a patch because I don't know how to make this change, other than by editing the makefiles in my source tree. I'm sure there's some automake way to fix this.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (THRIFT-457) test/cpp makefiles do not honor --prefix configuration setting

Posted by "Rush Manbert (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12901214#action_12901214 ] 

Rush Manbert commented on THRIFT-457:
-------------------------------------

A recent comment on Jira-503 mentioned working on this incident. I should mention that my 591 patch, when applied to the Unix distro, fixes this problem, so the changes I had to make down in the test directories and their makefiles could probably be extracted and made into a separate patch.

> test/cpp makefiles do not honor --prefix configuration setting
> --------------------------------------------------------------
>
>                 Key: THRIFT-457
>                 URL: https://issues.apache.org/jira/browse/THRIFT-457
>             Project: Thrift
>          Issue Type: Bug
>          Components: Test Suite
>    Affects Versions: 0.1
>         Environment: All
>            Reporter: Rush Manbert
>
> The test/cpp/Stress-test.mk and test/cpp/Thrift-test.mk makefiles do not use the include or library paths defined by the --prefix configuration parameter. This makes the test program builds fail because header files and libraries (once you fix the header paths) cannot be found.
> I cannot provide a patch because I don't know how to make this change, other than by editing the makefiles in my source tree. I'm sure there's some automake way to fix this.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (THRIFT-457) test/cpp makefiles do not honor --prefix configuration setting

Posted by "David Reiss (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12698573#action_12698573 ] 

David Reiss commented on THRIFT-457:
------------------------------------

Those files are not generated by automake.  They should probably point into the source tree, rather than to the installed location.

> test/cpp makefiles do not honor --prefix configuration setting
> --------------------------------------------------------------
>
>                 Key: THRIFT-457
>                 URL: https://issues.apache.org/jira/browse/THRIFT-457
>             Project: Thrift
>          Issue Type: Bug
>          Components: Test Suite
>    Affects Versions: 0.1
>         Environment: All
>            Reporter: Rush Manbert
>
> The test/cpp/Stress-test.mk and test/cpp/Thrift-test.mk makefiles do not use the include or library paths defined by the --prefix configuration parameter. This makes the test program builds fail because header files and libraries (once you fix the header paths) cannot be found.
> I cannot provide a patch because I don't know how to make this change, other than by editing the makefiles in my source tree. I'm sure there's some automake way to fix this.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (THRIFT-457) test/cpp makefiles do not honor --prefix configuration setting

Posted by "David Reiss (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12698580#action_12698580 ] 

David Reiss commented on THRIFT-457:
------------------------------------

Yeah, that would probably be an improvement.

> test/cpp makefiles do not honor --prefix configuration setting
> --------------------------------------------------------------
>
>                 Key: THRIFT-457
>                 URL: https://issues.apache.org/jira/browse/THRIFT-457
>             Project: Thrift
>          Issue Type: Bug
>          Components: Test Suite
>    Affects Versions: 0.1
>         Environment: All
>            Reporter: Rush Manbert
>
> The test/cpp/Stress-test.mk and test/cpp/Thrift-test.mk makefiles do not use the include or library paths defined by the --prefix configuration parameter. This makes the test program builds fail because header files and libraries (once you fix the header paths) cannot be found.
> I cannot provide a patch because I don't know how to make this change, other than by editing the makefiles in my source tree. I'm sure there's some automake way to fix this.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.