You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "fpoms (via GitHub)" <gi...@apache.org> on 2023/03/08 22:06:12 UTC
[GitHub] [arrow] fpoms opened a new pull request, #34507: MINOR: [docs] Include `writer.close()` at end of `with ... as writer` calls.
fpoms opened a new pull request, #34507:
URL: https://github.com/apache/arrow/pull/34507
### Rationale for this change
The guide currently doesn't specify that the `writer.close()` method must be called to complete a file write. This change adds that.
### What changes are included in this PR?
Adds `writer.close()` to the python IPC documentation code examples.
### Are these changes tested?
No tests because this is a change in the documentation.
### Are there any user-facing changes?
No, this is a documentation change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorisvandenbossche commented on a diff in pull request #34507: MINOR: [docs] Include `writer.close()` at end of `with ... as writer` calls.
Posted by "jorisvandenbossche (via GitHub)" <gi...@apache.org>.
jorisvandenbossche commented on code in PR #34507:
URL: https://github.com/apache/arrow/pull/34507#discussion_r1130566089
##########
docs/source/python/ipc.rst:
##########
@@ -80,6 +80,7 @@ this one can be created with :func:`~pyarrow.ipc.new_stream`:
with pa.ipc.new_stream(sink, batch.schema) as writer:
for i in range(5):
writer.write_batch(batch)
+ writer.close()
Review Comment:
I think that exiting from the context should call this automatically? (that could also be mentioned in the text to make this explicit)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] amol- commented on pull request #34507: MINOR: [docs] Include `writer.close()` at end of `with ... as writer` calls.
Posted by "amol- (via GitHub)" <gi...@apache.org>.
amol- commented on PR #34507:
URL: https://github.com/apache/arrow/pull/34507#issuecomment-1490666638
Closing because it has been untouched for a while, in case it's still relevant feel free to reopen and move it forward 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] amol- closed pull request #34507: MINOR: [docs] Include `writer.close()` at end of `with ... as writer` calls.
Posted by "amol- (via GitHub)" <gi...@apache.org>.
amol- closed pull request #34507: MINOR: [docs] Include `writer.close()` at end of `with ... as writer` calls.
URL: https://github.com/apache/arrow/pull/34507
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org