You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Daniel Pravat <dp...@outlook.com> on 2015/12/01 22:06:28 UTC

Re: Review Request 40115: Windows: Added support for `slave/gc.cpp'.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40115/
-----------------------------------------------------------

(Updated Dec. 1, 2015, 9:06 p.m.)


Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Joseph Wu.


Repository: mesos


Description
-------

Windows: Added support for `slave/gc.cpp'.


Diffs (updated)
-----

  src/CMakeLists.txt cfe9d26c45ba42852fd1af958549954e7b04d448 
  src/slave/gc.cpp 7a8c69b4410df46ca8fd6ac009cc14e8fe5ff6d3 

Diff: https://reviews.apache.org/r/40115/diff/


Testing
-------

Windows 10: make.bat
OSX: make check
Ubuntu: 15.1 make check


Thanks,

Daniel Pravat

Re: Review Request 40115: Windows: Added support for `slave/gc.cpp'.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40115/#review108597
-----------------------------------------------------------


Bad patch!

Reviews applied: [40114, 39537, 39538, 39539, 39540, 39541, 39383, 39559, 39219]

Failed command: ./support/apply-review.sh -n -r 39219

Error:
 2015-12-02 02:20:21 URL:https://reviews.apache.org/r/39219/diff/raw/ [3137/3137] -> "39219.patch" [1]
error: patch failed: src/slave/state.cpp:16
error: src/slave/state.cpp: patch does not apply
Failed to apply patch

- Mesos ReviewBot


On Dec. 1, 2015, 9:06 p.m., Daniel Pravat wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40115/
> -----------------------------------------------------------
> 
> (Updated Dec. 1, 2015, 9:06 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Windows: Added support for `slave/gc.cpp'.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt cfe9d26c45ba42852fd1af958549954e7b04d448 
>   src/slave/gc.cpp 7a8c69b4410df46ca8fd6ac009cc14e8fe5ff6d3 
> 
> Diff: https://reviews.apache.org/r/40115/diff/
> 
> 
> Testing
> -------
> 
> Windows 10: make.bat
> OSX: make check
> Ubuntu: 15.1 make check
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>

Re: Review Request 40115: Windows: Added support for `slave/gc.cpp`.

Posted by Daniel Pravat <dp...@outlook.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40115/
-----------------------------------------------------------

(Updated Jan. 14, 2016, 1:15 a.m.)


Review request for Alex Naparu and Alex Clemmer.


Summary (updated)
-----------------

Windows: Added support for `slave/gc.cpp`.


Repository: mesos


Description (updated)
-------

Windows: Added support for `slave/gc.cpp`.


Diffs
-----

  src/CMakeLists.txt 0d46043dd06007f2cba56626c82e8edd251cb8fb 
  src/slave/gc.cpp 7a8c69b4410df46ca8fd6ac009cc14e8fe5ff6d3 

Diff: https://reviews.apache.org/r/40115/diff/


Testing
-------

Windows 10: make.bat
OSX: make check
Ubuntu: 15.1 make check


Thanks,

Daniel Pravat

Re: Review Request 40115: Windows: Added support for `slave/gc.cpp'.

Posted by Daniel Pravat <dp...@outlook.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40115/
-----------------------------------------------------------

(Updated Dec. 23, 2015, 7:22 a.m.)


Review request for Alex Naparu and Alex Clemmer.


Repository: mesos


Description
-------

Windows: Added support for `slave/gc.cpp'.


Diffs (updated)
-----

  src/CMakeLists.txt 0d46043dd06007f2cba56626c82e8edd251cb8fb 
  src/slave/gc.cpp 7a8c69b4410df46ca8fd6ac009cc14e8fe5ff6d3 

Diff: https://reviews.apache.org/r/40115/diff/


Testing
-------

Windows 10: make.bat
OSX: make check
Ubuntu: 15.1 make check


Thanks,

Daniel Pravat

Re: Review Request 40115: Windows: Added support for `slave/gc.cpp'.

Posted by Daniel Pravat <dp...@outlook.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40115/
-----------------------------------------------------------

(Updated Dec. 22, 2015, 7:32 a.m.)


Review request for Alex Naparu and Alex Clemmer.


Repository: mesos


Description
-------

Windows: Added support for `slave/gc.cpp'.


Diffs (updated)
-----

  src/CMakeLists.txt 0d46043dd06007f2cba56626c82e8edd251cb8fb 
  src/slave/gc.cpp 7a8c69b4410df46ca8fd6ac009cc14e8fe5ff6d3 

Diff: https://reviews.apache.org/r/40115/diff/


Testing
-------

Windows 10: make.bat
OSX: make check
Ubuntu: 15.1 make check


Thanks,

Daniel Pravat