You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2020/02/21 10:52:39 UTC
[GitHub] [activemq-artemis] brusdev opened a new pull request #2990:
ARTEMIS-2627 simpleSecureServer failing on IBM JDK 8
brusdev opened a new pull request #2990: ARTEMIS-2627 simpleSecureServer failing on IBM JDK 8
URL: https://github.com/apache/activemq-artemis/pull/2990
Remove excluded cipher suites matching the prefix `SSL` because the names of the
IBM JDK 8 cipher suites have the prefix `SSL` while the
`DEFAULT_EXCLUDED_CIPHER_SUITES` of org.eclipse.jetty.util.ssl.SslContextFactory
includes "^SSL_.*$". So all IBM JDK cipher suites are excluded by
SslContextFactory using the `DEFAULT_EXCLUDED_CIPHER_SUITES`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] asfgit closed pull request #2990: ARTEMIS-2627
simpleSecureServer failing on IBM JDK 8
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #2990: ARTEMIS-2627 simpleSecureServer failing on IBM JDK 8
URL: https://github.com/apache/activemq-artemis/pull/2990
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] brusdev commented on a change in pull request
#2990: ARTEMIS-2627 simpleSecureServer failing on IBM JDK 8
Posted by GitBox <gi...@apache.org>.
brusdev commented on a change in pull request #2990: ARTEMIS-2627 simpleSecureServer failing on IBM JDK 8
URL: https://github.com/apache/activemq-artemis/pull/2990#discussion_r382910252
##########
File path: artemis-web/src/main/java/org/apache/activemq/artemis/component/WebServerComponent.java
##########
@@ -72,6 +74,11 @@ public void configure(ComponentDTO config, String artemisInstance, String artemi
SslContextFactory.Server sslFactory = new SslContextFactory.Server();
sslFactory.setKeyStorePath(webServerConfig.keyStorePath == null ? artemisInstance + "/etc/keystore.jks" : webServerConfig.keyStorePath);
sslFactory.setKeyStorePassword(webServerConfig.getKeyStorePassword() == null ? "password" : webServerConfig.getKeyStorePassword());
+ sslFactory.setIncludeProtocols("TLSv1.2");
Review comment:
I added some parameters to the WebServerDTO so the test can configure them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] jbertram commented on a change in pull request
#2990: ARTEMIS-2627 simpleSecureServer failing on IBM JDK 8
Posted by GitBox <gi...@apache.org>.
jbertram commented on a change in pull request #2990: ARTEMIS-2627 simpleSecureServer failing on IBM JDK 8
URL: https://github.com/apache/activemq-artemis/pull/2990#discussion_r382701110
##########
File path: artemis-web/src/main/java/org/apache/activemq/artemis/component/WebServerComponent.java
##########
@@ -72,6 +74,11 @@ public void configure(ComponentDTO config, String artemisInstance, String artemi
SslContextFactory.Server sslFactory = new SslContextFactory.Server();
sslFactory.setKeyStorePath(webServerConfig.keyStorePath == null ? artemisInstance + "/etc/keystore.jks" : webServerConfig.keyStorePath);
sslFactory.setKeyStorePassword(webServerConfig.getKeyStorePassword() == null ? "password" : webServerConfig.getKeyStorePassword());
+ sslFactory.setIncludeProtocols("TLSv1.2");
Review comment:
I'm concerned about changing the default here for all cases. This should probably be made configurable and then the test can configure it as necessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] jbertram commented on a change in pull request
#2990: ARTEMIS-2627 simpleSecureServer failing on IBM JDK 8
Posted by GitBox <gi...@apache.org>.
jbertram commented on a change in pull request #2990: ARTEMIS-2627 simpleSecureServer failing on IBM JDK 8
URL: https://github.com/apache/activemq-artemis/pull/2990#discussion_r382701110
##########
File path: artemis-web/src/main/java/org/apache/activemq/artemis/component/WebServerComponent.java
##########
@@ -72,6 +74,11 @@ public void configure(ComponentDTO config, String artemisInstance, String artemi
SslContextFactory.Server sslFactory = new SslContextFactory.Server();
sslFactory.setKeyStorePath(webServerConfig.keyStorePath == null ? artemisInstance + "/etc/keystore.jks" : webServerConfig.keyStorePath);
sslFactory.setKeyStorePassword(webServerConfig.getKeyStorePassword() == null ? "password" : webServerConfig.getKeyStorePassword());
+ sslFactory.setIncludeProtocols("TLSv1.2");
Review comment:
I'm concerned about changing the defaults here for all cases. These should probably be made configurable and then the test can configure it as necessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services