You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/02/17 16:55:45 UTC
[GitHub] [beam] ramazan-yapparov opened a new pull request #14002: [BEAM-11589] Migrated vendor/bytebuddy build.gradle file to Kotlin script
ramazan-yapparov opened a new pull request #14002:
URL: https://github.com/apache/beam/pull/14002
Migrated vendor/bytebuddy build.gradle file to Kotlin script
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [x] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [x] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [x] Update `CHANGES.md` with noteworthy changes.
- [x] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Dataflow | Flink | Samza | Spark | Twister2
--- | --- | --- | --- | --- | --- | ---
Go | [](https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/) | ---
Java | [](https://ci-beam.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [](https://ci-beam
.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Twister2/lastCompletedBuild/)
Python | [](https://ci-beam.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python38/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Python_PVR_Flink_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/) | ---
XLang | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Dataflow/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/) | ---
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website | Whitespace | Typescript
--- | --- | --- | --- | --- | --- | ---
Non-portable | [](https://ci-beam.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocker_Cron/lastCompletedBuild/) <br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocs_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Whitespace_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Typescript_Cron/lastCompletedBuild/)
Portable | --- | [](https://ci-beam.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | --- | --- | ---
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on a change in pull request #14002: [BEAM-11589] Migrated vendor/bytebuddy build.gradle file to Kotlin script
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on a change in pull request #14002:
URL: https://github.com/apache/beam/pull/14002#discussion_r578080348
##########
File path: vendor/bytebuddy-1_10_8/build.gradle.kts
##########
@@ -16,22 +16,25 @@
* limitations under the License.
*/
-plugins { id 'org.apache.beam.vendor-java' }
+plugins { id("org.apache.beam.vendor-java") }
description = "Apache Beam :: Vendored Dependencies :: ByteBuddy :: 1.10.8"
group = "org.apache.beam"
version = "0.1"
+val vendorJava = project.extensions.extraProperties.get("vendorJava") as groovy.lang.Closure<*>
vendorJava(
- dependencies: ["net.bytebuddy:byte-buddy:1.10.8"],
- relocations: [
- "net.bytebuddy": "org.apache.beam.vendor.bytebuddy.v1_10_8.net.bytebuddy"
- ],
- exclusions: [
+ mapOf(
+
+ "dependencies" to listOf("net.bytebuddy:byte-buddy:1.10.8"),
+ "relocations" to mapOf(
+ "net.bytebuddy" to "org.apache.beam.vendor.bytebuddy.v1_10_8.net.bytebuddy"),
+ "exclusions" to listOf(
"**/module-info.class"
- ],
- groupId: group,
- artifactId: "beam-vendor-bytebuddy-1_10_8",
- version: version
+ ),
+ "groupId" to group,
+ "artifactId" to "beam-vendor-bytebuddy-1_10_8",
+ "version" to version
+)
Review comment:
nit: the formatting here is a little weird.
It might be worth looking into auto-formatting these files with the spotless plugin (i.e. so that `./gradlew spotlessApply` will format them)
I think it should be like
```
vendorJava(
mapOf(
"dependencies" to ..
....
)
)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ramazan-yapparov commented on pull request #14002: [BEAM-11589] Migrated vendor/bytebuddy build.gradle file to Kotlin script
Posted by GitBox <gi...@apache.org>.
ramazan-yapparov commented on pull request #14002:
URL: https://github.com/apache/beam/pull/14002#issuecomment-781182733
@TheNeuralBit is there a way to run whole CI pipeline here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on pull request #14002: [BEAM-11589] Migrated vendor/bytebuddy build.gradle file to Kotlin script
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on pull request #14002:
URL: https://github.com/apache/beam/pull/14002#issuecomment-781641752
Java PreComit should be sufficient to verify this build
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit merged pull request #14002: [BEAM-11589] Migrated vendor/bytebuddy build.gradle file to Kotlin script
Posted by GitBox <gi...@apache.org>.
TheNeuralBit merged pull request #14002:
URL: https://github.com/apache/beam/pull/14002
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on pull request #14002: [BEAM-11589] Migrated vendor/bytebuddy build.gradle file to Kotlin script
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on pull request #14002:
URL: https://github.com/apache/beam/pull/14002#issuecomment-781641499
Run Java PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ramazan-yapparov commented on pull request #14002: [BEAM-11589] Migrated vendor/bytebuddy build.gradle file to Kotlin script
Posted by GitBox <gi...@apache.org>.
ramazan-yapparov commented on pull request #14002:
URL: https://github.com/apache/beam/pull/14002#issuecomment-780877810
R: @TheNeuralBit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ramazan-yapparov commented on a change in pull request #14002: [BEAM-11589] Migrated vendor/bytebuddy build.gradle file to Kotlin script
Posted by GitBox <gi...@apache.org>.
ramazan-yapparov commented on a change in pull request #14002:
URL: https://github.com/apache/beam/pull/14002#discussion_r578231203
##########
File path: vendor/bytebuddy-1_10_8/build.gradle.kts
##########
@@ -16,22 +16,25 @@
* limitations under the License.
*/
-plugins { id 'org.apache.beam.vendor-java' }
+plugins { id("org.apache.beam.vendor-java") }
description = "Apache Beam :: Vendored Dependencies :: ByteBuddy :: 1.10.8"
group = "org.apache.beam"
version = "0.1"
+val vendorJava = project.extensions.extraProperties.get("vendorJava") as groovy.lang.Closure<*>
vendorJava(
- dependencies: ["net.bytebuddy:byte-buddy:1.10.8"],
- relocations: [
- "net.bytebuddy": "org.apache.beam.vendor.bytebuddy.v1_10_8.net.bytebuddy"
- ],
- exclusions: [
+ mapOf(
+
+ "dependencies" to listOf("net.bytebuddy:byte-buddy:1.10.8"),
+ "relocations" to mapOf(
+ "net.bytebuddy" to "org.apache.beam.vendor.bytebuddy.v1_10_8.net.bytebuddy"),
+ "exclusions" to listOf(
"**/module-info.class"
- ],
- groupId: group,
- artifactId: "beam-vendor-bytebuddy-1_10_8",
- version: version
+ ),
+ "groupId" to group,
+ "artifactId" to "beam-vendor-bytebuddy-1_10_8",
+ "version" to version
+)
Review comment:
Fixed, thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ramazan-yapparov commented on pull request #14002: [BEAM-11589] Migrated vendor/bytebuddy build.gradle file to Kotlin script
Posted by GitBox <gi...@apache.org>.
ramazan-yapparov commented on pull request #14002:
URL: https://github.com/apache/beam/pull/14002#issuecomment-781936085
Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org