You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/07/29 11:50:27 UTC

[GitHub] [spark] cloud-fan commented on pull request #37342: SPARK-39909 Organize the check of push down information for JDBCV2Suite

cloud-fan commented on PR #37342:
URL: https://github.com/apache/spark/pull/37342#issuecomment-1199187478

   Can we make the PR description more specific about the code changes? It looks to me that it changes the check method from `check(one_large_string)` to `check(small_string1, small_string2, ...)`. This looks fine as the check method eventually calls `checkKeywordsExistsInExplain`, which recommends callers put individual fragments for checking EXPLAIN result.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org