You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/06/20 02:29:15 UTC
[GitHub] [rocketmq] dongeforever commented on a diff in pull request #4469: [ISSUE#4468] Optimize broker buffer length initialization
dongeforever commented on code in PR #4469:
URL: https://github.com/apache/rocketmq/pull/4469#discussion_r901208156
##########
store/src/test/java/org/apache/rocketmq/store/DefaultMessageStoreTest.java:
##########
@@ -657,6 +658,30 @@ public void testCleanUnusedLmqTopic() throws Exception {
}
+ @Test
+ public void testEncodeLongMessage() throws Exception{
+ MessageExtBrokerInner messageExtBrokerInner = buildMessage();
+ Class clazz = messageStore.getClass();
+
+ Field fieldCommitLog = clazz.getDeclaredField("commitLog");
+ fieldCommitLog.setAccessible(true);
+ CommitLog commitLog = (CommitLog) fieldCommitLog.get(messageStore);
+
+ Field fieldMessageStoreConfig = clazz.getDeclaredField("messageStoreConfig");
+ fieldMessageStoreConfig.setAccessible(true);
+ MessageStoreConfig messageStoreConfig = (MessageStoreConfig) fieldMessageStoreConfig.get(messageStore);
+ messageExtBrokerInner.setBody(new byte[messageStoreConfig.getMaxMessageSize()]);
+
+ CommitLog.PutMessageThreadLocal putMessageThreadLocal = commitLog.getPutMessageThreadLocal().get();
+ PutMessageResult encodeResult1 = putMessageThreadLocal.getEncoder().encode(messageExtBrokerInner);
+ assertTrue(encodeResult1 == null);
+
Review Comment:
@shengminw This test is for DefaultMessageStore.
So just use type conversion (DefaultMessageStore) messagestore, instead of reflection.
The reflection is not friendly for further evolution.
##########
store/src/test/java/org/apache/rocketmq/store/DefaultMessageStoreTest.java:
##########
@@ -657,6 +658,30 @@ public void testCleanUnusedLmqTopic() throws Exception {
}
+ @Test
+ public void testEncodeLongMessage() throws Exception{
+ MessageExtBrokerInner messageExtBrokerInner = buildMessage();
+ Class clazz = messageStore.getClass();
+
+ Field fieldCommitLog = clazz.getDeclaredField("commitLog");
+ fieldCommitLog.setAccessible(true);
+ CommitLog commitLog = (CommitLog) fieldCommitLog.get(messageStore);
+
+ Field fieldMessageStoreConfig = clazz.getDeclaredField("messageStoreConfig");
+ fieldMessageStoreConfig.setAccessible(true);
+ MessageStoreConfig messageStoreConfig = (MessageStoreConfig) fieldMessageStoreConfig.get(messageStore);
+ messageExtBrokerInner.setBody(new byte[messageStoreConfig.getMaxMessageSize()]);
+
+ CommitLog.PutMessageThreadLocal putMessageThreadLocal = commitLog.getPutMessageThreadLocal().get();
+ PutMessageResult encodeResult1 = putMessageThreadLocal.getEncoder().encode(messageExtBrokerInner);
+ assertTrue(encodeResult1 == null);
+
Review Comment:
BTW, it maybe need another test for body size exactly equal to max message size.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org