You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/04/27 06:29:19 UTC
[GitHub] [rocketmq] rushsky518 opened a new pull request #1967: Begin time in lock
rushsky518 opened a new pull request #1967:
URL: https://github.com/apache/rocketmq/pull/1967
## What is the purpose of the change
XXXXX
## Brief changelog
XX
## Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] codecov-io edited a comment on pull request #1967: Begin time in lock
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1967:
URL: https://github.com/apache/rocketmq/pull/1967#issuecomment-619768930
# [Codecov](https://codecov.io/gh/apache/rocketmq/pull/1967?src=pr&el=h1) Report
> Merging [#1967](https://codecov.io/gh/apache/rocketmq/pull/1967?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/rocketmq/commit/1706cecff0993efdb00a079068f972d2e9a3699f&el=desc) will **decrease** coverage by `0.03%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/rocketmq/pull/1967?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #1967 +/- ##
=============================================
- Coverage 45.19% 45.16% -0.04%
+ Complexity 4200 4198 -2
=============================================
Files 544 544
Lines 35728 35706 -22
Branches 4744 4744
=============================================
- Hits 16148 16126 -22
+ Misses 17534 17531 -3
- Partials 2046 2049 +3
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq/pull/1967?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/rocketmq/store/PutMessageReentrantLock.java](https://codecov.io/gh/apache/rocketmq/pull/1967/diff?src=pr&el=tree#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL1B1dE1lc3NhZ2VSZWVudHJhbnRMb2NrLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...main/java/org/apache/rocketmq/store/CommitLog.java](https://codecov.io/gh/apache/rocketmq/pull/1967/diff?src=pr&el=tree#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL0NvbW1pdExvZy5qYXZh) | `68.52% <50.00%> (+1.26%)` | `80.00 <1.00> (ø)` | |
| [.../org/apache/rocketmq/store/PutMessageSpinLock.java](https://codecov.io/gh/apache/rocketmq/pull/1967/diff?src=pr&el=tree#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL1B1dE1lc3NhZ2VTcGluTG9jay5qYXZh) | `90.00% <100.00%> (+4.28%)` | `4.00 <1.00> (+1.00)` | |
| [...tmq/logappender/log4j2/RocketmqLog4j2Appender.java](https://codecov.io/gh/apache/rocketmq/pull/1967/diff?src=pr&el=tree#diff-bG9nYXBwZW5kZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL2xvZ2FwcGVuZGVyL2xvZzRqMi9Sb2NrZXRtcUxvZzRqMkFwcGVuZGVyLmphdmE=) | `35.00% <0.00%> (-10.00%)` | `3.00% <0.00%> (-1.00%)` | |
| [...ain/java/org/apache/rocketmq/test/util/MQWait.java](https://codecov.io/gh/apache/rocketmq/pull/1967/diff?src=pr&el=tree#diff-dGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvdGVzdC91dGlsL01RV2FpdC5qYXZh) | `48.64% <0.00%> (-5.41%)` | `3.00% <0.00%> (-1.00%)` | |
| [...in/java/org/apache/rocketmq/test/util/MQAdmin.java](https://codecov.io/gh/apache/rocketmq/pull/1967/diff?src=pr&el=tree#diff-dGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvdGVzdC91dGlsL01RQWRtaW4uamF2YQ==) | `40.00% <0.00%> (-4.45%)` | `7.00% <0.00%> (-1.00%)` | |
| [...nt/impl/consumer/ConsumeMessageOrderlyService.java](https://codecov.io/gh/apache/rocketmq/pull/1967/diff?src=pr&el=tree#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9Db25zdW1lTWVzc2FnZU9yZGVybHlTZXJ2aWNlLmphdmE=) | `38.98% <0.00%> (-3.62%)` | `16.00% <0.00%> (ø%)` | |
| [...org/apache/rocketmq/common/stats/StatsItemSet.java](https://codecov.io/gh/apache/rocketmq/pull/1967/diff?src=pr&el=tree#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vc3RhdHMvU3RhdHNJdGVtU2V0LmphdmE=) | `47.52% <0.00%> (-1.99%)` | `12.00% <0.00%> (-1.00%)` | |
| [...he/rocketmq/client/impl/consumer/ProcessQueue.java](https://codecov.io/gh/apache/rocketmq/pull/1967/diff?src=pr&el=tree#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9Qcm9jZXNzUXVldWUuamF2YQ==) | `60.00% <0.00%> (-0.94%)` | `32.00% <0.00%> (ø%)` | |
| [...he/rocketmq/client/trace/AsyncTraceDispatcher.java](https://codecov.io/gh/apache/rocketmq/pull/1967/diff?src=pr&el=tree#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvdHJhY2UvQXN5bmNUcmFjZURpc3BhdGNoZXIuamF2YQ==) | `73.60% <0.00%> (-0.51%)` | `17.00% <0.00%> (ø%)` | |
| ... and [4 more](https://codecov.io/gh/apache/rocketmq/pull/1967/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq/pull/1967?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/rocketmq/pull/1967?src=pr&el=footer). Last update [1706cec...77a4290](https://codecov.io/gh/apache/rocketmq/pull/1967?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] coveralls edited a comment on pull request #1967: Begin time in lock
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #1967:
URL: https://github.com/apache/rocketmq/pull/1967#issuecomment-619768901
[](https://coveralls.io/builds/30359761)
Coverage increased (+0.04%) to 50.956% when pulling **77a42908ef0e02cfb0b8271f7152f79a792a49fe on rushsky518:begin_time_in_Lock** into **1706cecff0993efdb00a079068f972d2e9a3699f on apache:develop**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] coveralls commented on pull request #1967: Begin time in lock
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #1967:
URL: https://github.com/apache/rocketmq/pull/1967#issuecomment-619768901
[](https://coveralls.io/builds/30359702)
Coverage increased (+0.02%) to 50.935% when pulling **77a42908ef0e02cfb0b8271f7152f79a792a49fe on rushsky518:begin_time_in_Lock** into **1706cecff0993efdb00a079068f972d2e9a3699f on apache:develop**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] yuz10 edited a comment on pull request #1967: [ISSUE #1968] Polish the code style about begin time in lock
Posted by GitBox <gi...@apache.org>.
yuz10 edited a comment on pull request #1967:
URL: https://github.com/apache/rocketmq/pull/1967#issuecomment-997957359
Already enhanced in #3460 (issue #3459 )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] yuz10 commented on pull request #1967: [ISSUE #1968] Polish the code style about begin time in lock
Posted by GitBox <gi...@apache.org>.
yuz10 commented on pull request #1967:
URL: https://github.com/apache/rocketmq/pull/1967#issuecomment-997957359
Already enhanced in #3459
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] codecov-io commented on pull request #1967: Begin time in lock
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1967:
URL: https://github.com/apache/rocketmq/pull/1967#issuecomment-619768930
# [Codecov](https://codecov.io/gh/apache/rocketmq/pull/1967?src=pr&el=h1) Report
> Merging [#1967](https://codecov.io/gh/apache/rocketmq/pull/1967?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/rocketmq/commit/1706cecff0993efdb00a079068f972d2e9a3699f&el=desc) will **decrease** coverage by `0.07%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/rocketmq/pull/1967?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #1967 +/- ##
=============================================
- Coverage 45.19% 45.12% -0.08%
+ Complexity 4200 4196 -4
=============================================
Files 544 544
Lines 35728 35706 -22
Branches 4744 4744
=============================================
- Hits 16148 16113 -35
- Misses 17534 17547 +13
Partials 2046 2046
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq/pull/1967?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/rocketmq/store/PutMessageReentrantLock.java](https://codecov.io/gh/apache/rocketmq/pull/1967/diff?src=pr&el=tree#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL1B1dE1lc3NhZ2VSZWVudHJhbnRMb2NrLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...main/java/org/apache/rocketmq/store/CommitLog.java](https://codecov.io/gh/apache/rocketmq/pull/1967/diff?src=pr&el=tree#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL0NvbW1pdExvZy5qYXZh) | `68.52% <50.00%> (+1.26%)` | `80.00 <1.00> (ø)` | |
| [.../org/apache/rocketmq/store/PutMessageSpinLock.java](https://codecov.io/gh/apache/rocketmq/pull/1967/diff?src=pr&el=tree#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL1B1dE1lc3NhZ2VTcGluTG9jay5qYXZh) | `90.00% <100.00%> (+4.28%)` | `4.00 <1.00> (+1.00)` | |
| [...ain/java/org/apache/rocketmq/test/util/MQWait.java](https://codecov.io/gh/apache/rocketmq/pull/1967/diff?src=pr&el=tree#diff-dGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvdGVzdC91dGlsL01RV2FpdC5qYXZh) | `43.24% <0.00%> (-10.82%)` | `3.00% <0.00%> (-1.00%)` | |
| [...tmq/logappender/log4j2/RocketmqLog4j2Appender.java](https://codecov.io/gh/apache/rocketmq/pull/1967/diff?src=pr&el=tree#diff-bG9nYXBwZW5kZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL2xvZ2FwcGVuZGVyL2xvZzRqMi9Sb2NrZXRtcUxvZzRqMkFwcGVuZGVyLmphdmE=) | `35.00% <0.00%> (-10.00%)` | `3.00% <0.00%> (-1.00%)` | |
| [...in/java/org/apache/rocketmq/test/util/MQAdmin.java](https://codecov.io/gh/apache/rocketmq/pull/1967/diff?src=pr&el=tree#diff-dGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvdGVzdC91dGlsL01RQWRtaW4uamF2YQ==) | `40.00% <0.00%> (-4.45%)` | `7.00% <0.00%> (-1.00%)` | |
| [...nt/impl/consumer/ConsumeMessageOrderlyService.java](https://codecov.io/gh/apache/rocketmq/pull/1967/diff?src=pr&el=tree#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9Db25zdW1lTWVzc2FnZU9yZGVybHlTZXJ2aWNlLmphdmE=) | `38.98% <0.00%> (-3.62%)` | `16.00% <0.00%> (ø%)` | |
| [...ava/org/apache/rocketmq/filter/util/BitsArray.java](https://codecov.io/gh/apache/rocketmq/pull/1967/diff?src=pr&el=tree#diff-ZmlsdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9maWx0ZXIvdXRpbC9CaXRzQXJyYXkuamF2YQ==) | `59.82% <0.00%> (-2.57%)` | `30.00% <0.00%> (-1.00%)` | |
| [...org/apache/rocketmq/common/stats/StatsItemSet.java](https://codecov.io/gh/apache/rocketmq/pull/1967/diff?src=pr&el=tree#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vc3RhdHMvU3RhdHNJdGVtU2V0LmphdmE=) | `47.52% <0.00%> (-1.99%)` | `12.00% <0.00%> (-1.00%)` | |
| [...he/rocketmq/client/impl/consumer/ProcessQueue.java](https://codecov.io/gh/apache/rocketmq/pull/1967/diff?src=pr&el=tree#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9Qcm9jZXNzUXVldWUuamF2YQ==) | `60.00% <0.00%> (-0.94%)` | `32.00% <0.00%> (ø%)` | |
| ... and [5 more](https://codecov.io/gh/apache/rocketmq/pull/1967/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq/pull/1967?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/rocketmq/pull/1967?src=pr&el=footer). Last update [1706cec...77a4290](https://codecov.io/gh/apache/rocketmq/pull/1967?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] rushsky518 commented on pull request #1967: Begin time in lock
Posted by GitBox <gi...@apache.org>.
rushsky518 commented on pull request #1967:
URL: https://github.com/apache/rocketmq/pull/1967#issuecomment-619824939
#1968
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] yuz10 closed pull request #1967: [ISSUE #1968] Polish the code style about begin time in lock
Posted by GitBox <gi...@apache.org>.
yuz10 closed pull request #1967:
URL: https://github.com/apache/rocketmq/pull/1967
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org