[jira] [Commented] (KAFKA-21106) Share consumer leaks ShareCompletedFetch when two fetches for the same partition are merged before collection

["Apoorv Mittal (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-21106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18116082#comment-18116082 ] 

Apoorv Mittal commented on KAFKA-21106:
---------------------------------------

[~omnia_h_ibrahim] I am marking this as a release blocker for now as it seems like a leak in ShareCompletedFetch. I ll let you know how we proceed with this.

> Share consumer leaks ShareCompletedFetch when two fetches for the same partition are merged before collection
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: KAFKA-21106
>                 URL: https://issues.apache.org/jira/browse/KAFKA-21106
>             Project: Kafka
>          Issue Type: Bug
>            Reporter: Apoorv Mittal
>            Assignee: Apoorv Mittal
>            Priority: Major
>
> ShareConsumeRequestManager.fetch() fetches on every poll() regardless of whether the previous fetch response for a partition was collected, so two completed fetches for the same partition can end up queued at once. ShareFetchCollector then merges them via ShareInFlightBatch.merge(), which copied the absorbed batch's records but never cleared them. That batch's ShareCompletedFetch leaks forever in ShareFetchBuffer.pendingAcknowledgementFetches, along with its retained records.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)