You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@mesosphere.io> on 2017/07/25 21:14:25 UTC
Re: Review Request 61098: Added unit tests for gRPC support in
libprocess.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61098/
-----------------------------------------------------------
(Updated July 25, 2017, 9:14 p.m.)
Review request for mesos, Benjamin Mahler, Jie Yu, and Joseph Wu.
Changes
-------
Refactored and moved CMake-related updates into a separated patch: https://reviews.apache.org/r/61118/
Summary (updated)
-----------------
Added unit tests for gRPC support in libprocess.
Bugs: MESOS-7810
https://issues.apache.org/jira/browse/MESOS-7810
Repository: mesos
Description (updated)
-------
We tested the following 6 scenarios when making gRPC calls:
1. The server responds with an OK.
2. The server responds with a failure.
3. The client discards the calls.
4. The client makes mulitple outstanding calls.
5. The client shuts down during a call.
6. The server is unreachable.
7. The server dose not respond in time.
`grpc_tests.pb.h`, `grpc_tests.pb.cc`, `grpc_tests.grpc.pb.h` and
`grpc_tests.grpc.pb.cc` are created with protobuf 3.3.0 and grpc
1.4.2 through the following command, assuming the current working
directory is `3rdparty/libprocess/src/tests`:
$ /path/to/protoc -I. --cpp_out=. --grpc_out=. \
--plugin=protoc-gen-grpc=/path/to/grpc_cpp_plugin \
grpc_tests.proto
Diffs (updated)
-----
3rdparty/libprocess/src/tests/grpc_tests.cpp PRE-CREATION
3rdparty/libprocess/src/tests/grpc_tests.grpc.pb.h PRE-CREATION
3rdparty/libprocess/src/tests/grpc_tests.grpc.pb.cc PRE-CREATION
3rdparty/libprocess/src/tests/grpc_tests.pb.h PRE-CREATION
3rdparty/libprocess/src/tests/grpc_tests.pb.cc PRE-CREATION
3rdparty/libprocess/src/tests/grpc_tests.proto PRE-CREATION
Diff: https://reviews.apache.org/r/61098/diff/2/
Changes: https://reviews.apache.org/r/61098/diff/1-2/
Testing (updated)
-------
N/A
Thanks,
Chun-Hung Hsiao
Re: Review Request 61098: Added unit tests for gRPC support in
libprocess.
Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
> On July 28, 2017, 7:57 p.m., Jie Yu wrote:
> > 3rdparty/libprocess/src/tests/grpc_tests.cpp
> > Lines 143 (patched)
> > <https://reviews.apache.org/r/61098/diff/4/?file=1784965#file1784965line143>
> >
> > I would separate discard into 3 tests:
> > 1) discard before server is started
> > 2) discard while server is processing the rpc
> > 3) discard after server finish processing the rpc
> >
> > maybe for 3), the expected result is a success?
For 3), I don't think there's a way to properly synchronize the statements to discard the future after the server finishes processing the call and before the client runtime receives the response.
- Chun-Hung
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61098/#review181712
-----------------------------------------------------------
On July 28, 2017, 12:49 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61098/
> -----------------------------------------------------------
>
> (Updated July 28, 2017, 12:49 a.m.)
>
>
> Review request for mesos, Benjamin Mahler, Jie Yu, and Joseph Wu.
>
>
> Bugs: MESOS-7810
> https://issues.apache.org/jira/browse/MESOS-7810
>
>
> Repository: mesos
>
>
> Description
> -------
>
> We tested the following 6 scenarios when making gRPC calls:
>
> 1. The server responds with an OK.
> 2. The server responds with a failure.
> 3. The client discards the calls.
> 4. The client makes mulitple outstanding calls.
> 5. The client shuts down during a call.
> 6. The server is unreachable.
> 7. The server dose not respond in time.
>
> `grpc_tests.pb.h`, `grpc_tests.pb.cc`, `grpc_tests.grpc.pb.h` and
> `grpc_tests.grpc.pb.cc` are created with protobuf 3.3.0 and grpc
> 1.4.2 through the following command, assuming the current working
> directory is `3rdparty/libprocess/src/tests`:
> $ /path/to/protoc -I. --cpp_out=. --grpc_out=. \
> --plugin=protoc-gen-grpc=/path/to/grpc_cpp_plugin \
> grpc_tests.proto
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/tests/grpc_tests.cpp PRE-CREATION
> 3rdparty/libprocess/src/tests/grpc_tests.grpc.pb.h PRE-CREATION
> 3rdparty/libprocess/src/tests/grpc_tests.grpc.pb.cc PRE-CREATION
> 3rdparty/libprocess/src/tests/grpc_tests.pb.h PRE-CREATION
> 3rdparty/libprocess/src/tests/grpc_tests.pb.cc PRE-CREATION
> 3rdparty/libprocess/src/tests/grpc_tests.proto PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/61098/diff/4/
>
>
> Testing
> -------
>
> N/A
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 61098: Added unit tests for gRPC support in
libprocess.
Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
> On July 28, 2017, 7:57 p.m., Jie Yu wrote:
> > 3rdparty/libprocess/src/tests/grpc_tests.cpp
> > Lines 282 (patched)
> > <https://reviews.apache.org/r/61098/diff/4/?file=1784965#file1784965line282>
> >
> > curious what happened if you don't call `shutdown->set(Nothing())` above?
Then the `AWAIT_READY` in the mock server will time out and thus the test will fail.
- Chun-Hung
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61098/#review181712
-----------------------------------------------------------
On July 28, 2017, 12:49 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61098/
> -----------------------------------------------------------
>
> (Updated July 28, 2017, 12:49 a.m.)
>
>
> Review request for mesos, Benjamin Mahler, Jie Yu, and Joseph Wu.
>
>
> Bugs: MESOS-7810
> https://issues.apache.org/jira/browse/MESOS-7810
>
>
> Repository: mesos
>
>
> Description
> -------
>
> We tested the following 6 scenarios when making gRPC calls:
>
> 1. The server responds with an OK.
> 2. The server responds with a failure.
> 3. The client discards the calls.
> 4. The client makes mulitple outstanding calls.
> 5. The client shuts down during a call.
> 6. The server is unreachable.
> 7. The server dose not respond in time.
>
> `grpc_tests.pb.h`, `grpc_tests.pb.cc`, `grpc_tests.grpc.pb.h` and
> `grpc_tests.grpc.pb.cc` are created with protobuf 3.3.0 and grpc
> 1.4.2 through the following command, assuming the current working
> directory is `3rdparty/libprocess/src/tests`:
> $ /path/to/protoc -I. --cpp_out=. --grpc_out=. \
> --plugin=protoc-gen-grpc=/path/to/grpc_cpp_plugin \
> grpc_tests.proto
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/tests/grpc_tests.cpp PRE-CREATION
> 3rdparty/libprocess/src/tests/grpc_tests.grpc.pb.h PRE-CREATION
> 3rdparty/libprocess/src/tests/grpc_tests.grpc.pb.cc PRE-CREATION
> 3rdparty/libprocess/src/tests/grpc_tests.pb.h PRE-CREATION
> 3rdparty/libprocess/src/tests/grpc_tests.pb.cc PRE-CREATION
> 3rdparty/libprocess/src/tests/grpc_tests.proto PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/61098/diff/4/
>
>
> Testing
> -------
>
> N/A
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 61098: Added unit tests for gRPC support in
libprocess.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61098/#review181712
-----------------------------------------------------------
Fix it, then Ship it!
Nice tests!
3rdparty/libprocess/src/tests/grpc_tests.cpp
Lines 30 (patched)
<https://reviews.apache.org/r/61098/#comment257350>
we usually do not import the whole namespace.
Instead, please use namespace alias
```
namespace grpc = process::grpc;
```
3rdparty/libprocess/src/tests/grpc_tests.cpp
Lines 36 (patched)
<https://reviews.apache.org/r/61098/#comment257351>
you probably needs to use
```
using ::grpc::xxx
```
to disambiguate
3rdparty/libprocess/src/tests/grpc_tests.cpp
Lines 62 (patched)
<https://reviews.apache.org/r/61098/#comment257352>
s/addr/address/
3rdparty/libprocess/src/tests/grpc_tests.cpp
Lines 93 (patched)
<https://reviews.apache.org/r/61098/#comment257353>
hard coded port will cause issue if multiple folks on the same test machine are running tests.
Can we use domain socket instead (in a temp dir)
3rdparty/libprocess/src/tests/grpc_tests.cpp
Lines 115 (patched)
<https://reviews.apache.org/r/61098/#comment257357>
GRPCClientTest? Ditto below too.
3rdparty/libprocess/src/tests/grpc_tests.cpp
Lines 143 (patched)
<https://reviews.apache.org/r/61098/#comment257359>
I would separate discard into 3 tests:
1) discard before server is started
2) discard while server is processing the rpc
3) discard after server finish processing the rpc
maybe for 3), the expected result is a success?
3rdparty/libprocess/src/tests/grpc_tests.cpp
Lines 176 (patched)
<https://reviews.apache.org/r/61098/#comment257358>
1 blank line above
3rdparty/libprocess/src/tests/grpc_tests.cpp
Lines 190 (patched)
<https://reviews.apache.org/r/61098/#comment257360>
s/Multiple/ConcurrentRPCs/
3rdparty/libprocess/src/tests/grpc_tests.cpp
Lines 280 (patched)
<https://reviews.apache.org/r/61098/#comment257362>
add a new line above.
3rdparty/libprocess/src/tests/grpc_tests.cpp
Lines 281 (patched)
<https://reviews.apache.org/r/61098/#comment257361>
kill this line
3rdparty/libprocess/src/tests/grpc_tests.cpp
Lines 282 (patched)
<https://reviews.apache.org/r/61098/#comment257363>
curious what happened if you don't call `shutdown->set(Nothing())` above?
3rdparty/libprocess/src/tests/grpc_tests.cpp
Lines 286 (patched)
<https://reviews.apache.org/r/61098/#comment257355>
2 lines apart
3rdparty/libprocess/src/tests/grpc_tests.cpp
Lines 314 (patched)
<https://reviews.apache.org/r/61098/#comment257366>
s/failed/done
3rdparty/libprocess/src/tests/grpc_tests.cpp
Lines 331 (patched)
<https://reviews.apache.org/r/61098/#comment257365>
too bad this test will take 5 seconds. Please add a TODO here to lower the timeout value once we support it.
3rdparty/libprocess/src/tests/grpc_tests.proto
Lines 28 (patched)
<https://reviews.apache.org/r/61098/#comment257348>
2 lines apart
3rdparty/libprocess/src/tests/grpc_tests.proto
Lines 30 (patched)
<https://reviews.apache.org/r/61098/#comment257349>
Ditto
- Jie Yu
On July 28, 2017, 12:49 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61098/
> -----------------------------------------------------------
>
> (Updated July 28, 2017, 12:49 a.m.)
>
>
> Review request for mesos, Benjamin Mahler, Jie Yu, and Joseph Wu.
>
>
> Bugs: MESOS-7810
> https://issues.apache.org/jira/browse/MESOS-7810
>
>
> Repository: mesos
>
>
> Description
> -------
>
> We tested the following 6 scenarios when making gRPC calls:
>
> 1. The server responds with an OK.
> 2. The server responds with a failure.
> 3. The client discards the calls.
> 4. The client makes mulitple outstanding calls.
> 5. The client shuts down during a call.
> 6. The server is unreachable.
> 7. The server dose not respond in time.
>
> `grpc_tests.pb.h`, `grpc_tests.pb.cc`, `grpc_tests.grpc.pb.h` and
> `grpc_tests.grpc.pb.cc` are created with protobuf 3.3.0 and grpc
> 1.4.2 through the following command, assuming the current working
> directory is `3rdparty/libprocess/src/tests`:
> $ /path/to/protoc -I. --cpp_out=. --grpc_out=. \
> --plugin=protoc-gen-grpc=/path/to/grpc_cpp_plugin \
> grpc_tests.proto
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/tests/grpc_tests.cpp PRE-CREATION
> 3rdparty/libprocess/src/tests/grpc_tests.grpc.pb.h PRE-CREATION
> 3rdparty/libprocess/src/tests/grpc_tests.grpc.pb.cc PRE-CREATION
> 3rdparty/libprocess/src/tests/grpc_tests.pb.h PRE-CREATION
> 3rdparty/libprocess/src/tests/grpc_tests.pb.cc PRE-CREATION
> 3rdparty/libprocess/src/tests/grpc_tests.proto PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/61098/diff/4/
>
>
> Testing
> -------
>
> N/A
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 61098: Added unit tests for gRPC support in
libprocess.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61098/#review181955
-----------------------------------------------------------
I believe adding generated protobuf files to the repository is not a good idea (in addition to being highly redundant it also might not work if a user uses e.g., an unbundled protobuf-2.6.1). Have a look at `e6ec4e8362552cbaf74bf3e844e7ac4b15f9aafd` for an example of how to generate test proto files during the build instead of checking them in.
- Benjamin Bannier
On July 28, 2017, 2:49 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61098/
> -----------------------------------------------------------
>
> (Updated July 28, 2017, 2:49 a.m.)
>
>
> Review request for mesos, Benjamin Mahler, Jie Yu, and Joseph Wu.
>
>
> Bugs: MESOS-7810
> https://issues.apache.org/jira/browse/MESOS-7810
>
>
> Repository: mesos
>
>
> Description
> -------
>
> We tested the following 6 scenarios when making gRPC calls:
>
> 1. The server responds with an OK.
> 2. The server responds with a failure.
> 3. The client discards the calls.
> 4. The client makes mulitple outstanding calls.
> 5. The client shuts down during a call.
> 6. The server is unreachable.
> 7. The server dose not respond in time.
>
> `grpc_tests.pb.h`, `grpc_tests.pb.cc`, `grpc_tests.grpc.pb.h` and
> `grpc_tests.grpc.pb.cc` are created with protobuf 3.3.0 and grpc
> 1.4.2 through the following command, assuming the current working
> directory is `3rdparty/libprocess/src/tests`:
> $ /path/to/protoc -I. --cpp_out=. --grpc_out=. \
> --plugin=protoc-gen-grpc=/path/to/grpc_cpp_plugin \
> grpc_tests.proto
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/tests/grpc_tests.cpp PRE-CREATION
> 3rdparty/libprocess/src/tests/grpc_tests.grpc.pb.h PRE-CREATION
> 3rdparty/libprocess/src/tests/grpc_tests.grpc.pb.cc PRE-CREATION
> 3rdparty/libprocess/src/tests/grpc_tests.pb.h PRE-CREATION
> 3rdparty/libprocess/src/tests/grpc_tests.pb.cc PRE-CREATION
> 3rdparty/libprocess/src/tests/grpc_tests.proto PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/61098/diff/4/
>
>
> Testing
> -------
>
> N/A
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 61098: Added unit tests for gRPC support in
libprocess.
Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61098/
-----------------------------------------------------------
(Updated Aug. 2, 2017, 11:32 p.m.)
Review request for mesos, Benjamin Mahler, Jie Yu, and Joseph Wu.
Changes
-------
Addressed Jie's and Benjamin's comments.
Bugs: MESOS-7810
https://issues.apache.org/jira/browse/MESOS-7810
Repository: mesos
Description (updated)
-------
We tested the following 6 scenarios when making gRPC calls:
1. The server responds with an OK.
2. The server responds with a failure.
3. The client discards the call before the server starts.
4. The client discards the call when the server is processing it.
5. The client makes mulitple concurrent calls.
6. The client shuts down during a call.
7. The server is unreachable.
8. The server dose not respond in time.
Diffs (updated)
-----
3rdparty/libprocess/src/tests/grpc_tests.cpp PRE-CREATION
3rdparty/libprocess/src/tests/grpc_tests.proto PRE-CREATION
Diff: https://reviews.apache.org/r/61098/diff/5/
Changes: https://reviews.apache.org/r/61098/diff/4-5/
Testing
-------
N/A
Thanks,
Chun-Hung Hsiao
Re: Review Request 61098: Added unit tests for gRPC support in
libprocess.
Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
> On Aug. 2, 2017, 10:01 a.m., Benjamin Bannier wrote:
> > 3rdparty/libprocess/src/tests/grpc_tests.grpc.pb.h
> > Lines 1 (patched)
> > <https://reviews.apache.org/r/61098/diff/4/?file=1784966#file1784966line1>
> >
> > I believe adding generated protobuf files to the repository is not a good idea (in addition to being highly redundant it also might not work if a user uses e.g., an unbundled protobuf-2.6.1). Have a look at e6ec4e8362552cbaf74bf3e844e7ac4b15f9aafd for an example of how to generate test proto files during the build instead of checking them in.
Yeah I just noticed that the protobuf test in stout has been changed to avoid this. Let me figure out a way to auto-gen the grpc code. Thanks.
- Chun-Hung
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61098/#review181957
-----------------------------------------------------------
On July 28, 2017, 12:49 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61098/
> -----------------------------------------------------------
>
> (Updated July 28, 2017, 12:49 a.m.)
>
>
> Review request for mesos, Benjamin Mahler, Jie Yu, and Joseph Wu.
>
>
> Bugs: MESOS-7810
> https://issues.apache.org/jira/browse/MESOS-7810
>
>
> Repository: mesos
>
>
> Description
> -------
>
> We tested the following 6 scenarios when making gRPC calls:
>
> 1. The server responds with an OK.
> 2. The server responds with a failure.
> 3. The client discards the calls.
> 4. The client makes mulitple outstanding calls.
> 5. The client shuts down during a call.
> 6. The server is unreachable.
> 7. The server dose not respond in time.
>
> `grpc_tests.pb.h`, `grpc_tests.pb.cc`, `grpc_tests.grpc.pb.h` and
> `grpc_tests.grpc.pb.cc` are created with protobuf 3.3.0 and grpc
> 1.4.2 through the following command, assuming the current working
> directory is `3rdparty/libprocess/src/tests`:
> $ /path/to/protoc -I. --cpp_out=. --grpc_out=. \
> --plugin=protoc-gen-grpc=/path/to/grpc_cpp_plugin \
> grpc_tests.proto
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/tests/grpc_tests.cpp PRE-CREATION
> 3rdparty/libprocess/src/tests/grpc_tests.grpc.pb.h PRE-CREATION
> 3rdparty/libprocess/src/tests/grpc_tests.grpc.pb.cc PRE-CREATION
> 3rdparty/libprocess/src/tests/grpc_tests.pb.h PRE-CREATION
> 3rdparty/libprocess/src/tests/grpc_tests.pb.cc PRE-CREATION
> 3rdparty/libprocess/src/tests/grpc_tests.proto PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/61098/diff/4/
>
>
> Testing
> -------
>
> N/A
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 61098: Added unit tests for gRPC support in
libprocess.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61098/#review181957
-----------------------------------------------------------
3rdparty/libprocess/src/tests/grpc_tests.grpc.pb.h
Lines 1 (patched)
<https://reviews.apache.org/r/61098/#comment257793>
I believe adding generated protobuf files to the repository is not a good idea (in addition to being highly redundant it also might not work if a user uses e.g., an unbundled protobuf-2.6.1). Have a look at e6ec4e8362552cbaf74bf3e844e7ac4b15f9aafd for an example of how to generate test proto files during the build instead of checking them in.
3rdparty/libprocess/src/tests/grpc_tests.grpc.pb.cc
Lines 1 (patched)
<https://reviews.apache.org/r/61098/#comment257796>
See above.
3rdparty/libprocess/src/tests/grpc_tests.pb.h
Lines 1 (patched)
<https://reviews.apache.org/r/61098/#comment257794>
See above.
3rdparty/libprocess/src/tests/grpc_tests.pb.h
Lines 1 (patched)
<https://reviews.apache.org/r/61098/#comment257795>
See above.
- Benjamin Bannier
On July 28, 2017, 2:49 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61098/
> -----------------------------------------------------------
>
> (Updated July 28, 2017, 2:49 a.m.)
>
>
> Review request for mesos, Benjamin Mahler, Jie Yu, and Joseph Wu.
>
>
> Bugs: MESOS-7810
> https://issues.apache.org/jira/browse/MESOS-7810
>
>
> Repository: mesos
>
>
> Description
> -------
>
> We tested the following 6 scenarios when making gRPC calls:
>
> 1. The server responds with an OK.
> 2. The server responds with a failure.
> 3. The client discards the calls.
> 4. The client makes mulitple outstanding calls.
> 5. The client shuts down during a call.
> 6. The server is unreachable.
> 7. The server dose not respond in time.
>
> `grpc_tests.pb.h`, `grpc_tests.pb.cc`, `grpc_tests.grpc.pb.h` and
> `grpc_tests.grpc.pb.cc` are created with protobuf 3.3.0 and grpc
> 1.4.2 through the following command, assuming the current working
> directory is `3rdparty/libprocess/src/tests`:
> $ /path/to/protoc -I. --cpp_out=. --grpc_out=. \
> --plugin=protoc-gen-grpc=/path/to/grpc_cpp_plugin \
> grpc_tests.proto
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/tests/grpc_tests.cpp PRE-CREATION
> 3rdparty/libprocess/src/tests/grpc_tests.grpc.pb.h PRE-CREATION
> 3rdparty/libprocess/src/tests/grpc_tests.grpc.pb.cc PRE-CREATION
> 3rdparty/libprocess/src/tests/grpc_tests.pb.h PRE-CREATION
> 3rdparty/libprocess/src/tests/grpc_tests.pb.cc PRE-CREATION
> 3rdparty/libprocess/src/tests/grpc_tests.proto PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/61098/diff/4/
>
>
> Testing
> -------
>
> N/A
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 61098: Added unit tests for gRPC support in
libprocess.
Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61098/
-----------------------------------------------------------
(Updated July 28, 2017, 12:49 a.m.)
Review request for mesos, Benjamin Mahler, Jie Yu, and Joseph Wu.
Changes
-------
Updated based on the latest change in r/61097.
Bugs: MESOS-7810
https://issues.apache.org/jira/browse/MESOS-7810
Repository: mesos
Description
-------
We tested the following 6 scenarios when making gRPC calls:
1. The server responds with an OK.
2. The server responds with a failure.
3. The client discards the calls.
4. The client makes mulitple outstanding calls.
5. The client shuts down during a call.
6. The server is unreachable.
7. The server dose not respond in time.
`grpc_tests.pb.h`, `grpc_tests.pb.cc`, `grpc_tests.grpc.pb.h` and
`grpc_tests.grpc.pb.cc` are created with protobuf 3.3.0 and grpc
1.4.2 through the following command, assuming the current working
directory is `3rdparty/libprocess/src/tests`:
$ /path/to/protoc -I. --cpp_out=. --grpc_out=. \
--plugin=protoc-gen-grpc=/path/to/grpc_cpp_plugin \
grpc_tests.proto
Diffs (updated)
-----
3rdparty/libprocess/src/tests/grpc_tests.cpp PRE-CREATION
3rdparty/libprocess/src/tests/grpc_tests.grpc.pb.h PRE-CREATION
3rdparty/libprocess/src/tests/grpc_tests.grpc.pb.cc PRE-CREATION
3rdparty/libprocess/src/tests/grpc_tests.pb.h PRE-CREATION
3rdparty/libprocess/src/tests/grpc_tests.pb.cc PRE-CREATION
3rdparty/libprocess/src/tests/grpc_tests.proto PRE-CREATION
Diff: https://reviews.apache.org/r/61098/diff/4/
Changes: https://reviews.apache.org/r/61098/diff/3-4/
Testing
-------
N/A
Thanks,
Chun-Hung Hsiao
Re: Review Request 61098: Added unit tests for gRPC support in
libprocess.
Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61098/
-----------------------------------------------------------
(Updated July 27, 2017, 10:26 p.m.)
Review request for mesos, Benjamin Mahler, Jie Yu, and Joseph Wu.
Changes
-------
Updated based on the changes in r/61097.
Bugs: MESOS-7810
https://issues.apache.org/jira/browse/MESOS-7810
Repository: mesos
Description
-------
We tested the following 6 scenarios when making gRPC calls:
1. The server responds with an OK.
2. The server responds with a failure.
3. The client discards the calls.
4. The client makes mulitple outstanding calls.
5. The client shuts down during a call.
6. The server is unreachable.
7. The server dose not respond in time.
`grpc_tests.pb.h`, `grpc_tests.pb.cc`, `grpc_tests.grpc.pb.h` and
`grpc_tests.grpc.pb.cc` are created with protobuf 3.3.0 and grpc
1.4.2 through the following command, assuming the current working
directory is `3rdparty/libprocess/src/tests`:
$ /path/to/protoc -I. --cpp_out=. --grpc_out=. \
--plugin=protoc-gen-grpc=/path/to/grpc_cpp_plugin \
grpc_tests.proto
Diffs (updated)
-----
3rdparty/libprocess/src/tests/grpc_tests.cpp PRE-CREATION
3rdparty/libprocess/src/tests/grpc_tests.grpc.pb.h PRE-CREATION
3rdparty/libprocess/src/tests/grpc_tests.grpc.pb.cc PRE-CREATION
3rdparty/libprocess/src/tests/grpc_tests.pb.h PRE-CREATION
3rdparty/libprocess/src/tests/grpc_tests.pb.cc PRE-CREATION
3rdparty/libprocess/src/tests/grpc_tests.proto PRE-CREATION
Diff: https://reviews.apache.org/r/61098/diff/3/
Changes: https://reviews.apache.org/r/61098/diff/2-3/
Testing
-------
N/A
Thanks,
Chun-Hung Hsiao