You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/03/13 23:20:52 UTC
[GitHub] [incubator-superset] codecov-io edited a comment on issue #7028:
Feature: Adding warning message for sqllab save query
codecov-io edited a comment on issue #7028: Feature: Adding warning message for sqllab save query
URL: https://github.com/apache/incubator-superset/pull/7028#issuecomment-472644061
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/7028?src=pr&el=h1) Report
> Merging [#7028](https://codecov.io/gh/apache/incubator-superset/pull/7028?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/05be86611785fef2904992e4e7d31dce23f1c51b?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `66.66%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/7028?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7028 +/- ##
==========================================
+ Coverage 64.45% 64.45% +<.01%
==========================================
Files 421 421
Lines 20523 20526 +3
Branches 2245 2247 +2
==========================================
+ Hits 13229 13231 +2
- Misses 7167 7168 +1
Partials 127 127
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/7028?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/7028/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `69.1% <ø> (ø)` | :arrow_up: |
| [.../assets/src/SqlLab/components/TabbedSqlEditors.jsx](https://codecov.io/gh/apache/incubator-superset/pull/7028/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvY29tcG9uZW50cy9UYWJiZWRTcWxFZGl0b3JzLmpzeA==) | `83.17% <ø> (ø)` | :arrow_up: |
| [...uperset/assets/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/7028/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvY29tcG9uZW50cy9TcWxFZGl0b3IuanN4) | `57.44% <ø> (ø)` | :arrow_up: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/7028/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `93.75% <100%> (+0.03%)` | :arrow_up: |
| [...uperset/assets/src/SqlLab/components/SaveQuery.jsx](https://codecov.io/gh/apache/incubator-superset/pull/7028/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvY29tcG9uZW50cy9TYXZlUXVlcnkuanN4) | `56.25% <50%> (-0.42%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/7028?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/7028?src=pr&el=footer). Last update [05be866...8b512c0](https://codecov.io/gh/apache/incubator-superset/pull/7028?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org