[GitHub] [hop] hansva commented on pull request #1674: HOP-4191 - Fix for "Get file names" bug on Beam

[GitBox <gi...@apache.org>]

hansva commented on PR #1674:
URL: https://github.com/apache/hop/pull/1674#issuecomment-1237850861

   I'll dig a bit further into the why and when. processRow normally should keep running until it reaches one of the false conditions.
   So it might just be that the ending conditions in the beginning are wrong.
   
   ```
       if (!meta.isFileField()) {
         if (data.filenr >= data.filessize) {
           setOutputDone();
           return false;
         }
       } else {
         if (data.filenr >= data.filessize) {
           // Grab one row from previous transform ...
           data.readrow = getRow();
         }
   
         if (data.readrow == null) {
           setOutputDone();
           return false;
         }
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org