You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rave.apache.org by Venkat Mahadevan <ve...@mitre.org> on 2011/10/27 20:44:45 UTC
Review Request: RAVE-315 WidgetRating - ModelPermissionEvaluator and Service
Annotations
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2584/
-----------------------------------------------------------
Review request for rave.
Summary
-------
This is the patch for RAVE-315: WidgetRating - ModelPermissionEvaluator and Service Annotations
Diffs
-----
https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/security/impl/DefaultWidgetRatingPermissionEvaluatorTest.java PRE-CREATION
https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/security/impl/RavePermissionEvaluator.java 1189891
https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/WidgetRatingService.java 1189891
https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/security/ModelPermissionEvaluator.java 1189891
https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/security/impl/DefaultWidgetRatingPermissionEvaluator.java PRE-CREATION
Diff: https://reviews.apache.org/r/2584/diff
Testing
-------
Thanks,
Venkat
RE: Review Request: RAVE-315 WidgetRating -
ModelPermissionEvaluator and Service Annotations
Posted by "Carlucci, Tony" <ac...@mitre.org>.
Hi Raminder, sure I'll apply the patch. FYI - I patched it through my IDE (Netbeans)
Tony
---
Anthony Carlucci | SW App Dev Eng, Sr. | R501 / KW App Development & Maint
e: acarlucci@mitre.org | v: 781.271.2432 | f: 781.271.3299
The MITRE Corporation | 202 Burlington Rd | Bedford, MA 01730-1420
-----Original Message-----
From: Raminderjeet Singh [mailto:raminderjsingh@gmail.com]
Sent: Monday, October 31, 2011 10:50 AM
To: rave-dev@incubator.apache.org
Cc: Mahadevan, Venkat; Carlucci, Tony
Subject: Re: Review Request: RAVE-315 WidgetRating - ModelPermissionEvaluator and Service Annotations
Anthony,
I checked out latest code from trunk into a new directory and then tried to apply the patch and i am getting following error using patch command. If it works for you please go ahead and apply the patch.
patch -p0 -i RAVE-315-2.patch
patching file rave-components/rave-core/src/main/java/org/apache/rave/portal/security/ModelPermissionEvaluator.java
patching file rave-components/rave-core/src/main/java/org/apache/rave/portal/security/impl/DefaultWidgetRatingPermissionEvaluator.java
patching file rave-components/rave-core/src/main/java/org/apache/rave/portal/security/impl/RavePermissionEvaluator.java
patching file rave-components/rave-core/src/main/java/org/apache/rave/portal/service/WidgetRatingService.java
patching file rave-components/rave-core/src/main/java/org/apache/rave/portal/service/impl/DefaultWidgetRatingService.java
patching file rave-components/rave-core/src/test/java/org/apache/rave/portal/security/impl/DefaultWidgetRatingPermissionEvaluatorTest.java
patching file rave-components/rave-core/src/test/java/org/apache/rave/portal/service/impl/DefaultWidgetRatingServiceTest.java
patching file rave-components/rave-web/src/main/java/org/apache/rave/portal/web/api/rest/WidgetApi.java
Hunk #1 FAILED at 19.
Hunk #2 FAILED at 72.
2 out of 2 hunks FAILED -- saving rejects to file rave-components/rave-web/src/main/java/org/apache/rave/portal/web/api/rest/WidgetApi.java.rej
patching file rave-components/rave-web/src/test/java/org/apache/rave/portal/web/api/rest/WidgetApiTest.java
Hunk #1 FAILED at 20.
Hunk #2 FAILED at 27.
Hunk #3 FAILED at 69.
3 out of 3 hunks FAILED -- saving rejects to file rave-components/rave-web/src/test/java/org/apache/rave/portal/web/api/rest/WidgetApiTest.java.rej
Thanks
Raminder
On Oct 31, 2011, at 10:05 AM, Anthony Carlucci wrote:
>
>
>> On 2011-10-29 15:23:32, Raminder Singh wrote:
>>> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/api/rest/WidgetApiTest.java, line 77
>>> <https://reviews.apache.org/r/2584/diff/3/?file=54334#file54334line77>
>>>
>>> Because of this conflict in 2 different versions patch is getting FAILED status when i am applying on latest version of the code
>
> I applied the R3 diff to my local code and it applied fine without any SVN conflicts. Can you svn update first then apply and see if it resolves the problem? If not let me know and I can apply the patch.
>
>
> - Anthony
>
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2584/#review2924
> -----------------------------------------------------------
>
>
> On 2011-10-28 18:09:46, Venkat Mahadevan wrote:
>>
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/2584/
>> -----------------------------------------------------------
>>
>> (Updated 2011-10-28 18:09:46)
>>
>>
>> Review request for rave.
>>
>>
>> Summary
>> -------
>>
>> This is the patch for RAVE-315: WidgetRating - ModelPermissionEvaluator and Service Annotations
>>
>>
>> Diffs
>> -----
>>
>> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/security/ModelPermissionEvaluator.java 1190478
>> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/security/impl/DefaultWidgetRatingPermissionEvaluator.java PRE-CREATION
>> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/security/impl/RavePermissionEvaluator.java 1190478
>> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/WidgetRatingService.java 1190478
>> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/impl/DefaultWidgetRatingService.java 1190478
>> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/security/impl/DefaultWidgetRatingPermissionEvaluatorTest.java PRE-CREATION
>> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/service/impl/DefaultWidgetRatingServiceTest.java 1190478
>> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/api/rest/WidgetApi.java 1190478
>> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/api/rest/WidgetApiTest.java 1190478
>>
>> Diff: https://reviews.apache.org/r/2584/diff
>>
>>
>> Testing
>> -------
>>
>>
>> Thanks,
>>
>> Venkat
>>
>>
>
Re: Review Request: RAVE-315 WidgetRating - ModelPermissionEvaluator and Service Annotations
Posted by Raminderjeet Singh <ra...@gmail.com>.
Anthony,
I checked out latest code from trunk into a new directory and then tried to apply the patch and i am getting following error using patch command. If it works for you please go ahead and apply the patch.
patch -p0 -i RAVE-315-2.patch
patching file rave-components/rave-core/src/main/java/org/apache/rave/portal/security/ModelPermissionEvaluator.java
patching file rave-components/rave-core/src/main/java/org/apache/rave/portal/security/impl/DefaultWidgetRatingPermissionEvaluator.java
patching file rave-components/rave-core/src/main/java/org/apache/rave/portal/security/impl/RavePermissionEvaluator.java
patching file rave-components/rave-core/src/main/java/org/apache/rave/portal/service/WidgetRatingService.java
patching file rave-components/rave-core/src/main/java/org/apache/rave/portal/service/impl/DefaultWidgetRatingService.java
patching file rave-components/rave-core/src/test/java/org/apache/rave/portal/security/impl/DefaultWidgetRatingPermissionEvaluatorTest.java
patching file rave-components/rave-core/src/test/java/org/apache/rave/portal/service/impl/DefaultWidgetRatingServiceTest.java
patching file rave-components/rave-web/src/main/java/org/apache/rave/portal/web/api/rest/WidgetApi.java
Hunk #1 FAILED at 19.
Hunk #2 FAILED at 72.
2 out of 2 hunks FAILED -- saving rejects to file rave-components/rave-web/src/main/java/org/apache/rave/portal/web/api/rest/WidgetApi.java.rej
patching file rave-components/rave-web/src/test/java/org/apache/rave/portal/web/api/rest/WidgetApiTest.java
Hunk #1 FAILED at 20.
Hunk #2 FAILED at 27.
Hunk #3 FAILED at 69.
3 out of 3 hunks FAILED -- saving rejects to file rave-components/rave-web/src/test/java/org/apache/rave/portal/web/api/rest/WidgetApiTest.java.rej
Thanks
Raminder
On Oct 31, 2011, at 10:05 AM, Anthony Carlucci wrote:
>
>
>> On 2011-10-29 15:23:32, Raminder Singh wrote:
>>> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/api/rest/WidgetApiTest.java, line 77
>>> <https://reviews.apache.org/r/2584/diff/3/?file=54334#file54334line77>
>>>
>>> Because of this conflict in 2 different versions patch is getting FAILED status when i am applying on latest version of the code
>
> I applied the R3 diff to my local code and it applied fine without any SVN conflicts. Can you svn update first then apply and see if it resolves the problem? If not let me know and I can apply the patch.
>
>
> - Anthony
>
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2584/#review2924
> -----------------------------------------------------------
>
>
> On 2011-10-28 18:09:46, Venkat Mahadevan wrote:
>>
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/2584/
>> -----------------------------------------------------------
>>
>> (Updated 2011-10-28 18:09:46)
>>
>>
>> Review request for rave.
>>
>>
>> Summary
>> -------
>>
>> This is the patch for RAVE-315: WidgetRating - ModelPermissionEvaluator and Service Annotations
>>
>>
>> Diffs
>> -----
>>
>> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/security/ModelPermissionEvaluator.java 1190478
>> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/security/impl/DefaultWidgetRatingPermissionEvaluator.java PRE-CREATION
>> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/security/impl/RavePermissionEvaluator.java 1190478
>> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/WidgetRatingService.java 1190478
>> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/impl/DefaultWidgetRatingService.java 1190478
>> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/security/impl/DefaultWidgetRatingPermissionEvaluatorTest.java PRE-CREATION
>> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/service/impl/DefaultWidgetRatingServiceTest.java 1190478
>> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/api/rest/WidgetApi.java 1190478
>> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/api/rest/WidgetApiTest.java 1190478
>>
>> Diff: https://reviews.apache.org/r/2584/diff
>>
>>
>> Testing
>> -------
>>
>>
>> Thanks,
>>
>> Venkat
>>
>>
>
Re: Review Request: RAVE-315 WidgetRating - ModelPermissionEvaluator and
Service Annotations
Posted by Anthony Carlucci <ac...@mitre.org>.
> On 2011-10-29 15:23:32, Raminder Singh wrote:
> > https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/api/rest/WidgetApiTest.java, line 77
> > <https://reviews.apache.org/r/2584/diff/3/?file=54334#file54334line77>
> >
> > Because of this conflict in 2 different versions patch is getting FAILED status when i am applying on latest version of the code
I applied the R3 diff to my local code and it applied fine without any SVN conflicts. Can you svn update first then apply and see if it resolves the problem? If not let me know and I can apply the patch.
- Anthony
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2584/#review2924
-----------------------------------------------------------
On 2011-10-28 18:09:46, Venkat Mahadevan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2584/
> -----------------------------------------------------------
>
> (Updated 2011-10-28 18:09:46)
>
>
> Review request for rave.
>
>
> Summary
> -------
>
> This is the patch for RAVE-315: WidgetRating - ModelPermissionEvaluator and Service Annotations
>
>
> Diffs
> -----
>
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/security/ModelPermissionEvaluator.java 1190478
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/security/impl/DefaultWidgetRatingPermissionEvaluator.java PRE-CREATION
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/security/impl/RavePermissionEvaluator.java 1190478
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/WidgetRatingService.java 1190478
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/impl/DefaultWidgetRatingService.java 1190478
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/security/impl/DefaultWidgetRatingPermissionEvaluatorTest.java PRE-CREATION
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/service/impl/DefaultWidgetRatingServiceTest.java 1190478
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/api/rest/WidgetApi.java 1190478
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/api/rest/WidgetApiTest.java 1190478
>
> Diff: https://reviews.apache.org/r/2584/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Venkat
>
>
Re: Review Request: RAVE-315 WidgetRating - ModelPermissionEvaluator and
Service Annotations
Posted by Raminder Singh <ra...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2584/#review2924
-----------------------------------------------------------
Create a patch from latest version of WidgetApi as some changes are conflicting
https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/api/rest/WidgetApi.java
<https://reviews.apache.org/r/2584/#comment6557>
Because of this conflict in 2 different versions patch is getting FAILED status when i am applying on latest version of the code
https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/api/rest/WidgetApiTest.java
<https://reviews.apache.org/r/2584/#comment6556>
Because of this conflict in 2 different versions patch is getting FAILED status when i am applying on latest version of the code
- Raminder
On 2011-10-28 18:09:46, Venkat Mahadevan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2584/
> -----------------------------------------------------------
>
> (Updated 2011-10-28 18:09:46)
>
>
> Review request for rave.
>
>
> Summary
> -------
>
> This is the patch for RAVE-315: WidgetRating - ModelPermissionEvaluator and Service Annotations
>
>
> Diffs
> -----
>
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/security/ModelPermissionEvaluator.java 1190478
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/security/impl/DefaultWidgetRatingPermissionEvaluator.java PRE-CREATION
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/security/impl/RavePermissionEvaluator.java 1190478
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/WidgetRatingService.java 1190478
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/impl/DefaultWidgetRatingService.java 1190478
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/security/impl/DefaultWidgetRatingPermissionEvaluatorTest.java PRE-CREATION
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/service/impl/DefaultWidgetRatingServiceTest.java 1190478
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/api/rest/WidgetApi.java 1190478
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/api/rest/WidgetApiTest.java 1190478
>
> Diff: https://reviews.apache.org/r/2584/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Venkat
>
>
Re: Review Request: RAVE-315 WidgetRating - ModelPermissionEvaluator and
Service Annotations
Posted by Venkat Mahadevan <ve...@mitre.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2584/
-----------------------------------------------------------
(Updated 2011-10-28 18:09:46.333480)
Review request for rave.
Changes
-------
Updated
Summary
-------
This is the patch for RAVE-315: WidgetRating - ModelPermissionEvaluator and Service Annotations
Diffs (updated)
-----
https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/security/ModelPermissionEvaluator.java 1190478
https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/security/impl/DefaultWidgetRatingPermissionEvaluator.java PRE-CREATION
https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/security/impl/RavePermissionEvaluator.java 1190478
https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/WidgetRatingService.java 1190478
https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/impl/DefaultWidgetRatingService.java 1190478
https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/security/impl/DefaultWidgetRatingPermissionEvaluatorTest.java PRE-CREATION
https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/service/impl/DefaultWidgetRatingServiceTest.java 1190478
https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/api/rest/WidgetApi.java 1190478
https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/api/rest/WidgetApiTest.java 1190478
Diff: https://reviews.apache.org/r/2584/diff
Testing
-------
Thanks,
Venkat
Re: Review Request: RAVE-315 WidgetRating - ModelPermissionEvaluator and
Service Annotations
Posted by Venkat Mahadevan <ve...@mitre.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2584/
-----------------------------------------------------------
(Updated 2011-10-27 20:33:55.639478)
Review request for rave.
Changes
-------
The service layer had a bad annotation. Let me know whether this works.
Summary
-------
This is the patch for RAVE-315: WidgetRating - ModelPermissionEvaluator and Service Annotations
Diffs (updated)
-----
https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/security/ModelPermissionEvaluator.java 1189948
https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/security/impl/DefaultWidgetRatingPermissionEvaluator.java PRE-CREATION
https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/security/impl/RavePermissionEvaluator.java 1189948
https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/WidgetRatingService.java 1189948
https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/security/impl/DefaultWidgetRatingPermissionEvaluatorTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/2584/diff
Testing
-------
Thanks,
Venkat
Re: Review Request: RAVE-315 WidgetRating - ModelPermissionEvaluator and
Service Annotations
Posted by Raminder Singh <ra...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2584/#review2886
-----------------------------------------------------------
https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/security/impl/DefaultWidgetRatingPermissionEvaluator.java
<https://reviews.apache.org/r/2584/#comment6468>
Remove your signatures. i think that is not allowed
- Raminder
On 2011-10-27 18:44:45, Venkat Mahadevan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2584/
> -----------------------------------------------------------
>
> (Updated 2011-10-27 18:44:45)
>
>
> Review request for rave.
>
>
> Summary
> -------
>
> This is the patch for RAVE-315: WidgetRating - ModelPermissionEvaluator and Service Annotations
>
>
> Diffs
> -----
>
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/security/impl/DefaultWidgetRatingPermissionEvaluatorTest.java PRE-CREATION
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/security/impl/RavePermissionEvaluator.java 1189891
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/WidgetRatingService.java 1189891
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/security/ModelPermissionEvaluator.java 1189891
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/security/impl/DefaultWidgetRatingPermissionEvaluator.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/2584/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Venkat
>
>
Re: Review Request: RAVE-315 WidgetRating - ModelPermissionEvaluator and
Service Annotations
Posted by Raminder Singh <ra...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2584/#review2887
-----------------------------------------------------------
https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/security/impl/DefaultWidgetRatingPermissionEvaluatorTest.java
<https://reviews.apache.org/r/2584/#comment6469>
same about signatures
- Raminder
On 2011-10-27 18:44:45, Venkat Mahadevan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2584/
> -----------------------------------------------------------
>
> (Updated 2011-10-27 18:44:45)
>
>
> Review request for rave.
>
>
> Summary
> -------
>
> This is the patch for RAVE-315: WidgetRating - ModelPermissionEvaluator and Service Annotations
>
>
> Diffs
> -----
>
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/security/impl/DefaultWidgetRatingPermissionEvaluatorTest.java PRE-CREATION
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/security/impl/RavePermissionEvaluator.java 1189891
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/WidgetRatingService.java 1189891
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/security/ModelPermissionEvaluator.java 1189891
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/security/impl/DefaultWidgetRatingPermissionEvaluator.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/2584/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Venkat
>
>
Re: Review Request: RAVE-315 WidgetRating - ModelPermissionEvaluator and
Service Annotations
Posted by Raminder Singh <ra...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2584/#review2888
-----------------------------------------------------------
looks good visually. need to test by applying the patch
- Raminder
On 2011-10-27 18:44:45, Venkat Mahadevan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2584/
> -----------------------------------------------------------
>
> (Updated 2011-10-27 18:44:45)
>
>
> Review request for rave.
>
>
> Summary
> -------
>
> This is the patch for RAVE-315: WidgetRating - ModelPermissionEvaluator and Service Annotations
>
>
> Diffs
> -----
>
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/security/impl/DefaultWidgetRatingPermissionEvaluatorTest.java PRE-CREATION
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/security/impl/RavePermissionEvaluator.java 1189891
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/WidgetRatingService.java 1189891
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/security/ModelPermissionEvaluator.java 1189891
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/security/impl/DefaultWidgetRatingPermissionEvaluator.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/2584/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Venkat
>
>